Add error messages for unsupported rates or number of channels.

[vlc] / modules / codec / lpcm.c

diff --git a/modules/codec/lpcm.c b/modules/codec/lpcm.c
index 32346f1d0ebe626362aeb7c80801f419221aa960..839d463175200bb7a4c3b3c5f804007eed064f0c 100644 (file)
--- a/modules/codec/lpcm.c
+++ b/modules/codec/lpcm.c
@@ -93,6 +93,7 @@ struct decoder_sys_t
     int      i_type;
 };
 
+#ifdef ENABLE_SOUT
 struct encoder_sys_t
 {
     int     i_channels;
@@ -103,20 +104,19 @@ struct encoder_sys_t
     int     i_buffer_used;
     int     i_frame_num;
 };
+#endif
 
 /*
  * LPCM DVD header :
- * - number of frames in this packet (8 bits)
- * - first access unit (16 bits) == 0x0003 ?
- * - emphasis (1 bit)
- * - mute (1 bit)
- * - reserved (1 bit)
- * - current frame (5 bits)
- * - quantisation (2 bits) 0 == 16bps, 1 == 20bps, 2 == 24bps, 3 == illegal
- * - frequency (2 bits) 0 == 48 kHz, 1 == 96 kHz, 2 == 44.1 kHz, 3 == 32 kHz
- * - reserved (1 bit)
+ * - frame number (8 bits)
+ * - unknown (16 bits) == 0x0003 ?
+ * - unknown (4 bits)
+ * - current frame (4 bits)
+ * - unknown (2 bits)
+ * - frequency (2 bits) 0 == 48 kHz, 1 == 32 kHz, 2 == ?, 3 == ?
+ * - unknown (1 bit)
  * - number of channels - 1 (3 bits) 1 == 2 channels
- * - dynamic range (8 bits) 0x80 == neutral
+ * - start code (8 bits) == 0x80
  *
  * LPCM DVD-A header (http://dvd-audio.sourceforge.net/spec/aob.shtml)
  * - continuity counter (8 bits, clipped to 0x00-0x1f)
@@ -434,13 +434,23 @@ static int OpenEncoder( vlc_object_t *p_this )
     encoder_sys_t *p_sys;
 
     /* We only support DVD LPCM yet. */
-    if( p_enc->fmt_out.i_codec != VLC_CODEC_DVD_LPCM ||
-        ( p_enc->fmt_in.audio.i_rate != 48000 &&
-          p_enc->fmt_in.audio.i_rate != 96000 &&
-          p_enc->fmt_in.audio.i_rate != 44100 &&
-          p_enc->fmt_in.audio.i_rate != 32000 ) ||
-       p_enc->fmt_in.audio.i_channels > 8 )
+    if( p_enc->fmt_out.i_codec != VLC_CODEC_DVD_LPCM )
+        return VLC_EGENERIC;
+
+    if( p_enc->fmt_in.audio.i_rate != 48000 &&
+        p_enc->fmt_in.audio.i_rate != 96000 &&
+        p_enc->fmt_in.audio.i_rate != 44100 &&
+        p_enc->fmt_in.audio.i_rate != 32000 )
+    {
+        msg_Err( p_enc, "DVD LPCM supports only sample rates of 48, 96, 44.1 or 32 kHz" );
         return VLC_EGENERIC;
+    }
+
+    if( p_enc->fmt_in.audio.i_channels > 8 )
+    {
+        msg_Err( p_enc, "DVD LPCM supports a maximum of eight channels" );
+        return VLC_EGENERIC;
+    }
 
     /* Allocate the memory needed to store the encoder's structure */
     if( ( p_enc->p_sys = p_sys =