X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=colorspace_conversion_effect_test.cpp;h=b268ce00caf92c8ce88cce81e277510166783732;hb=HEAD;hp=3361489e0e15dca4f4a1e99d2679ee815bc98022;hpb=b10c546f579c7ccb5939161e61a71cd18a3f9bbd;p=movit

diff --git a/colorspace_conversion_effect_test.cpp b/colorspace_conversion_effect_test.cpp
index 3361489..b268ce0 100644
--- a/colorspace_conversion_effect_test.cpp
+++ b/colorspace_conversion_effect_test.cpp
@@ -1,8 +1,12 @@
 // Unit tests for ColorspaceConversionEffect.
 
-#include "test_util.h"
-#include "gtest/gtest.h"
+#include <epoxy/gl.h>
+
 #include "colorspace_conversion_effect.h"
+#include "gtest/gtest.h"
+#include "test_util.h"
+
+namespace movit {
 
 TEST(ColorspaceConversionEffectTest, Reversible) {
 	float data[] = {
@@ -37,7 +41,7 @@ TEST(ColorspaceConversionEffectTest, sRGB_Primaries) {
 	};
 	float out_data[4 * 5];
 
-	EffectChainTester tester(data, 1, 5, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR);
+	EffectChainTester tester(data, 1, 5, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR, GL_RGBA32F);
 	tester.run(out_data, GL_RGBA, COLORSPACE_XYZ, GAMMA_LINEAR);
 
 	// Black should stay black.
@@ -83,6 +87,21 @@ TEST(ColorspaceConversionEffectTest, sRGB_Primaries) {
 	EXPECT_NEAR(0.150, blue_x, 1e-3);
 	EXPECT_NEAR(0.060, blue_y, 1e-3);
 	EXPECT_FLOAT_EQ(1.0f, out_data[4 * 4 + 3]);
+
+	// The forward matrix should be exactly as specified in the standard,
+	// up to floating-point precision. (We're not compliant with the
+	// inverse matrix, but we should be very close.)
+	EXPECT_FLOAT_EQ(0.4124f, out_data[2 * 4 + 0]);
+	EXPECT_FLOAT_EQ(0.2126f, out_data[2 * 4 + 1]);
+	EXPECT_FLOAT_EQ(0.0193f, out_data[2 * 4 + 2]);
+
+	EXPECT_FLOAT_EQ(0.3576f, out_data[3 * 4 + 0]);
+	EXPECT_FLOAT_EQ(0.7152f, out_data[3 * 4 + 1]);
+	EXPECT_FLOAT_EQ(0.1192f, out_data[3 * 4 + 2]);
+
+	EXPECT_FLOAT_EQ(0.1805f, out_data[4 * 4 + 0]);
+	EXPECT_FLOAT_EQ(0.0722f, out_data[4 * 4 + 1]);
+	EXPECT_FLOAT_EQ(0.9505f, out_data[4 * 4 + 2]);
 }
 
 TEST(ColorspaceConversionEffectTest, Rec601_525_Primaries) {
@@ -185,6 +204,56 @@ TEST(ColorspaceConversionEffectTest, Rec601_625_Primaries) {
 	EXPECT_FLOAT_EQ(1.0f, out_data[4 * 4 + 3]);
 }
 
+TEST(ColorspaceConversionEffectTest, Rec2020_Primaries) {
+	float data[] = {
+		0.0f, 0.0f, 0.0f, 1.0f,
+		1.0f, 1.0f, 1.0f, 1.0f,
+		1.0f, 0.0f, 0.0f, 1.0f,
+		0.0f, 1.0f, 0.0f, 1.0f,
+		0.0f, 0.0f, 1.0f, 1.0f,
+	};
+	float out_data[4 * 5];
+
+	EffectChainTester tester(data, 1, 5, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_REC_2020, GAMMA_LINEAR);
+	tester.run(out_data, GL_RGBA, COLORSPACE_XYZ, GAMMA_LINEAR);
+
+	// Black should stay black.
+	EXPECT_FLOAT_EQ(0.0f, out_data[0 * 4 + 0]);
+	EXPECT_FLOAT_EQ(0.0f, out_data[0 * 4 + 1]);
+	EXPECT_FLOAT_EQ(0.0f, out_data[0 * 4 + 2]);
+	EXPECT_FLOAT_EQ(1.0f, out_data[0 * 4 + 3]);
+
+	// Convert the primaries from XYZ to xyz, and compare to the references
+	// given by Rec. 2020.
+	float white_xyz_sum = out_data[1 * 4 + 0] + out_data[1 * 4 + 1] + out_data[1 * 4 + 2];
+	float white_x = out_data[1 * 4 + 0] / white_xyz_sum;
+	float white_y = out_data[1 * 4 + 1] / white_xyz_sum;
+	EXPECT_NEAR(0.3127, white_x, 1e-3);
+	EXPECT_NEAR(0.3290, white_y, 1e-3);
+	EXPECT_FLOAT_EQ(1.0f, out_data[1 * 4 + 3]);
+
+	float red_xyz_sum = out_data[2 * 4 + 0] + out_data[2 * 4 + 1] + out_data[2 * 4 + 2];
+	float red_x = out_data[2 * 4 + 0] / red_xyz_sum;
+	float red_y = out_data[2 * 4 + 1] / red_xyz_sum;
+	EXPECT_NEAR(0.708, red_x, 1e-3);
+	EXPECT_NEAR(0.292, red_y, 1e-3);
+	EXPECT_FLOAT_EQ(1.0f, out_data[2 * 4 + 3]);
+
+	float green_xyz_sum = out_data[3 * 4 + 0] + out_data[3 * 4 + 1] + out_data[3 * 4 + 2];
+	float green_x = out_data[3 * 4 + 0] / green_xyz_sum;
+	float green_y = out_data[3 * 4 + 1] / green_xyz_sum;
+	EXPECT_NEAR(0.170, green_x, 1e-3);
+	EXPECT_NEAR(0.797, green_y, 1e-3);
+	EXPECT_FLOAT_EQ(1.0f, out_data[3 * 4 + 3]);
+
+	float blue_xyz_sum = out_data[4 * 4 + 0] + out_data[4 * 4 + 1] + out_data[4 * 4 + 2];
+	float blue_x = out_data[4 * 4 + 0] / blue_xyz_sum;
+	float blue_y = out_data[4 * 4 + 1] / blue_xyz_sum;
+	EXPECT_NEAR(0.131, blue_x, 1e-3);
+	EXPECT_NEAR(0.046, blue_y, 1e-3);
+	EXPECT_FLOAT_EQ(1.0f, out_data[4 * 4 + 3]);
+}
+
 TEST(ColorspaceConversionEffectTest, sRGBToRec601_525) {
 	float data[] = {
 		0.0f, 0.0f, 0.0f, 1.0f,
@@ -226,3 +295,5 @@ TEST(ColorspaceConversionEffectTest, sRGBToRec601_525) {
 
 	expect_equal(expected_data, out_data, 4, 6);
 }
+
+}  // namespace movit