From: Rémi Duraffort <ivoire@videolan.org>
Date: Sat, 2 Oct 2010 07:49:25 +0000 (+0200)
Subject: playlist: do not signal the playlist thread when PLAYLIST_PAUSE is asked without... 
X-Git-Tag: 1.2.0-pre1~5195
X-Git-Url: https://git.sesse.net/?p=vlc;a=commitdiff_plain;h=e6cd528635caf98867b5182bb9d7c6aca02ae1dc

playlist: do not signal the playlist thread when PLAYLIST_PAUSE is asked without input.

This fix a strange behavior if playlist_Pause is called without input.
---

diff --git a/src/playlist/control.c b/src/playlist/control.c
index 38ddf48564..c2f8171f0f 100644
--- a/src/playlist/control.c
+++ b/src/playlist/control.c
@@ -158,9 +158,10 @@ static int PlaylistVAControl( playlist_t * p_playlist, int i_query, va_list args
 
     case PLAYLIST_PAUSE:
         if( !pl_priv(p_playlist)->p_input )
-        {    /* FIXME: is this really useful without input? */
-             pl_priv(p_playlist)->status.i_status = PLAYLIST_PAUSED;
-             break;
+        {   /* FIXME: is this really useful without input? */
+            pl_priv(p_playlist)->status.i_status = PLAYLIST_PAUSED;
+            /* return without notifying the playlist thread as there is nothing to do */
+            return VLC_SUCCESS;
         }
 
         if( var_GetInteger( pl_priv(p_playlist)->p_input, "state" ) == PAUSE_S )