From 3d135acf48c7a731dbb6cb9cdaf037bf6a6a8d20 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Sat, 11 Nov 2023 00:35:02 +0100 Subject: [PATCH] Reduce the number of calls to sort_key(). --- bin/sync.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/bin/sync.pl b/bin/sync.pl index 8ca281d..7b82cac 100644 --- a/bin/sync.pl +++ b/bin/sync.pl @@ -413,10 +413,11 @@ sub find_diff { } for my $real_name (keys %$have_colors) { next if (exists($want_colors->{$real_name})); - if (!exists($seen_names->{sort_key($real_name)})) { + my $sk = sort_key($real_name); + if (!exists($seen_names->{$sk})) { # TODO: This can somehow come if we try to add someone who's not in the sheet, too? skv_log("Ønsket å fjerne at $real_name skulle på trening, men de var ikke i regnearket lenger."); - } elsif (scalar @{$seen_names->{sort_key($real_name)}} > 1) { + } elsif (scalar @{$seen_names->{$sk}} > 1) { # Don't touch them. } else { skv_log("Fjerner at $real_name skal på trening."); @@ -707,11 +708,12 @@ sub run { my $real_name = $slack_userid_to_real_name{$userid}; # See if we can find them in the spreadsheet. - if (!exists($seen_names{sort_key($real_name)})) { + my $sk = sort_key($real_name); + if (!exists($seen_names{$sk})) { # TODO: Perhaps move this logic further down, for consistency? skv_log("$slack_name ($userid) er påmeldt på Slack, og er mappet til $real_name, men var ikke i noen gruppe."); } else { - my $seen = $seen_names{sort_key($real_name)}; + my $seen = $seen_names{$sk}; if (scalar @$seen >= 2) { skv_log("$slack_name ($userid) er påmeldt på Slack, men står flere steder (se over); vet ikke hvilken celle som skal brukes."); } else { -- 2.39.2