X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;ds=sidebyside;f=effect_chain_test.cpp;h=356d628e7e0fbd7dd2c293a9efafd34ed36cfed1;hb=b10c546f579c7ccb5939161e61a71cd18a3f9bbd;hp=21cb2bec6538189d5cfd9bc7b009a014b9e271bf;hpb=29072985d0a00a53e5b578a1444cee61a0c9e1f2;p=movit diff --git a/effect_chain_test.cpp b/effect_chain_test.cpp index 21cb2be..356d628 100644 --- a/effect_chain_test.cpp +++ b/effect_chain_test.cpp @@ -89,6 +89,10 @@ public: InvertEffect() {} virtual std::string effect_type_id() const { return "InvertEffect"; } std::string output_fragment_shader() { return read_file("invert_effect.frag"); } + + // A real invert would actually care about its alpha, + // but in this unit test, it only complicates things. + virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; } }; // Like IdentityEffect, but rewrites itself out of the loop, @@ -185,6 +189,61 @@ TEST(EffectChainTest, RewritingWorksAndColorspaceConversionsAreInserted) { expect_equal(expected_data, out_data, 3, 2); } +// A fake input that can change its output colorspace and gamma between instantiation +// and finalize. +class UnknownColorspaceInput : public FlatInput { +public: + UnknownColorspaceInput(ImageFormat format, MovitPixelFormat pixel_format, GLenum type, unsigned width, unsigned height) + : FlatInput(format, pixel_format, type, width, height), + overridden_color_space(format.color_space), + overridden_gamma_curve(format.gamma_curve) {} + virtual std::string effect_type_id() const { return "UnknownColorspaceInput"; } + + void set_color_space(Colorspace colorspace) { + overridden_color_space = colorspace; + } + void set_gamma_curve(GammaCurve gamma_curve) { + overridden_gamma_curve = gamma_curve; + } + Colorspace get_color_space() const { return overridden_color_space; } + GammaCurve get_gamma_curve() const { return overridden_gamma_curve; } + +private: + Colorspace overridden_color_space; + GammaCurve overridden_gamma_curve; +}; + +TEST(EffectChainTester, HandlesInputChangingColorspace) { + const int size = 4; + + float data[size] = { + 0.0, + 0.5, + 0.7, + 1.0, + }; + float out_data[size]; + + EffectChainTester tester(NULL, 4, 1, FORMAT_GRAYSCALE); + + // First say that we have sRGB, linear input. + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_LINEAR; + + UnknownColorspaceInput *input = new UnknownColorspaceInput(format, FORMAT_GRAYSCALE, GL_FLOAT, 4, 1); + input->set_pixel_data(data); + tester.get_chain()->add_input(input); + + // Now we change to Rec. 601 input. + input->set_color_space(COLORSPACE_REC_601_625); + input->set_gamma_curve(GAMMA_REC_601); + + // Now ask for Rec. 601 output. Thus, our chain should now be a no-op. + tester.run(out_data, GL_RED, COLORSPACE_REC_601_625, GAMMA_REC_601); + expect_equal(data, out_data, 4, 1); +} + // Like RewritingToInvertEffect, but splicing in a MirrorEffect instead, // which does not need linear light or sRGB primaries. class RewritingToMirrorEffect : public Effect { @@ -296,6 +355,118 @@ TEST(EffectChainTest, IdentityThroughRec709) { expect_equal(data, out_data, 256, 1); } +// The identity effect needs premultiplied alpha, and thus will get conversions on both sides. +TEST(EffectChainTest, IdentityThroughAlphaConversions) { + const int size = 3; + float data[4 * size] = { + 0.8f, 0.0f, 0.0f, 0.5f, + 0.0f, 0.2f, 0.2f, 0.3f, + 0.1f, 0.0f, 1.0f, 1.0f, + }; + float out_data[6]; + EffectChainTester tester(data, size, 1, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR); + tester.get_chain()->add_effect(new IdentityEffect()); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(data, out_data, 4, size); +} + +TEST(EffectChainTest, NoAlphaConversionsWhenPremultipliedAlphaNotNeeded) { + const int size = 3; + float data[4 * size] = { + 0.8f, 0.0f, 0.0f, 0.5f, + 0.0f, 0.2f, 0.2f, 0.3f, + 0.1f, 0.0f, 1.0f, 1.0f, + }; + float expected_data[4 * size] = { + 0.1f, 0.0f, 1.0f, 1.0f, + 0.0f, 0.2f, 0.2f, 0.3f, + 0.8f, 0.0f, 0.0f, 0.5f, + }; + float out_data[4 * size]; + EffectChainTester tester(data, size, 1, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR); + RewritingToMirrorEffect *effect = new RewritingToMirrorEffect(); + tester.get_chain()->add_effect(effect); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR); + + Node *node = effect->mirror_node; + ASSERT_EQ(1, node->incoming_links.size()); + EXPECT_EQ(0, node->outgoing_links.size()); + EXPECT_EQ("FlatInput", node->incoming_links[0]->effect->effect_type_id()); + + expect_equal(expected_data, out_data, 4, size); +} + +// An input that outputs only blue, which has blank alpha. +class BlueInput : public Input { +public: + BlueInput() { register_int("needs_mipmaps", &needs_mipmaps); } + virtual std::string effect_type_id() const { return "IdentityEffect"; } + std::string output_fragment_shader() { return read_file("blue.frag"); } + virtual AlphaHandling alpha_handling() const { return OUTPUT_BLANK_ALPHA; } + virtual void finalize() {} + virtual bool can_output_linear_gamma() const { return true; } + virtual unsigned get_width() const { return 1; } + virtual unsigned get_height() const { return 1; } + virtual Colorspace get_color_space() const { return COLORSPACE_sRGB; } + virtual GammaCurve get_gamma_curve() const { return GAMMA_LINEAR; } + +private: + int needs_mipmaps; +}; + +// Like RewritingToInvertEffect, but splicing in a BlueInput instead, +// which outputs blank alpha. +class RewritingToBlueInput : public Input { +public: + RewritingToBlueInput() { register_int("needs_mipmaps", &needs_mipmaps); } + virtual std::string effect_type_id() const { return "RewritingToBlueInput"; } + std::string output_fragment_shader() { EXPECT_TRUE(false); return read_file("identity.frag"); } + virtual void rewrite_graph(EffectChain *graph, Node *self) { + Node *blue_node = graph->add_node(new BlueInput()); + graph->replace_receiver(self, blue_node); + graph->replace_sender(self, blue_node); + + self->disabled = true; + this->blue_node = blue_node; + } + + // Dummy values that we need to implement because we inherit from Input. + // Same as BlueInput. + virtual AlphaHandling alpha_handling() const { return OUTPUT_BLANK_ALPHA; } + virtual void finalize() {} + virtual bool can_output_linear_gamma() const { return true; } + virtual unsigned get_width() const { return 1; } + virtual unsigned get_height() const { return 1; } + virtual Colorspace get_color_space() const { return COLORSPACE_sRGB; } + virtual GammaCurve get_gamma_curve() const { return GAMMA_LINEAR; } + + Node *blue_node; + +private: + int needs_mipmaps; +}; + +TEST(EffectChainTest, NoAlphaConversionsWithBlankAlpha) { + const int size = 3; + float data[4 * size] = { + 0.0f, 0.0f, 1.0f, 1.0f, + 0.0f, 0.0f, 1.0f, 1.0f, + 0.0f, 0.0f, 1.0f, 1.0f, + }; + float out_data[4 * size]; + EffectChainTester tester(NULL, size, 1); + RewritingToBlueInput *input = new RewritingToBlueInput(); + tester.get_chain()->add_input(input); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR, OUTPUT_ALPHA_PREMULTIPLIED); + + Node *node = input->blue_node; + EXPECT_EQ(0, node->incoming_links.size()); + EXPECT_EQ(0, node->outgoing_links.size()); + + expect_equal(data, out_data, 4, size); +} + // Effectively scales down its input linearly by 4x (and repeating it), // which is not attainable without mipmaps. class MipmapNeedingEffect : public Effect {