X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=effect_chain.cpp;h=ca6905bf53c177f3f5988dc2f08173b3b495584a;hb=983fe15061b6e199877577b363a9f2fa102cf107;hp=e4ab7199c8d23320c545d47c98b4c53dec39af3b;hpb=4a9f9844aec346c73a1e96d7164b3d993c619d06;p=movit

diff --git a/effect_chain.cpp b/effect_chain.cpp
index e4ab719..ca6905b 100644
--- a/effect_chain.cpp
+++ b/effect_chain.cpp
@@ -53,15 +53,6 @@ EffectChain::~EffectChain()
 		delete nodes[i];
 	}
 	for (unsigned i = 0; i < phases.size(); ++i) {
-		glBindVertexArray(phases[i]->vao);
-		check_error();
-
-		cleanup_vertex_attribute(phases[i]->glsl_program_num, "position", phases[i]->position_vbo);
-		cleanup_vertex_attribute(phases[i]->glsl_program_num, "texcoord", phases[i]->texcoord_vbo);
-
-		glBindVertexArray(0);
-		check_error();
-
 		resource_pool->release_glsl_program(phases[i]->glsl_program_num);
 		delete phases[i];
 	}
@@ -291,27 +282,6 @@ void EffectChain::compile_glsl_program(Phase *phase)
 	frag_shader.append(read_file("footer.frag"));
 
 	phase->glsl_program_num = resource_pool->compile_glsl_program(read_file("vs.vert"), frag_shader);
-
-	// Prepare the geometry for the fullscreen quad used in this phase.
-	// (We have separate VAOs per shader, since the bindings can in theory
-	// be different.)
-	float vertices[] = {
-		0.0f, 1.0f,
-		0.0f, 0.0f,
-		1.0f, 1.0f,
-		1.0f, 0.0f
-	};
-
-	glGenVertexArrays(1, &phase->vao);
-	check_error();
-	glBindVertexArray(phase->vao);
-	check_error();
-
-	phase->position_vbo = fill_vertex_attribute(phase->glsl_program_num, "position", 2, GL_FLOAT, sizeof(vertices), vertices);
-	phase->texcoord_vbo = fill_vertex_attribute(phase->glsl_program_num, "texcoord", 2, GL_FLOAT, sizeof(vertices), vertices);  // Same as vertices.
-
-	glBindVertexArray(0);
-	check_error();
 }
 
 // Construct GLSL programs, starting at the given effect and following
@@ -1484,8 +1454,6 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height
 
 	glBindFramebuffer(GL_FRAMEBUFFER, 0);
 	check_error();
-	glBindVertexArray(0);
-	check_error();
 	glUseProgram(0);
 	check_error();
 }
@@ -1547,11 +1515,32 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, map<Phase *, GLui
 		}
 	}
 
-	glBindVertexArray(phase->vao);
+	// Now draw!
+	float vertices[] = {
+		0.0f, 1.0f,
+		0.0f, 0.0f,
+		1.0f, 1.0f,
+		1.0f, 0.0f
+	};
+
+	GLuint vao;
+	glGenVertexArrays(1, &vao);
+	check_error();
+	glBindVertexArray(vao);
 	check_error();
+
+	GLuint position_vbo = fill_vertex_attribute(glsl_program_num, "position", 2, GL_FLOAT, sizeof(vertices), vertices);
+	GLuint texcoord_vbo = fill_vertex_attribute(glsl_program_num, "texcoord", 2, GL_FLOAT, sizeof(vertices), vertices);  // Same as vertices.
+
 	glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
 	check_error();
 
+	cleanup_vertex_attribute(glsl_program_num, "position", position_vbo);
+	cleanup_vertex_attribute(glsl_program_num, "texcoord", texcoord_vbo);
+	
+	glUseProgram(0);
+	check_error();
+
 	for (unsigned i = 0; i < phase->effects.size(); ++i) {
 		Node *node = phase->effects[i];
 		node->effect->clear_gl_state();
@@ -1560,6 +1549,9 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, map<Phase *, GLui
 	if (!last_phase) {
 		resource_pool->release_fbo(fbo);
 	}
+
+	glDeleteVertexArrays(1, &vao);
+	check_error();
 }
 
 void EffectChain::setup_rtt_sampler(GLuint glsl_program_num, int sampler_num, const string &effect_id, bool use_mipmaps)