X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=effect_chain_test.cpp;h=5ffb105cdb75ccd805caa1f9f25bfd322dac6f1e;hb=bb578b403deef87c90b330f860ad35d80433b702;hp=596570c67dd3dc6858ea0815c7202d1e50936c67;hpb=813bc3bfcacfeed72b9b6cfdae6156b35ad4860b;p=movit diff --git a/effect_chain_test.cpp b/effect_chain_test.cpp index 596570c..5ffb105 100644 --- a/effect_chain_test.cpp +++ b/effect_chain_test.cpp @@ -1022,6 +1022,38 @@ TEST(EffectChainTest, AspectRatioConversion) { EXPECT_EQ(7, input_store->input_height); } +// Tests that putting a BlueInput (constant color) into its own pass, +// which creates a phase that doesn't need texture coordinates, +// doesn't mess up a second phase that actually does. +TEST(EffectChainTest, FirstPhaseWithNoTextureCoordinates) { + const int size = 2; + float data[] = { + 1.0f, + 0.0f, + }; + float expected_data[] = { + 1.0f, 1.0f, 2.0f, 2.0f, + 0.0f, 0.0f, 1.0f, 2.0f, + }; + float out_data[size * 4]; + // First say that we have sRGB, linear input. + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_LINEAR; + FlatInput *input = new FlatInput(format, FORMAT_GRAYSCALE, GL_FLOAT, 1, size); + + input->set_pixel_data(data); + EffectChainTester tester(NULL, 1, size); + tester.get_chain()->add_input(new BlueInput()); + Effect *phase1_end = tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.get_chain()->add_input(input); + tester.get_chain()->add_effect(new AddEffect(), phase1_end, input); + + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED); + + expect_equal(expected_data, out_data, 4, size); +} + // An effect that does nothing except changing its output sizes. class VirtualResizeEffect : public Effect { public: @@ -1248,7 +1280,12 @@ TEST(EffectChainTest, StringStreamLocalesWork) { // the test will always succeed. Note that the OpenGL driver might call // setlocale() behind-the-scenes, and that might corrupt the returned // pointer, so we need to take our own copy of it here. - char *saved_locale = strdup(setlocale(LC_ALL, "nb_NO.UTF_8")); + char *saved_locale = setlocale(LC_ALL, "nb_NO.UTF_8"); + if (saved_locale == NULL) { + // The locale wasn't available. + return; + } + saved_locale = strdup(saved_locale); float data[] = { 0.0f, 0.0f, 0.0f, 0.0f, }; @@ -1266,5 +1303,117 @@ TEST(EffectChainTest, StringStreamLocalesWork) { free(saved_locale); } +TEST(EffectChainTest, sRGBIntermediate) { + float data[] = { + 0.0f, 0.5f, 0.0f, 1.0f, + }; + float out_data[4]; + EffectChainTester tester(data, 1, 1, FORMAT_RGBA_PREMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR); + tester.get_chain()->set_intermediate_format(GL_SRGB8); + tester.get_chain()->add_effect(new IdentityEffect()); + tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR); + + EXPECT_GE(fabs(out_data[1] - data[1]), 1e-3) + << "Expected sRGB not to be able to represent 0.5 exactly (got " << out_data[1] << ")"; + EXPECT_LT(fabs(out_data[1] - data[1]), 0.1f) + << "Expected sRGB to be able to represent 0.5 approximately (got " << out_data[1] << ")"; +} + +// An effect that is like IdentityEffect, but also does not require linear light. +class PassThroughEffect : public IdentityEffect { +public: + PassThroughEffect() {} + virtual string effect_type_id() const { return "PassThroughEffect"; } + virtual bool needs_linear_light() const { return false; } + AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; } +}; + +// Same, just also bouncing. +class BouncingPassThroughEffect : public BouncingIdentityEffect { +public: + BouncingPassThroughEffect() {} + virtual string effect_type_id() const { return "BouncingPassThroughEffect"; } + virtual bool needs_linear_light() const { return false; } + bool needs_texture_bounce() const { return true; } + AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; } +}; + +TEST(EffectChainTest, Linear10bitIntermediateAccuracy) { + // Note that we do the comparison in sRGB space, which is what we + // typically would want; however, we do the sRGB conversion ourself + // to avoid compounding errors from shader conversions into the + // analysis. + const int size = 4096; // 12-bit. + float linear_data[size], data[size], out_data[size]; + + for (int i = 0; i < size; ++i) { + linear_data[i] = i / double(size - 1); + data[i] = srgb_to_linear(linear_data[i]); + } + + EffectChainTester tester(data, size, 1, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR, GL_RGBA32F); + tester.get_chain()->set_intermediate_format(GL_RGB10_A2); + tester.get_chain()->add_effect(new IdentityEffect()); + tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + for (int i = 0; i < size; ++i) { + out_data[i] = linear_to_srgb(out_data[i]); + } + + // This maximum error is pretty bad; about 6.5 levels of a 10-bit sRGB + // framebuffer. + expect_equal(linear_data, out_data, size, 1, 7e-3, 2e-5); +} + +TEST(EffectChainTest, SquareRoot10bitIntermediateAccuracy) { + // Note that we do the comparison in sRGB space, which is what we + // typically would want; however, we do the sRGB conversion ourself + // to avoid compounding errors from shader conversions into the + // analysis. + const int size = 4096; // 12-bit. + float linear_data[size], data[size], out_data[size]; + + for (int i = 0; i < size; ++i) { + linear_data[i] = i / double(size - 1); + data[i] = srgb_to_linear(linear_data[i]); + } + + EffectChainTester tester(data, size, 1, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR, GL_RGBA32F); + tester.get_chain()->set_intermediate_format(GL_RGB10_A2, SQUARE_ROOT_FRAMEBUFFER_TRANSFORMATION); + tester.get_chain()->add_effect(new IdentityEffect()); + tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + for (int i = 0; i < size; ++i) { + out_data[i] = linear_to_srgb(out_data[i]); + } + + // This maximum error is much better; about 0.7 levels of a 10-bit sRGB + // framebuffer (ideal would be 0.5). That is an order of magnitude better + // than in the linear test above. The RMS error is much better, too. + expect_equal(linear_data, out_data, size, 1, 7e-4, 5e-6); +} + +TEST(EffectChainTest, SquareRootIntermediateIsTurnedOffForNonLinearData) { + const int size = 256; // 8-bit. + float data[size], out_data[size]; + + for (int i = 0; i < size; ++i) { + data[i] = i / double(size - 1); + } + + EffectChainTester tester(data, size, 1, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_REC_601, GL_RGBA32F); + tester.get_chain()->set_intermediate_format(GL_RGB8, SQUARE_ROOT_FRAMEBUFFER_TRANSFORMATION); + tester.get_chain()->add_effect(new PassThroughEffect()); + tester.get_chain()->add_effect(new BouncingPassThroughEffect()); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_REC_601); + + // The data should be passed through nearly exactly, since there is no effect + // on the path that requires linear light. (Actually, it _is_ exact modulo + // fp32 errors, but the error bounds is strictly _less than_, not zero.) + expect_equal(data, out_data, size, 1, 1e-6, 1e-6); +} } // namespace movit