X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=futatabi%2Fplayer.cpp;h=b2b7ac26764995faaffc0a04dd7052bf3c4a0f03;hb=f1cddd2fcaf4d166b31c7d28e4ccd2201c5508f2;hp=b7b22c8add9dea82b613f06bcc710e1dd529b92d;hpb=2433c661cfff2a10b6f12fec0d53237ac35c333d;p=nageru diff --git a/futatabi/player.cpp b/futatabi/player.cpp index b7b22c8..b2b7ac2 100644 --- a/futatabi/player.cpp +++ b/futatabi/player.cpp @@ -8,6 +8,7 @@ #include "frame_on_disk.h" #include "shared/httpd.h" #include "jpeg_frame_view.h" +#include "shared/metrics.h" #include "shared/mux.h" #include "shared/timebase.h" #include "video_stream.h" @@ -76,6 +77,7 @@ wait_for_clip: if (!clip_ready) { if (video_stream != nullptr) { + ++metric_refresh_frame; video_stream->schedule_refresh_frame(steady_clock::now(), pts, /*display_func=*/nullptr, QueueSpotHolder()); } continue; @@ -108,16 +110,13 @@ got_clip: } } - // TODO: Lock to a rational multiple of the frame rate if possible. - double speed = 0.5; - int64_t in_pts_start_next_clip = -1; steady_clock::time_point next_frame_start; for (int frameno = 0; !should_quit; ++frameno) { // Ends when the clip ends. double out_pts = out_pts_origin + TIMEBASE * frameno / global_flags.output_framerate; next_frame_start = origin + microseconds(lrint((out_pts - out_pts_origin) * 1e6 / TIMEBASE)); - int64_t in_pts = lrint(in_pts_origin + TIMEBASE * frameno * speed / global_flags.output_framerate); + int64_t in_pts = lrint(in_pts_origin + TIMEBASE * frameno * clip.speed / global_flags.output_framerate); pts = lrint(out_pts); if (in_pts >= clip.pts_out) { @@ -128,19 +127,20 @@ got_clip: if (stream_output != FILE_STREAM_OUTPUT && time_behind >= milliseconds(200)) { fprintf(stderr, "WARNING: %ld ms behind, dropping a frame (no matter the type).\n", lrint(1e3 * duration(time_behind).count())); + ++metric_dropped_unconditional_frame; continue; } - double time_left_this_clip = double(clip.pts_out - in_pts) / TIMEBASE / speed; + double time_left_this_clip = double(clip.pts_out - in_pts) / TIMEBASE / clip.speed; if (!got_next_clip && next_clip_callback != nullptr && time_left_this_clip <= clip.fade_time_seconds) { // Find the next clip so that we can begin a fade. tie(next_clip, next_clip_idx) = next_clip_callback(); if (next_clip.pts_in != -1) { got_next_clip = true; - double duration_next_clip = double(next_clip.pts_out - next_clip.pts_in) / TIMEBASE / speed; + double duration_next_clip = double(next_clip.pts_out - next_clip.pts_in) / TIMEBASE / clip.speed; next_clip_fade_time = std::min(time_left_this_clip, duration_next_clip); - in_pts_start_next_clip = next_clip.pts_in + lrint(next_clip_fade_time * TIMEBASE * speed); + in_pts_start_next_clip = next_clip.pts_in + lrint(next_clip_fade_time * TIMEBASE * clip.speed); } } @@ -153,7 +153,7 @@ got_clip: float fade_alpha = 0.0f; if (got_next_clip && time_left_this_clip <= next_clip_fade_time) { secondary_stream_idx = next_clip.stream_idx; - int64_t in_pts_secondary = lrint(next_clip.pts_in + (next_clip_fade_time - time_left_this_clip) * TIMEBASE * speed); + int64_t in_pts_secondary = lrint(next_clip.pts_in + (next_clip_fade_time - time_left_this_clip) * TIMEBASE * clip.speed); in_pts_secondary_for_progress = in_pts_secondary; fade_alpha = 1.0f - time_left_this_clip / next_clip_fade_time; @@ -174,13 +174,13 @@ got_clip: if (progress_callback != nullptr) { // NOTE: None of this will take into account any snapping done below. - double played_this_clip = double(in_pts_for_progress - clip.pts_in) / TIMEBASE / speed; - double total_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / speed; + double played_this_clip = double(in_pts_for_progress - clip.pts_in) / TIMEBASE / clip.speed; + double total_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / clip.speed; map progress{{ clip_idx, played_this_clip / total_length }}; if (got_next_clip && time_left_this_clip <= next_clip_fade_time) { - double played_next_clip = double(in_pts_secondary_for_progress - next_clip.pts_in) / TIMEBASE / speed; - double total_next_length = double(next_clip.pts_out - next_clip.pts_in) / TIMEBASE / speed; + double played_next_clip = double(in_pts_secondary_for_progress - next_clip.pts_in) / TIMEBASE / next_clip.speed; + double total_next_length = double(next_clip.pts_out - next_clip.pts_in) / TIMEBASE / next_clip.speed; progress[next_clip_idx] = played_next_clip / total_next_length; } progress_callback(progress); @@ -245,11 +245,13 @@ got_clip: display_func(); } else { if (secondary_stream_idx == -1) { + ++metric_original_frame; video_stream->schedule_original_frame( next_frame_start, pts, display_func, QueueSpotHolder(this), frame_lower); } else { assert(secondary_frame.pts != -1); + ++metric_faded_frame; video_stream->schedule_faded_frame(next_frame_start, pts, display_func, QueueSpotHolder(this), frame_lower, secondary_frame, fade_alpha); @@ -261,10 +263,10 @@ got_clip: // Snap to input frame: If we can do so with less than 1% jitter // (ie., move less than 1% of an _output_ frame), do so. // TODO: Snap secondary (fade-to) clips in the same fashion. + double pts_snap_tolerance = 0.01 * double(TIMEBASE) / global_flags.output_framerate; bool snapped = false; for (FrameOnDisk snap_frame : { frame_lower, frame_upper }) { - double snap_pts_as_frameno = (snap_frame.pts - in_pts_origin) * global_flags.output_framerate / TIMEBASE / speed; - if (fabs(snap_pts_as_frameno - frameno) < 0.01) { + if (fabs(snap_frame.pts - in_pts) < pts_snap_tolerance) { auto display_func = [this, primary_stream_idx, snap_frame, secondary_frame, fade_alpha]{ if (destination != nullptr) { destination->setFrame(primary_stream_idx, snap_frame, secondary_frame, fade_alpha); @@ -274,11 +276,13 @@ got_clip: display_func(); } else { if (secondary_stream_idx == -1) { + ++metric_original_snapped_frame; video_stream->schedule_original_frame( next_frame_start, pts, display_func, QueueSpotHolder(this), snap_frame); } else { assert(secondary_frame.pts != -1); + ++metric_faded_snapped_frame; video_stream->schedule_faded_frame( next_frame_start, pts, display_func, QueueSpotHolder(this), snap_frame, secondary_frame, fade_alpha); @@ -293,9 +297,35 @@ got_clip: continue; } + // The snapping above makes us lock to the input framerate, even in the presence + // of pts drift, for most typical cases where it's needed, like converting 60 → 2x60 + // or 60 → 2x59.94. However, there are some corner cases like 25 → 2x59.94, where we'd + // get a snap very rarely (in the given case, once every 24 output frames), and by + // that time, we'd have drifted out. We could have solved this by changing the overall + // speed ever so slightly, but it requires that we know the actual frame rate (which + // is difficult in the presence of jitter and missed frames), or at least do some kind + // of matching/clustering. Instead, we take the opportunity to lock to in-between rational + // points if we can. E.g., if we are converting 60 → 2x60, we would not only snap to + // an original frame every other frame; we would also snap to exactly alpha=0.5 every + // in-between frame. Of course, we will still need to interpolate, but we get a lot + // closer when we actually get close to an original frame. In other words: Snap more + // often, but snap less each time. Unless the input and output frame rates are completely + // decorrelated with no common factor, of course (e.g. 12.345 → 34.567, which we should + // really never see in practice). + for (double fraction : { 1.0 / 2.0, 1.0 / 3.0, 2.0 / 3.0, 1.0 / 4.0, 3.0 / 4.0, + 1.0 / 5.0, 2.0 / 5.0, 3.0 / 5.0, 4.0 / 5.0 }) { + double subsnap_pts = frame_lower.pts + fraction * (frame_upper.pts - frame_lower.pts); + if (fabs(subsnap_pts - in_pts) < pts_snap_tolerance) { + in_pts_origin += lrint(subsnap_pts) - in_pts; + in_pts = lrint(subsnap_pts); + break; + } + } + if (stream_output != FILE_STREAM_OUTPUT && time_behind >= milliseconds(100)) { fprintf(stderr, "WARNING: %ld ms behind, dropping an interpolated frame.\n", lrint(1e3 * duration(time_behind).count())); + ++metric_dropped_interpolated_frame; continue; } @@ -313,6 +343,11 @@ got_clip: destination->setFrame(frame); } }; + if (secondary_stream_idx == -1) { + ++metric_interpolated_frame; + } else { + ++metric_interpolated_faded_frame; + } video_stream->schedule_interpolated_frame( next_frame_start, pts, display_func, QueueSpotHolder(this), frame_lower, frame_upper, alpha, @@ -388,6 +423,18 @@ Player::Player(JPEGFrameView *destination, Player::StreamOutput stream_output, A : destination(destination) { player_thread = thread(&Player::thread_func, this, stream_output, file_avctx); + + if (stream_output == HTTPD_STREAM_OUTPUT) { + global_metrics.add("http_output_frames", {{ "type", "original" }, { "reason", "edge_frame_or_no_interpolation" }}, &metric_original_frame); + global_metrics.add("http_output_frames", {{ "type", "faded" }, { "reason", "edge_frame_or_no_interpolation" }}, &metric_faded_frame); + global_metrics.add("http_output_frames", {{ "type", "original" }, { "reason", "snapped" }}, &metric_original_snapped_frame); + global_metrics.add("http_output_frames", {{ "type", "faded" }, { "reason", "snapped" }}, &metric_faded_snapped_frame); + global_metrics.add("http_output_frames", {{ "type", "interpolated" }}, &metric_interpolated_frame); + global_metrics.add("http_output_frames", {{ "type", "interpolated_faded" }}, &metric_interpolated_faded_frame); + global_metrics.add("http_output_frames", {{ "type", "refresh" }}, &metric_refresh_frame); + global_metrics.add("http_dropped_frames", {{ "type", "interpolated" }}, &metric_dropped_interpolated_frame); + global_metrics.add("http_dropped_frames", {{ "type", "unconditional" }}, &metric_dropped_unconditional_frame); + } } Player::~Player() @@ -483,7 +530,7 @@ double compute_time_left(const vector &clips, const map &p double last_fade_time_seconds = 0.0; for (size_t row = last_it->first; row < clips.size(); ++row) { const Clip &clip = clips[row]; - double clip_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / 0.5; // FIXME: stop hardcoding speed. + double clip_length = double(clip.pts_out - clip.pts_in) / TIMEBASE / clip.speed; if (row == last_it->first) { // A clip we're playing: Subtract the part we've already played. remaining = clip_length * (1.0 - last_it->second);