X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=server.cpp;h=6d5cce372ae9c79b81b4b755052252680ce3cf28;hb=0cb56be70f7ca4f4564eea892a99d20032359a1d;hp=b5f58d4c56711968db64a8d6c63e7d9eb08d0e25;hpb=71fc5575037bead8b6e927a1fffd199e4fc4514b;p=cubemap

diff --git a/server.cpp b/server.cpp
index b5f58d4..6d5cce3 100644
--- a/server.cpp
+++ b/server.cpp
@@ -26,6 +26,7 @@
 #include "server.h"
 #include "state.pb.h"
 #include "stream.h"
+#include "util.h"
 
 using namespace std;
 
@@ -51,14 +52,7 @@ Server::~Server()
 		delete stream_it->second;
 	}
 
-	int ret;
-	do {
-		ret = close(epoll_fd);
-	} while (ret == -1 && errno == EINTR);
-
-	if (ret == -1) {
-		log_perror("close(epoll_fd)");
-	}
+	safe_close(epoll_fd);
 }
 
 vector<ClientStats> Server::get_client_stats() const
@@ -76,15 +70,17 @@ vector<ClientStats> Server::get_client_stats() const
 
 void Server::do_work()
 {
-	for ( ;; ) {
-		int nfds = epoll_wait(epoll_fd, events, EPOLL_MAX_EVENTS, EPOLL_TIMEOUT_MS);
-		if (nfds == -1 && errno == EINTR) {
-			if (should_stop) {
-				return;
-			}
-			continue;
-		}
-		if (nfds == -1) {
+	while (!should_stop()) {
+		// Wait until there's activity on at least one of the fds,
+		// or 20 ms (about one frame at 50 fps) has elapsed.
+		//
+		// We could in theory wait forever and rely on wakeup()
+		// from add_client_deferred() and add_data_deferred(),
+		// but wakeup is a pretty expensive operation, and the
+		// two threads might end up fighting over a lock, so it's
+		// seemingly (much) more efficient to just have a timeout here.
+		int nfds = epoll_pwait(epoll_fd, events, EPOLL_MAX_EVENTS, EPOLL_TIMEOUT_MS, &sigset_without_usr1_block);
+		if (nfds == -1 && errno != EINTR) {
 			log_perror("epoll_wait");
 			exit(1);
 		}
@@ -113,10 +109,6 @@ void Server::do_work()
 				process_client(to_process[i]);
 			}
 		}
-
-		if (should_stop) {
-			return;
-		}
 	}
 }
 
@@ -558,14 +550,7 @@ void Server::close_client(Client *client)
 	access_log->write(client->get_stats());
 
 	// Bye-bye!
-	int ret;
-	do {
-		ret = close(client->sock);
-	} while (ret == -1 && errno == EINTR);
-
-	if (ret == -1) {
-		log_perror("close");
-	}
+	safe_close(client->sock);
 
 	clients.erase(client->sock);
 }