X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fsearch.cpp;h=c9a8f58204a4dc9ecddce0f4c3013e1f21b64afd;hb=ff9ca3e76eb6432dee8ed2442e3942b93d0f6ba5;hp=e44324f75802677e47b9a55164f00bcf82f30fb3;hpb=561eb34aea03aeac06ebeb66ad225222143445e6;p=stockfish diff --git a/src/search.cpp b/src/search.cpp index e44324f7..c9a8f582 100644 --- a/src/search.cpp +++ b/src/search.cpp @@ -55,6 +55,9 @@ namespace { // Set to true to force running with one thread. Used for debugging const bool FakeSplit = false; + // This is the minimum interval in msec between two check_time() calls + const int TimerResolution = 5; + // Different node types, used as template parameter enum NodeType { Root, PV, NonPV, SplitPointRoot, SplitPointPV, SplitPointNonPV }; @@ -75,11 +78,6 @@ namespace { : 2 * VALUE_INFINITE; } - inline int futility_move_count(Depth d) { - - return d < 16 * ONE_PLY ? FutilityMoveCounts[d] : MAX_MOVES; - } - // Reduction lookup tables (initialized at startup) and their access function int8_t Reductions[2][64][64]; // [pv][depth][moveNumber] @@ -88,14 +86,6 @@ namespace { return (Depth) Reductions[PvNode][std::min(int(d) / ONE_PLY, 63)][std::min(mn, 63)]; } - // Easy move margin. An easy move candidate must be at least this much better - // than the second best move. - const Value EasyMoveMargin = Value(0x150); - - // This is the minimum interval in msec between two check_time() calls - const int TimerResolution = 5; - - size_t MultiPV, UCIMultiPV, PVIdx; TimeManager TimeMgr; int BestMoveChanges; @@ -103,7 +93,6 @@ namespace { bool SkillLevelEnabled, Chess960; History H; - template Value search(Position& pos, Stack* ss, Value alpha, Value beta, Depth depth); @@ -450,7 +439,7 @@ namespace { && ( (bestMoveNeverChanged && pos.captured_piece_type()) || Time::now() - SearchTime > (TimeMgr.available_time() * 40) / 100)) { - Value rBeta = bestValue - EasyMoveMargin; + Value rBeta = bestValue - 2 * PawnValueMg; (ss+1)->excludedMove = RootMoves[0].pv[0]; (ss+1)->skipNullMove = true; Value v = search(pos, ss+1, rBeta - 1, rBeta, (depth - 3) * ONE_PLY); @@ -509,7 +498,7 @@ namespace { Key posKey; Move ttMove, move, excludedMove, bestMove, threatMove; Depth ext, newDepth; - Value bestValue, value, oldAlpha, ttValue; + Value bestValue, value, ttValue; Value refinedValue, nullValue, futilityValue; bool pvMove, inCheck, singularExtensionNode, givesCheck; bool captureOrPromotion, dangerous, doFullDepthSearch; @@ -518,7 +507,6 @@ namespace { // Step 1. Initialize node Thread* thisThread = pos.this_thread(); moveCount = playedMoveCount = 0; - oldAlpha = alpha; inCheck = pos.in_check(); if (SpNode) @@ -550,7 +538,7 @@ namespace { { // Step 2. Check for aborted search and immediate draw if (Signals.stop || pos.is_draw() || ss->ply > MAX_PLY) - return VALUE_DRAW; + return Eval::ValueDrawContempt; // Step 3. Mate distance pruning. Even if we mate at the next move our score // would be at best mate_in(ss->ply+1), but if alpha is already bigger because @@ -647,10 +635,10 @@ namespace { && !ss->skipNullMove && depth < 4 * ONE_PLY && !inCheck - && refinedValue - futility_margin(depth, 0) >= beta + && refinedValue - FutilityMargins[depth][0] >= beta && abs(beta) < VALUE_MATE_IN_MAX_PLY && pos.non_pawn_material(pos.side_to_move())) - return refinedValue - futility_margin(depth, 0); + return refinedValue - FutilityMargins[depth][0]; // Step 8. Null move search with verification search (is omitted in PV nodes) if ( !PvNode @@ -775,10 +763,7 @@ split_point_start: // At split points actual search starts from here // Step 11. Loop through moves // Loop through all pseudo-legal moves until no moves remain or a beta cutoff occurs - while ( bestValue < beta - && (move = mp.next_move()) != MOVE_NONE - && !thisThread->cutoff_occurred() - && !Signals.stop) + while ((move = mp.next_move()) != MOVE_NONE) { assert(is_ok(move)); @@ -859,7 +844,8 @@ split_point_start: // At split points actual search starts from here && (bestValue > VALUE_MATED_IN_MAX_PLY || bestValue == -VALUE_INFINITE)) { // Move count based pruning - if ( moveCount >= futility_move_count(depth) + if ( depth < 16 * ONE_PLY + && moveCount >= FutilityMoveCounts[depth] && (!threatMove || !connected_threat(pos, move, threatMove))) { if (SpNode) @@ -962,7 +948,10 @@ split_point_start: // At split points actual search starts from here // was aborted because the user interrupted the search or because we // ran out of time. In this case, the return value of the search cannot // be trusted, and we don't update the best move and/or PV. - if (RootNode && !Signals.stop) + if (Signals.stop || thisThread->cutoff_occurred()) + return bestValue; + + if (RootNode) { RootMove& rm = *std::find(RootMoves.begin(), RootMoves.end(), move); @@ -988,37 +977,41 @@ split_point_start: // At split points actual search starts from here if (value > bestValue) { bestValue = value; - bestMove = move; + if (SpNode) sp->bestValue = value; - if ( PvNode - && value > alpha - && value < beta) // We want always alpha < beta - { - alpha = bestValue; // Update alpha here! - } - - if (SpNode && !thisThread->cutoff_occurred()) + if (value > alpha) { - sp->bestValue = bestValue; - sp->bestMove = bestMove; - sp->alpha = alpha; + bestMove = move; + if (SpNode) sp->bestMove = move; - if (bestValue >= beta) - sp->cutoff = true; + if (PvNode && value < beta) + { + alpha = value; // Update alpha here! Always alpha < beta + if (SpNode) sp->alpha = alpha; + } + else // Fail high + { + if (SpNode) sp->cutoff = true; + break; + } } } - // Step 19. Check for split + // Step 19. Check for splitting the search if ( !SpNode && depth >= Threads.min_split_depth() && bestValue < beta - && Threads.available_slave_exists(thisThread) - && !Signals.stop - && !thisThread->cutoff_occurred()) + && Threads.available_slave_exists(thisThread)) + { bestValue = Threads.split(pos, ss, alpha, beta, bestValue, &bestMove, depth, threatMove, moveCount, mp, NT); + break; + } } + if (SpNode) + return bestValue; + // Step 20. Check for mate and stalemate // All legal moves have been searched and if there are no legal moves, it // must be mate or stalemate. Note that we can have a false positive in @@ -1026,7 +1019,7 @@ split_point_start: // At split points actual search starts from here // harmless because return value is discarded anyhow in the parent nodes. // If we are in a singular extension search then return a fail low score. // A split node has at least one move, the one tried before to be splitted. - if (!SpNode && !moveCount) + if (!moveCount) return excludedMove ? alpha : inCheck ? mated_in(ss->ply) : VALUE_DRAW; // If we have pruned all the moves without searching return a fail-low score @@ -1037,20 +1030,12 @@ split_point_start: // At split points actual search starts from here bestValue = alpha; } - // Step 21. Update tables - // Update transposition table entry, killers and history - if (!SpNode && !Signals.stop && !thisThread->cutoff_occurred()) + if (bestValue >= beta) // Failed high { - Move ttm = bestValue <= oldAlpha ? MOVE_NONE : bestMove; - Bound bt = bestValue <= oldAlpha ? BOUND_UPPER - : bestValue >= beta ? BOUND_LOWER : BOUND_EXACT; - - TT.store(posKey, value_to_tt(bestValue, ss->ply), bt, depth, ttm, ss->eval, ss->evalMargin); + TT.store(posKey, value_to_tt(bestValue, ss->ply), BOUND_LOWER, depth, + bestMove, ss->eval, ss->evalMargin); - // Update killers and history for non capture cut-off moves - if ( bestValue >= beta - && !pos.is_capture_or_promotion(bestMove) - && !inCheck) + if (!pos.is_capture_or_promotion(bestMove) && !inCheck) { if (bestMove != ss->killers[0]) { @@ -1070,6 +1055,10 @@ split_point_start: // At split points actual search starts from here } } } + else // Failed low or PV search + TT.store(posKey, value_to_tt(bestValue, ss->ply), + PvNode && bestMove != MOVE_NONE ? BOUND_EXACT : BOUND_UPPER, + depth, bestMove, ss->eval, ss->evalMargin); assert(bestValue > -VALUE_INFINITE && bestValue < VALUE_INFINITE); @@ -1105,7 +1094,7 @@ split_point_start: // At split points actual search starts from here // Check for an instant draw or maximum ply reached if (pos.is_draw() || ss->ply > MAX_PLY) - return VALUE_DRAW; + return Eval::ValueDrawContempt; // Decide whether or not to include checks, this fixes also the type of // TT entry depth that we are going to use. Note that in qsearch we use @@ -1494,7 +1483,7 @@ split_point_start: // At split points actual search starts from here int s = RootMoves[i].score; // Don't allow crazy blunders even at very low skills - if (i > 0 && RootMoves[i-1].score > s + EasyMoveMargin) + if (i > 0 && RootMoves[i-1].score > s + 2 * PawnValueMg) break; // This is our magic formula