From: Damien Fouilleul <damienf@videolan.org>
Date: Thu, 21 Feb 2008 14:37:55 +0000 (+0000)
Subject: libvlc: revert [22749], useless, breaks plugins
X-Git-Tag: 0.9.0-test0~2580
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=2bd9ccb55bfe252628f56c54cff864db82f889ba;p=vlc

libvlc: revert [22749], useless, breaks plugins
---

diff --git a/src/control/core.c b/src/control/core.c
index 08f550b612..c967c39c9e 100644
--- a/src/control/core.c
+++ b/src/control/core.c
@@ -110,17 +110,12 @@ libvlc_instance_t * libvlc_new( int argc, const char *const *argv,
     p_new = (libvlc_instance_t *)malloc( sizeof( libvlc_instance_t ) );
     if( !p_new ) RAISENULL( "Out of memory" );
 
-    const char *my_argv[argc + 2];
-
-    my_argv[0] = "libvlc"; /* dummy arg0, skipped by getopt() et al */
-    for( int i = 0; i < argc; i++ )
-         my_argv[i + 1] = argv[i];
-    my_argv[argc + 1] = NULL; /* C calling conventions require a NULL */
-
     /** \todo Look for interface settings. If we don't have any, add -I dummy */
     /* Because we probably don't want a GUI by default */
 
-    if( libvlc_InternalInit( p_libvlc_int, argc + 1, my_argv ) )
+    /* WARNING: caller must pass a program path in argv[0], which can be a dummy path
+     *          this is used by libvlc to locate, this is leveraged by plugins */
+    if( libvlc_InternalInit( p_libvlc_int, argc, argv ) )
         RAISENULL( "VLC initialization failed" );
 
     p_new->p_libvlc_int = p_libvlc_int;