From: Rémi Duraffort <ivoire@videolan.org>
Date: Mon, 12 May 2008 12:48:45 +0000 (+0200)
Subject: Avoid a potential segfault as vlc_object_create can fail.
X-Git-Tag: 0.9.0-test0~976
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=2cc99c5cbbd3de7f5ad677539af1b5c29dc8defe;p=vlc

Avoid a potential segfault as vlc_object_create can fail.
---

diff --git a/src/playlist/thread.c b/src/playlist/thread.c
index 8603fb212f..5208ca81c9 100644
--- a/src/playlist/thread.c
+++ b/src/playlist/thread.c
@@ -61,13 +61,13 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent )
     // Preparse
     p_playlist->p_preparse = vlc_object_create( p_playlist,
                                   sizeof( playlist_preparse_t ) );
-    p_playlist->p_preparse->psz_object_name = strdup( "preparser" );
     if( !p_playlist->p_preparse )
     {
         msg_Err( p_playlist, "unable to create preparser" );
         vlc_object_release( p_playlist );
         return;
     }
+    p_playlist->p_preparse->psz_object_name = strdup( "preparser" );
     p_playlist->p_preparse->i_waiting = 0;
     p_playlist->p_preparse->pp_waiting = NULL;
 
@@ -85,13 +85,13 @@ void __playlist_ThreadCreate( vlc_object_t *p_parent )
     // Secondary Preparse
     p_playlist->p_fetcher = vlc_object_create( p_playlist,
                               sizeof( playlist_fetcher_t ) );
-    p_playlist->p_fetcher->psz_object_name = strdup( "fetcher" );
     if( !p_playlist->p_fetcher )
     {
         msg_Err( p_playlist, "unable to create secondary preparser" );
         vlc_object_release( p_playlist );
         return;
     }
+    p_playlist->p_fetcher->psz_object_name = strdup( "fetcher" );
     p_playlist->p_fetcher->i_waiting = 0;
     p_playlist->p_fetcher->pp_waiting = NULL;
     p_playlist->p_fetcher->i_art_policy = var_CreateGetInteger( p_playlist,