From: Jean-Baptiste Mardelle <jb@kdenlive.org>
Date: Thu, 16 Sep 2010 15:11:03 +0000 (+0000)
Subject: Fix crash when editing effect on first track:
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=68264d0d1fe17ffb45b5e0cab8d24ca4d4e70bd0;p=kdenlive

Fix crash when editing effect on first track:
http://kdenlive.org/mantis/view.php?id=1815

svn path=/trunk/kdenlive/; revision=4900
---

diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp
index 3176d9ad..eaa996ef 100644
--- a/src/customtrackview.cpp
+++ b/src/customtrackview.cpp
@@ -1793,7 +1793,7 @@ void CustomTrackView::updateEffect(int track, GenTime pos, QDomElement insertedE
         return;
     }
     QDomElement effect = insertedEffect.cloneNode().toElement();
-    kDebug() << "// update effect ix: " << effect.attribute("kdenlive_ix");
+    //kDebug() << "// update effect ix: " << effect.attribute("kdenlive_ix")<<", TRACK: "<<track;
     if (pos < GenTime()) {
         // editing a track effect
         EffectsParameterList effectParams = getEffectArgs(effect);
@@ -1809,7 +1809,7 @@ void CustomTrackView::updateEffect(int track, GenTime pos, QDomElement insertedE
         if (!m_document->renderer()->mltEditEffect(m_document->tracksCount() - track, pos, effectParams))
             emit displayMessage(i18n("Problem editing effect"), ErrorMessage);
         m_document->setTrackEffect(m_document->tracksCount() - track - 1, ix, effect);
-        emit updateTrackEffectState(track - 1);
+        emit updateTrackEffectState(track);
         setDocumentModified();
         return;
 
diff --git a/src/trackview.cpp b/src/trackview.cpp
index 5333eb0e..c75cd06a 100644
--- a/src/trackview.cpp
+++ b/src/trackview.cpp
@@ -992,7 +992,7 @@ void TrackView::slotShowTrackEffects(int ix)
 void TrackView::slotUpdateTrackEffectState(int ix)
 {
     QList<HeaderTrack *> widgets = findChildren<HeaderTrack *>();
-    if (ix >= widgets.count()) {
+    if (ix < 0 || ix >= widgets.count()) {
         kDebug() << "ERROR, Trying to access a non existant track: " << ix;
         return;
     }