From: Marco Costalba <mcostalba@gmail.com>
Date: Sun, 17 Apr 2016 19:31:19 +0000 (+0200)
Subject: Fix incorrect draw detection
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=94e41274bba2d8a2f2d58aaa711df5872309d66c;hp=94e41274bba2d8a2f2d58aaa711df5872309d66c;p=stockfish

Fix incorrect draw detection

In this position we should have draw for repetition:

position fen rnbqkbnr/2pppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1 moves g1f3 g8f6 f3g1
go infinite

But latest patch broke it.

Actually we had two(!) very subtle bugs, the first is that Position::set()
clears the passed state and in particular 'previous' member, so
that on passing setupStates, 'previous' pointer was reset.

Second bug is even more subtle: SetupStates was based on std::vector
as container, but when vector grows, std::vector copies all its contents
to a new location invalidating all references to its entries. Because
all StateInfo records are linked by 'previous' pointer, this made pointers
go stale upon adding more element to setupStates. So revert to use a
std::deque that ensures references are preserved when pushing back new
elements.

No functional change.
---