From: Rémi Duraffort <ivoire@videolan.org>
Date: Mon, 21 Jul 2008 07:13:45 +0000 (+0200)
Subject: Use pl_Locked and pl_Unlocked.
X-Git-Tag: 0.9.0-test3~355
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=a518149f3478fc8bc984b114a1821d0fd83cecab;p=vlc

Use pl_Locked and pl_Unlocked.
---

diff --git a/modules/codec/cmml/intf.c b/modules/codec/cmml/intf.c
index b57cd668a6..5f58b303d3 100644
--- a/modules/codec/cmml/intf.c
+++ b/modules/codec/cmml/intf.c
@@ -510,7 +510,7 @@ static void FollowAnchor ( intf_thread_t *p_intf )
             msg_Dbg( p_intf, "calling browser_Open with \"%s\"", psz_url );
 #endif
             (void) browser_Open( psz_url );
-            playlist_Control( p_playlist, PLAYLIST_PAUSE, false, 0 );
+            playlist_Control( p_playlist, PLAYLIST_PAUSE, pl_Unlocked, 0 );
         }
 
         free( psz_uri_to_load );
diff --git a/modules/control/dbus.c b/modules/control/dbus.c
index fd725a5f0e..bd998d5d11 100644
--- a/modules/control/dbus.c
+++ b/modules/control/dbus.c
@@ -507,7 +507,7 @@ DBUS_METHOD( DelTrack )
     {
         playlist_DeleteFromInput( p_playlist,
             p_playlist->current.p_elems[i_position]->p_input->i_id,
-            true );
+            pl_Locked );
     }
     PL_UNLOCK;
 
diff --git a/modules/control/rc.c b/modules/control/rc.c
index bb1daae18d..8b3b8d6583 100644
--- a/modules/control/rc.c
+++ b/modules/control/rc.c
@@ -1430,7 +1430,7 @@ static int Playlist( vlc_object_t *p_this, char const *psz_cmd,
     else if( !strcmp( psz_cmd, "clear" ) )
     {
         playlist_Stop( p_playlist );
-        playlist_Clear( p_playlist, false );
+        playlist_Clear( p_playlist, pl_Unlocked );
     }
     else if( !strcmp( psz_cmd, "add" ) &&
              newval.psz_string && *newval.psz_string )
@@ -1442,7 +1442,7 @@ static int Playlist( vlc_object_t *p_this, char const *psz_cmd,
             msg_rc( "Trying to add %s to playlist.", newval.psz_string );
             int i_ret =playlist_AddInput( p_playlist, p_item,
                      PLAYLIST_GO|PLAYLIST_APPEND, PLAYLIST_END, true,
-                     false );
+                     pl_Unlocked );
             vlc_gc_decref( p_item );
             if( i_ret != VLC_SUCCESS )
             {
@@ -1460,7 +1460,7 @@ static int Playlist( vlc_object_t *p_this, char const *psz_cmd,
             msg_rc( "trying to enqueue %s to playlist", newval.psz_string );
             if( playlist_AddInput( p_playlist, p_item,
                                PLAYLIST_APPEND, PLAYLIST_END, true,
-                               false ) != VLC_SUCCESS )
+                               pl_Unlocked ) != VLC_SUCCESS )
             {
                 return VLC_EGENERIC;
             }
diff --git a/modules/gui/macosx/applescript.m b/modules/gui/macosx/applescript.m
index f860af6e32..cfba3bb341 100644
--- a/modules/gui/macosx/applescript.m
+++ b/modules/gui/macosx/applescript.m
@@ -58,7 +58,7 @@
                                     displayNameAtPath: o_urlString] UTF8String] );
             /* FIXME: playlist_AddInput() can fail */
             playlist_AddInput( p_playlist, p_input, PLAYLIST_INSERT,
-                               PLAYLIST_END, true, false );
+                               PLAYLIST_END, true, pl_Unlocked );
 
             vlc_gc_decref( p_input );
 
diff --git a/modules/gui/macosx/wizard.m b/modules/gui/macosx/wizard.m
index abf197aac6..ee7a94ea84 100644
--- a/modules/gui/macosx/wizard.m
+++ b/modules/gui/macosx/wizard.m
@@ -1294,7 +1294,7 @@ static VLCWizard *_o_sharedInstance = nil;
 
             /* FIXME: playlist_AddInput() can fail */
             playlist_AddInput( p_playlist, p_input, PLAYLIST_STOP,
-                PLAYLIST_END, true, false );
+                PLAYLIST_END, true, pl_Unlocked );
 
             if( x == 0 )
             {
diff --git a/modules/gui/ncurses.c b/modules/gui/ncurses.c
index 45a580a7b1..1d4bfe96dc 100644
--- a/modules/gui/ncurses.c
+++ b/modules/gui/ncurses.c
@@ -679,7 +679,7 @@ static int HandleKey( intf_thread_t *p_intf, int i_key )
                 if( p_item->i_children == -1 )
                 {
                     playlist_DeleteFromInput( p_playlist,
-                                              p_item->p_input->i_id, true );
+                                              p_item->p_input->i_id, pl_Locked );
                 }
                 else
                 {
diff --git a/modules/gui/qt4/components/playlist/playlist_model.cpp b/modules/gui/qt4/components/playlist/playlist_model.cpp
index 710156accb..60ffb4f4c7 100644
--- a/modules/gui/qt4/components/playlist/playlist_model.cpp
+++ b/modules/gui/qt4/components/playlist/playlist_model.cpp
@@ -705,7 +705,7 @@ void PLModel::doDeleteItem( PLItem *item, QModelIndexList *fullList )
         PL_UNLOCK; return;
     }
     if( p_item->i_children == -1 )
-        playlist_DeleteFromInput( p_playlist, item->i_input_id, true );
+        playlist_DeleteFromInput( p_playlist, item->i_input_id, pl_Locked );
     else
         playlist_NodeDelete( p_playlist, p_item, true, false );
     /* And finally, remove it from the tree */
diff --git a/modules/gui/qt4/dialogs/open.cpp b/modules/gui/qt4/dialogs/open.cpp
index 7ce95ebb79..ea2c5e18b3 100644
--- a/modules/gui/qt4/dialogs/open.cpp
+++ b/modules/gui/qt4/dialogs/open.cpp
@@ -313,7 +313,7 @@ void OpenDialog::finish( bool b_enqueue = false )
             /* FIXME: playlist_AddInput() can fail */
             playlist_AddInput( THEPL, p_input,
                 PLAYLIST_APPEND | ( b_start ? PLAYLIST_GO : PLAYLIST_PREPARSE ),
-                PLAYLIST_END, true, false );
+                PLAYLIST_END, true, pl_Unlocked );
             vlc_gc_decref( p_input );
         }
     }
diff --git a/modules/gui/qt4/dialogs_provider.cpp b/modules/gui/qt4/dialogs_provider.cpp
index 67002ded71..dd4f69d0c4 100644
--- a/modules/gui/qt4/dialogs_provider.cpp
+++ b/modules/gui/qt4/dialogs_provider.cpp
@@ -355,7 +355,7 @@ static void openDirectory( intf_thread_t *p_intf, bool pl, bool go )
         /* FIXME: playlist_AddInput() can fail */
         playlist_AddInput( THEPL, p_input,
                        go ? ( PLAYLIST_APPEND | PLAYLIST_GO ) : PLAYLIST_APPEND,
-                       PLAYLIST_END, pl, false );
+                       PLAYLIST_END, pl, pl_Unlocked );
         input_Read( THEPL, p_input, false );
         vlc_gc_decref( p_input );
     }
diff --git a/modules/gui/skins2/vars/playtree.cpp b/modules/gui/skins2/vars/playtree.cpp
index ad808d4214..037d07813b 100644
--- a/modules/gui/skins2/vars/playtree.cpp
+++ b/modules/gui/skins2/vars/playtree.cpp
@@ -74,7 +74,7 @@ void Playtree::delSelected()
             if( p_item->i_children == -1 )
             {
                 playlist_DeleteFromInput( getIntf()->p_sys->p_playlist,
-                                          p_item->p_input->i_id, true );
+                                          p_item->p_input->i_id, pl_Locked );
                 it2 = getNextVisibleItem( it ) ;
                 it->parent()->removeChild( it );
                 it = it2;
diff --git a/modules/gui/wxwidgets/dialogs/open.cpp b/modules/gui/wxwidgets/dialogs/open.cpp
index 562f81f62b..9d1981178c 100644
--- a/modules/gui/wxwidgets/dialogs/open.cpp
+++ b/modules/gui/wxwidgets/dialogs/open.cpp
@@ -1206,7 +1206,7 @@ void OpenDialog::OnOk( wxCommandEvent& WXUNUSED(event) )
         /* FIXME: playlist_AddInput() can fail */
         playlist_AddInput( p_playlist, p_input,
                PLAYLIST_APPEND | ( b_start ? PLAYLIST_GO : PLAYLIST_PREPARSE ),
-               PLAYLIST_END, true, false );
+               PLAYLIST_END, true, pl_Unlocked );
         vlc_gc_decref( p_input );
     }
     pl_Release( p_playlist );
diff --git a/modules/gui/wxwidgets/dialogs/wizard.cpp b/modules/gui/wxwidgets/dialogs/wizard.cpp
index 95921b7cb3..07f559dd5a 100644
--- a/modules/gui/wxwidgets/dialogs/wizard.cpp
+++ b/modules/gui/wxwidgets/dialogs/wizard.cpp
@@ -1631,7 +1631,7 @@ void WizardDialog::Run()
 
             /* FIXME: playlist_AddInput() can fail */
             playlist_AddInput( p_playlist, p_input,
-                               PLAYLIST_GO, PLAYLIST_END, true, false );
+                               PLAYLIST_GO, PLAYLIST_END, true, pl_Unlocked );
             vlc_gc_decref( p_input );
             pl_Release( p_playlist );
         }
diff --git a/modules/misc/lua/libs/playlist.c b/modules/misc/lua/libs/playlist.c
index 4d9b30791b..0eac614724 100644
--- a/modules/misc/lua/libs/playlist.c
+++ b/modules/misc/lua/libs/playlist.c
@@ -107,7 +107,7 @@ static int vlclua_playlist_clear( lua_State * L )
 {
     playlist_t *p_playlist = vlclua_get_playlist_internal( L );
     playlist_Stop( p_playlist ); /* Isn't this already implied by Clear? */
-    playlist_Clear( p_playlist, false );
+    playlist_Clear( p_playlist, pl_Unlocked );
     vlc_object_release( p_playlist );
     return 0;
 }
diff --git a/modules/services_discovery/sap.c b/modules/services_discovery/sap.c
index 9b89a6e3a5..ff84a13a4a 100644
--- a/modules/services_discovery/sap.c
+++ b/modules/services_discovery/sap.c
@@ -684,7 +684,7 @@ static int Demux( demux_t *p_demux )
     if( p_playlist->status.p_item &&
              p_playlist->status.p_item->p_input == p_parent_input )
     {
-        playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, true,
+        playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, pl_Locked,
                           p_playlist->status.p_node, p_playlist->status.p_item );
     }
 
@@ -1540,7 +1540,7 @@ static int RemoveAnnounce( services_discovery_t *p_sd,
     if( p_announce->i_input_id > -1 )
     {
         playlist_DeleteFromInput( pl_Yield( p_sd ),
-                                  p_announce->i_input_id, false );
+                                  p_announce->i_input_id, pl_Unlocked );
         pl_Release( p_sd );
     }
 
diff --git a/src/playlist/loadsave.c b/src/playlist/loadsave.c
index 64b44b8333..10660f80ca 100644
--- a/src/playlist/loadsave.c
+++ b/src/playlist/loadsave.c
@@ -100,7 +100,7 @@ static void input_item_subitem_added( const vlc_event_t * p_event,
     /* playlist_AddInput() can fail, but we have no way to report that ..
      * Any way when it has failed, either the playlist is dying, either OOM */
     playlist_AddInput( p_playlist, p_item, PLAYLIST_APPEND, PLAYLIST_END,
-            false, false );
+            false, pl_Unlocked );
 }
 
 int playlist_MLLoad( playlist_t *p_playlist )
diff --git a/src/playlist/services_discovery.c b/src/playlist/services_discovery.c
index d6f1ddcbcd..17bf55102b 100644
--- a/src/playlist/services_discovery.c
+++ b/src/playlist/services_discovery.c
@@ -269,7 +269,7 @@ static void playlist_sd_item_removed( const vlc_event_t * p_event, void * user_d
 
     /* Delete the non-node item normally */
     playlist_DeleteFromInputInParent( p_parent->p_playlist, p_input->i_id,
-                                      p_parent, true );
+                                      p_parent, pl_Locked );
 
     vlc_object_unlock( p_parent->p_playlist );
 }