From: Rémi Duraffort <ivoire@videolan.org>
Date: Fri, 8 Jan 2010 10:57:14 +0000 (+0100)
Subject: video_filter_ball: missing var_DelCallback + cosmetics.
X-Git-Tag: 1.1.0-ff~1366
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=ac0d798c4ee9e2407012a8ce57688a16455443e2;p=vlc

video_filter_ball: missing var_DelCallback + cosmetics.
---

diff --git a/modules/video_filter/ball.c b/modules/video_filter/ball.c
index ca1c0fad57..383b1380b0 100644
--- a/modules/video_filter/ball.c
+++ b/modules/video_filter/ball.c
@@ -152,7 +152,7 @@ vlc_module_begin ()
     add_integer_with_range( FILTER_PREFIX "gradient-threshold", 40, 1, 200, NULL,
                             GRAD_THRESH_TEXT, GRAD_THRESH_LONGTEXT, false )
 
-    add_bool( FILTER_PREFIX "edge-visible", 1, NULL,
+    add_bool( FILTER_PREFIX "edge-visible", true, NULL,
               EDGE_VISIBLE_TEXT, EDGE_VISIBLE_LONGTEXT, true )
 
     add_shortcut( "ball" )
@@ -325,6 +325,15 @@ static void Destroy( vlc_object_t *p_this )
     filter_t *p_filter = (filter_t *)p_this;
     filter_sys_t *p_sys = p_filter->p_sys;
 
+    var_DelCallback( p_filter, FILTER_PREFIX "ball-color",
+                     ballCallback, p_sys );
+    var_DelCallback( p_filter, FILTER_PREFIX "ball-size",
+                     ballCallback, p_sys );
+    var_DelCallback( p_filter, FILTER_PREFIX "ball-speed",
+                     ballCallback, p_sys );
+    var_DelCallback( p_filter, FILTER_PREFIX "edge-visible",
+                     ballCallback, p_sys );
+
     vlc_mutex_destroy( &p_sys->lock );
 
     image_HandlerDelete( p_sys->p_image );
@@ -838,7 +847,7 @@ static int ballCallback( vlc_object_t *p_this, char const *psz_var,
 
 
 /*****************************************************************************
- * ballCallback
+ * getBallColor
  *****************************************************************************
  * Get and assign the ball color value
  *****************************************************************************/