From ff57a79c5515bf467bdd6abf0e011549a96d98e2 Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Sun, 12 May 2013 09:32:38 +0200 Subject: [PATCH] use const ref remove not necessary ";" if(foo) delete foo; -> delete foo; --- src/clipmanager.h | 2 +- src/colorpickerwidget.h | 2 +- src/cornerswidget.cpp | 2 +- src/cornerswidget.h | 2 +- src/customtrackscene.cpp | 2 +- src/customtrackscene.h | 2 +- src/definitions.h | 14 +++++++------- src/docclipbase.h | 5 +++-- src/documentchecker.cpp | 2 +- src/documentchecker.h | 2 +- src/documentvalidator.cpp | 4 ++-- src/documentvalidator.h | 4 ++-- src/dragvalue.cpp | 4 ++-- src/dvdwizardvob.h | 2 +- src/effectstackedit.cpp | 2 +- src/effectstackedit.h | 4 ++-- src/geometryval.cpp | 2 +- src/geometryval.h | 2 +- src/guide.cpp | 2 +- src/guide.h | 2 +- src/headertrack.cpp | 2 +- src/headertrack.h | 2 +- src/jogshuttle.cpp | 2 +- src/jogshuttle.h | 2 +- src/kdenlivedoc.cpp | 2 +- src/kdenlivedoc.h | 2 +- src/kdenlivesettingsdialog.cpp | 2 +- src/keyframeedit.cpp | 2 +- src/keyframeedit.h | 2 +- src/managecapturesdialog.cpp | 2 +- src/managecapturesdialog.h | 2 +- src/markerdialog.h | 2 +- src/mltdevicecapture.h | 4 ++-- src/noteswidget.h | 2 +- src/positionedit.cpp | 2 +- src/positionedit.h | 2 +- 36 files changed, 49 insertions(+), 48 deletions(-) diff --git a/src/clipmanager.h b/src/clipmanager.h index 9f093bf9..5165bbd4 100644 --- a/src/clipmanager.h +++ b/src/clipmanager.h @@ -71,7 +71,7 @@ public: namespace Mlt { class Producer; -}; +} class ClipManager: public QObject { diff --git a/src/colorpickerwidget.h b/src/colorpickerwidget.h index 71e38af4..2401a279 100644 --- a/src/colorpickerwidget.h +++ b/src/colorpickerwidget.h @@ -58,7 +58,7 @@ class ColorPickerWidget : public QWidget public: /** @brief Sets up the widget. */ - ColorPickerWidget(QWidget *parent = 0); + explicit ColorPickerWidget(QWidget *parent = 0); /** @brief Makes sure the event filter is removed. */ virtual ~ColorPickerWidget(); diff --git a/src/cornerswidget.cpp b/src/cornerswidget.cpp index 95654bdb..d31c091d 100644 --- a/src/cornerswidget.cpp +++ b/src/cornerswidget.cpp @@ -36,7 +36,7 @@ inline int lerp( const int a, const int b, double t ) return a + (b - a) * t; } -CornersWidget::CornersWidget(Monitor *monitor, QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) : +CornersWidget::CornersWidget(Monitor *monitor, const QDomElement& e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) : KeyframeEdit(e, minFrame, maxFrame, tc, activeKeyframe, parent), m_monitor(monitor), m_showScene(true), diff --git a/src/cornerswidget.h b/src/cornerswidget.h index d5d5fe86..1cad4610 100644 --- a/src/cornerswidget.h +++ b/src/cornerswidget.h @@ -40,7 +40,7 @@ public: * @param isEffect true if used in an effect, false if used in a transition * @param factor Factor by which the parameters differ from the range 0-1 * @param parent (optional) Parent widget */ - CornersWidget(Monitor *monitor, QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0); + explicit CornersWidget(Monitor *monitor, const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0); virtual ~CornersWidget(); virtual void addParameter(QDomElement e, int activeKeyframe = -1); diff --git a/src/customtrackscene.cpp b/src/customtrackscene.cpp index 1f8b40ae..ba243695 100644 --- a/src/customtrackscene.cpp +++ b/src/customtrackscene.cpp @@ -50,7 +50,7 @@ double CustomTrackScene::getSnapPointForPos(double pos, bool doSnap) return GenTime(pos, m_document->fps()).frames(m_document->fps()); } -void CustomTrackScene::setSnapList(QList snaps) +void CustomTrackScene::setSnapList(const QList & snaps) { m_snapPoints = snaps; } diff --git a/src/customtrackscene.h b/src/customtrackscene.h index ac402618..ade17bc5 100644 --- a/src/customtrackscene.h +++ b/src/customtrackscene.h @@ -44,7 +44,7 @@ class CustomTrackScene : public QGraphicsScene public: explicit CustomTrackScene(KdenliveDoc *doc, QObject *parent = 0); virtual ~ CustomTrackScene(); - void setSnapList(QList snaps); + void setSnapList(const QList & snaps); GenTime previousSnapPoint(GenTime pos) const; GenTime nextSnapPoint(GenTime pos) const; double getSnapPointForPos(double pos, bool doSnap = true); diff --git a/src/definitions.h b/src/definitions.h index 738e133d..dd22fbb4 100644 --- a/src/definitions.h +++ b/src/definitions.h @@ -86,7 +86,7 @@ public: isMute(0), isBlind(0), isLocked(0), - duration(0) {}; + duration(0) {} }; typedef QMap stringMap; @@ -103,7 +103,7 @@ public: /** cropDuration is the duration of the clip */ GenTime cropDuration; int track; - ItemInfo() : track(0) {}; + ItemInfo() : track(0) {} }; class TransitionInfo { @@ -121,7 +121,7 @@ public: TransitionInfo() : b_track(0), a_track(0), - forceTrack(0) {}; + forceTrack(0) {} }; class MltVideoProfile { @@ -148,7 +148,7 @@ public: sample_aspect_den(0), display_aspect_num(0), display_aspect_den(0), - colorspace(0) {}; + colorspace(0) {} bool operator==(const MltVideoProfile& point) const { if (!description.isEmpty() && point.description == description) return true; @@ -233,7 +233,7 @@ public: } void setParamValue(const QString &name, const QString &value) { bool found = false; - for (int i = 0; i < size(); i++) + for (int i = 0; i < size(); ++i) if (at(i).name() == name) { // update value replace(i, EffectParameter(name, value)); @@ -243,7 +243,7 @@ public: } QString paramValue(const QString &name, QString defaultValue = QString()) const { - for (int i = 0; i < size(); i++) { + for (int i = 0; i < size(); ++i) { if (at(i).name() == name) return at(i).value(); } return defaultValue; @@ -253,7 +253,7 @@ public: append(EffectParameter(name, value)); } void removeParam(const QString &name) { - for (int i = 0; i < size(); i++) + for (int i = 0; i < size(); ++i) if (at(i).name() == name) { removeAt(i); break; diff --git a/src/docclipbase.h b/src/docclipbase.h index 4b85c0a1..0e22c4da 100644 --- a/src/docclipbase.h +++ b/src/docclipbase.h @@ -43,7 +43,7 @@ class ClipManager; namespace Mlt { class Producer; -}; +} struct CutZoneInfo { QPoint zone; @@ -53,7 +53,8 @@ struct CutZoneInfo { class DocClipBase: public QObject { -Q_OBJECT public: +Q_OBJECT +public: /** this enum determines the types of "feed" available within this clip. types must be non-exclusive * - e.g. if you can have audio and video separately, it should be possible to combin the two, as is * done here. If a new clip type is added then it should be possible to combine it with both audio diff --git a/src/documentchecker.cpp b/src/documentchecker.cpp index 68fee92b..96f63c8d 100644 --- a/src/documentchecker.cpp +++ b/src/documentchecker.cpp @@ -64,7 +64,7 @@ const int LUMAPLACEHOLDER = 12; enum TITLECLIPTYPE { TITLE_IMAGE_ELEMENT = 20, TITLE_FONT_ELEMENT = 21 }; -DocumentChecker::DocumentChecker(QDomNodeList infoproducers, QDomDocument doc): +DocumentChecker::DocumentChecker(const QDomNodeList &infoproducers, const QDomDocument &doc): m_info(infoproducers), m_doc(doc), m_dialog(NULL) { diff --git a/src/documentchecker.h b/src/documentchecker.h index 58a23db0..03c91ec1 100644 --- a/src/documentchecker.h +++ b/src/documentchecker.h @@ -34,7 +34,7 @@ class DocumentChecker: public QObject Q_OBJECT public: - explicit DocumentChecker(QDomNodeList infoproducers, QDomDocument doc); + explicit DocumentChecker(const QDomNodeList &infoproducers, const QDomDocument &doc); ~DocumentChecker(); bool hasErrorInClips(); diff --git a/src/documentvalidator.cpp b/src/documentvalidator.cpp index dea1e967..ec04f385 100644 --- a/src/documentvalidator.cpp +++ b/src/documentvalidator.cpp @@ -40,7 +40,7 @@ #include -DocumentValidator::DocumentValidator(QDomDocument doc, KUrl documentUrl): +DocumentValidator::DocumentValidator(const QDomDocument &doc, const KUrl &documentUrl): m_doc(doc), m_url(documentUrl), m_modified(false) @@ -1174,7 +1174,7 @@ void DocumentValidator::updateEffects() } } -bool DocumentValidator::updateEffectParameters(QDomNodeList parameters, const QScriptValue* updateRules, const double serviceVersion, const double effectVersion) +bool DocumentValidator::updateEffectParameters(const QDomNodeList ¶meters, const QScriptValue* updateRules, const double serviceVersion, const double effectVersion) { bool updated = false; bool isDowngrade = serviceVersion < effectVersion; diff --git a/src/documentvalidator.h b/src/documentvalidator.h index 70766ed5..aaa3b3a9 100644 --- a/src/documentvalidator.h +++ b/src/documentvalidator.h @@ -32,7 +32,7 @@ class DocumentValidator { public: - DocumentValidator(QDomDocument doc, KUrl documentUrl); + DocumentValidator(const QDomDocument &doc, const KUrl &documentUrl); bool isProject() const; bool validate(const double currentVersion); bool isModified() const; @@ -48,7 +48,7 @@ private: void updateEffects(); /** @brief Updates the parameters according to the updateRules. * @see the related in README in effects/update */ - bool updateEffectParameters(QDomNodeList parameters, const QScriptValue *updateRules, const double serviceVersion, const double effectVersion); + bool updateEffectParameters(const QDomNodeList ¶meters, const QScriptValue *updateRules, const double serviceVersion, const double effectVersion); }; #endif diff --git a/src/dragvalue.cpp b/src/dragvalue.cpp index 6a8eeb1e..cf59b180 100644 --- a/src/dragvalue.cpp +++ b/src/dragvalue.cpp @@ -139,8 +139,8 @@ DragValue::DragValue(const QString &label, double defaultValue, int decimals, do DragValue::~DragValue() { - if (m_intEdit) delete m_intEdit; - if (m_doubleEdit) delete m_doubleEdit; + delete m_intEdit; + delete m_doubleEdit; delete m_menu; //delete m_scale; //delete m_directUpdate; diff --git a/src/dvdwizardvob.h b/src/dvdwizardvob.h index b35fb459..2dd461f0 100644 --- a/src/dvdwizardvob.h +++ b/src/dvdwizardvob.h @@ -44,7 +44,7 @@ class DvdTreeWidget : public QTreeWidget { Q_OBJECT public: - DvdTreeWidget(QWidget *parent); + explicit DvdTreeWidget(QWidget *parent); protected: virtual void dragEnterEvent(QDragEnterEvent * event ); diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp index 76abe7a2..be668149 100644 --- a/src/effectstackedit.cpp +++ b/src/effectstackedit.cpp @@ -75,7 +75,7 @@ void EffectStackEdit::updateProjectFormat(MltVideoProfile profile, Timecode t) m_metaInfo.timecode = t; } -void EffectStackEdit::setFrameSize(QPoint p) +void EffectStackEdit::setFrameSize(const QPoint &p) { m_metaInfo.frameSize = p; } diff --git a/src/effectstackedit.h b/src/effectstackedit.h index bcc242d1..c210b32e 100644 --- a/src/effectstackedit.h +++ b/src/effectstackedit.h @@ -44,7 +44,7 @@ public: * * Used to disable the effect, by setting disabled="1" */ void updateParameter(const QString &name, const QString &value); - void setFrameSize(QPoint p); + void setFrameSize(const QPoint &p); /** @brief Tells the parameters to update their timecode format according to KdenliveSettings. */ void updateTimecodeFormat(); /** @brief Returns true if this effect wants to keep track of current position in clip. */ @@ -63,7 +63,7 @@ private: ParameterContainer *m_paramWidget; public slots: - /** @brief Called when an effect is selected, builds the UI for this effect. */ + /** @brief Called when an effect is selected, builds the UI for this effect. */ void transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect = true); /** @brief Pass position changes of the timeline cursor to the effects to keep their local timelines in sync. */ diff --git a/src/geometryval.cpp b/src/geometryval.cpp index 2c52f685..0d706894 100644 --- a/src/geometryval.cpp +++ b/src/geometryval.cpp @@ -29,7 +29,7 @@ #include -Geometryval::Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint, QWidget* parent) : +Geometryval::Geometryval(const MltVideoProfile &profile, Timecode t, const QPoint &frame_size, int startPoint, QWidget* parent) : QWidget(parent), m_profile(profile), m_paramRect(NULL), diff --git a/src/geometryval.h b/src/geometryval.h index 740d6dd3..0e00447d 100644 --- a/src/geometryval.h +++ b/src/geometryval.h @@ -40,7 +40,7 @@ class Geometryval : public QWidget, public Ui::Geometryval { Q_OBJECT public: - explicit Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint = 0, QWidget* parent = 0); + explicit Geometryval(const MltVideoProfile &profile, Timecode t, const QPoint &frame_size, int startPoint = 0, QWidget* parent = 0); virtual ~Geometryval(); QDomElement getParamDesc(); QString getValue() const; diff --git a/src/guide.cpp b/src/guide.cpp index d26358b4..3d44c627 100644 --- a/src/guide.cpp +++ b/src/guide.cpp @@ -29,7 +29,7 @@ #include #include -Guide::Guide(CustomTrackView *view, GenTime pos, QString label, double height) : +Guide::Guide(CustomTrackView *view, GenTime pos, const QString &label, double height) : QGraphicsLineItem(), m_position(pos), m_label(label), diff --git a/src/guide.h b/src/guide.h index bcedf3af..5e77c857 100644 --- a/src/guide.h +++ b/src/guide.h @@ -34,7 +34,7 @@ class Guide : public QGraphicsLineItem { public: - Guide(CustomTrackView *view, GenTime pos, QString label, double height); + Guide(CustomTrackView *view, GenTime pos, const QString &label, double height); GenTime position() const; void updateGuide(const GenTime &newPos, const QString &comment = QString()); QString label() const; diff --git a/src/headertrack.cpp b/src/headertrack.cpp index af95f277..d1d8f0f7 100644 --- a/src/headertrack.cpp +++ b/src/headertrack.cpp @@ -33,7 +33,7 @@ #include #include -HeaderTrack::HeaderTrack(int index, TrackInfo info, int height, QList actions, QWidget *parent) : +HeaderTrack::HeaderTrack(int index, TrackInfo info, int height, const QList &actions, QWidget *parent) : QWidget(parent), m_index(index), m_type(info.type), diff --git a/src/headertrack.h b/src/headertrack.h index 3b69acf0..e262bb9c 100644 --- a/src/headertrack.h +++ b/src/headertrack.h @@ -32,7 +32,7 @@ class HeaderTrack : public QWidget, public Ui::TrackHeader_UI Q_OBJECT public: - HeaderTrack(int index, TrackInfo info, int height, QList actions, QWidget *parent = 0); + HeaderTrack(int index, TrackInfo info, int height, const QList & actions, QWidget *parent = 0); //virtual ~HeaderTrack(); void setLock(bool lock); void adjustSize(int height); diff --git a/src/jogshuttle.cpp b/src/jogshuttle.cpp index ede869ea..0e92cb42 100644 --- a/src/jogshuttle.cpp +++ b/src/jogshuttle.cpp @@ -68,7 +68,7 @@ #define JOG_STOP 10020 #define MAX_SHUTTLE_RANGE 7 -void ShuttleThread::init(QObject *parent, QString device) +void ShuttleThread::init(QObject *parent, const QString &device) { m_parent = parent; m_device = device; diff --git a/src/jogshuttle.h b/src/jogshuttle.h index 9a6ecc02..55b4472a 100644 --- a/src/jogshuttle.h +++ b/src/jogshuttle.h @@ -34,7 +34,7 @@ class ShuttleThread : public QThread public: virtual void run(); - void init(QObject *parent, QString device); + void init(QObject *parent, const QString &device); QObject *m_parent; int shuttlevalue; int shuttlecounter; diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp index 349ff081..37df4210 100644 --- a/src/kdenlivedoc.cpp +++ b/src/kdenlivedoc.cpp @@ -58,7 +58,7 @@ const double DOCUMENTVERSION = 0.88; -KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap properties, QMap metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) : +KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, const QString &profileName, QMap properties, QMap metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) : QObject(parent), m_autosave(NULL), m_url(url), diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h index 22aeac31..e0bbee1c 100644 --- a/src/kdenlivedoc.h +++ b/src/kdenlivedoc.h @@ -52,7 +52,7 @@ class KdenliveDoc: public QObject { Q_OBJECT public: - KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap properties, QMap metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0); + KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, const QString &profileName, QMap properties, QMap metadata, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0); ~KdenliveDoc(); QDomNodeList producersList(); double fps() const; diff --git a/src/kdenlivesettingsdialog.cpp b/src/kdenlivesettingsdialog.cpp index d0e09e1d..154bb030 100644 --- a/src/kdenlivesettingsdialog.cpp +++ b/src/kdenlivesettingsdialog.cpp @@ -105,7 +105,7 @@ KdenliveSettingsDialog::KdenliveSettingsDialog(const QMap& map #ifdef USE_V4L // Video 4 Linux device detection - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 10; ++i) { QString path = "/dev/video" + QString::number(i); if (QFile::exists(path)) { QStringList deviceInfo = V4lCaptureHandler::getDeviceName(path); diff --git a/src/keyframeedit.cpp b/src/keyframeedit.cpp index 2ff4ec6b..a326d953 100644 --- a/src/keyframeedit.cpp +++ b/src/keyframeedit.cpp @@ -25,7 +25,7 @@ #include -KeyframeEdit::KeyframeEdit(QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) : +KeyframeEdit::KeyframeEdit(const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent) : QWidget(parent), m_min(minFrame), m_max(maxFrame), diff --git a/src/keyframeedit.h b/src/keyframeedit.h index 2da6b6d8..05bd599b 100644 --- a/src/keyframeedit.h +++ b/src/keyframeedit.h @@ -80,7 +80,7 @@ class KeyframeEdit : public QWidget, public Ui::KeyframeEditor_UI { Q_OBJECT public: - explicit KeyframeEdit(QDomElement e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0); + explicit KeyframeEdit(const QDomElement &e, int minFrame, int maxFrame, Timecode tc, int activeKeyframe, QWidget* parent = 0); virtual ~KeyframeEdit(); virtual void addParameter(QDomElement e, int activeKeyframe = -1); const QString getValue(const QString &name); diff --git a/src/managecapturesdialog.cpp b/src/managecapturesdialog.cpp index a8e6dc72..7eed6c92 100644 --- a/src/managecapturesdialog.cpp +++ b/src/managecapturesdialog.cpp @@ -34,7 +34,7 @@ #include -ManageCapturesDialog::ManageCapturesDialog(KUrl::List files, QWidget * parent) : +ManageCapturesDialog::ManageCapturesDialog(const KUrl::List &files, QWidget * parent) : QDialog(parent) { setFont(KGlobalSettings::toolBarFont()); diff --git a/src/managecapturesdialog.h b/src/managecapturesdialog.h index dc0e1e78..55fea362 100644 --- a/src/managecapturesdialog.h +++ b/src/managecapturesdialog.h @@ -33,7 +33,7 @@ class ManageCapturesDialog : public QDialog Q_OBJECT public: - explicit ManageCapturesDialog(KUrl::List files, QWidget * parent = 0); + explicit ManageCapturesDialog(const KUrl::List &files, QWidget * parent = 0); ~ManageCapturesDialog(); KUrl::List importFiles(); diff --git a/src/markerdialog.h b/src/markerdialog.h index 6a78e468..710c6348 100644 --- a/src/markerdialog.h +++ b/src/markerdialog.h @@ -1,4 +1,4 @@ -/*************************************************************************** + /*************************************************************************** * Copyright (C) 2008 by Jean-Baptiste Mardelle (jb@kdenlive.org) * * * * This program is free software; you can redistribute it and/or modify * diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h index 91faa5ba..f572636b 100644 --- a/src/mltdevicecapture.h +++ b/src/mltdevicecapture.h @@ -1,4 +1,4 @@ -/*************************************************************************** + /*************************************************************************** mltdevicecapture.h - description ------------------- begin : Sun May 21 2011 @@ -62,7 +62,7 @@ Q_OBJECT public: bool sendFrameForAnalysis; /** @brief Someone needs us to send again a frame. */ - void sendFrameUpdate() {}; + void sendFrameUpdate() {} void emitFrameUpdated(Mlt::Frame&); void emitFrameNumber(double position); diff --git a/src/noteswidget.h b/src/noteswidget.h index ab9e8611..60eb7e98 100644 --- a/src/noteswidget.h +++ b/src/noteswidget.h @@ -34,7 +34,7 @@ class NotesWidget : public KTextEdit Q_OBJECT public: - NotesWidget(QWidget * parent = 0); + explicit NotesWidget(QWidget * parent = 0); ~NotesWidget(); protected: diff --git a/src/positionedit.cpp b/src/positionedit.cpp index c6aaae49..78bcdd37 100644 --- a/src/positionedit.cpp +++ b/src/positionedit.cpp @@ -25,7 +25,7 @@ #include #include -PositionEdit::PositionEdit(const QString name, int pos, int min, int max, const Timecode tc, QWidget* parent) : +PositionEdit::PositionEdit(const QString &name, int pos, int min, int max, const Timecode tc, QWidget* parent) : QWidget(parent) { QHBoxLayout *layout = new QHBoxLayout(this); diff --git a/src/positionedit.h b/src/positionedit.h index 2c5f243b..ed22ba6c 100644 --- a/src/positionedit.h +++ b/src/positionedit.h @@ -30,7 +30,7 @@ class PositionEdit : public QWidget { Q_OBJECT public: - explicit PositionEdit(const QString name, int pos, int min, int max, const Timecode tc, QWidget* parent = 0); + explicit PositionEdit(const QString &name, int pos, int min, int max, const Timecode tc, QWidget* parent = 0); virtual ~PositionEdit(); int getPosition() const; void setPosition(int pos); -- 2.39.2