From 4664de14c0240086ced95c4ff9e4c1101a60051d Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Mardelle Date: Sat, 7 Mar 2009 17:50:31 +0000 Subject: [PATCH] [PATCH by Ray Lehtiniemi] Do not return references to temporaries. svn path=/trunk/kdenlive/; revision=3105 --- src/docclipbase.cpp | 2 +- src/docclipbase.h | 2 +- src/kdenlivedoc.cpp | 2 +- src/kdenlivedoc.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp index 39f79c7e..81c55ad2 100644 --- a/src/docclipbase.cpp +++ b/src/docclipbase.cpp @@ -120,7 +120,7 @@ bool DocClipBase::audioThumbCreated() const { return m_audioThumbCreated; } -const QString & DocClipBase::name() const { +const QString DocClipBase::name() const { return m_properties.value("name"); } diff --git a/src/docclipbase.h b/src/docclipbase.h index 01e97219..03bc49ed 100644 --- a/src/docclipbase.h +++ b/src/docclipbase.h @@ -59,7 +59,7 @@ Q_OBJECT public: virtual ~ DocClipBase(); /** returns the name of this clip. */ - const QString & name() const; + const QString name() const; /** Returns the description of this clip. */ const QString description() const; diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp index 539f87a7..03a1d3bd 100644 --- a/src/kdenlivedoc.cpp +++ b/src/kdenlivedoc.cpp @@ -1465,7 +1465,7 @@ void KdenliveDoc::slotAddClipFile(const KUrl url, const QString group, const QSt setModified(true); } -const QString&KdenliveDoc::getFreeClipId() { +const QString KdenliveDoc::getFreeClipId() { return QString::number(m_clipManager->getFreeClipId()); } diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h index f474ab24..69b615d0 100644 --- a/src/kdenlivedoc.h +++ b/src/kdenlivedoc.h @@ -83,7 +83,7 @@ Q_OBJECT public: const QString description() const; void setUrl(KUrl url); void setProfilePath(QString path); - const QString &getFreeClipId(); + const QString getFreeClipId(); /** does the document need saving */ bool isModified() const; /** Returns project folder, used to store project files (titles, effects,...) */ -- 2.39.2