From 6eedf20f375a3cfe4ab475ec3a31fd7f83a5dd19 Mon Sep 17 00:00:00 2001 From: Christophe Mutricy Date: Fri, 19 Mar 2010 17:27:01 +0000 Subject: [PATCH] Avoid integer overflow --- modules/demux/asf/libasf.c | 2 +- modules/demux/avi/libavi.c | 2 +- modules/demux/mp4/libmp4.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/demux/asf/libasf.c b/modules/demux/asf/libasf.c index 65b05b01d5..803c849b18 100644 --- a/modules/demux/asf/libasf.c +++ b/modules/demux/asf/libasf.c @@ -1487,7 +1487,7 @@ static void ASF_ObjectDumpDebug( vlc_object_t *p_obj, psz_name = ASF_ObjectDumpDebugInfo[i].psz_name; char str[512]; - if( i_level * 5 + 1 >= sizeof(str) ) + if( i_level >= (sizeof(str) - 1)/5 ) return; memset( str, ' ', sizeof( str ) ); diff --git a/modules/demux/avi/libavi.c b/modules/demux/avi/libavi.c index 9f857d8679..45d20e2b43 100644 --- a/modules/demux/avi/libavi.c +++ b/modules/demux/avi/libavi.c @@ -803,7 +803,7 @@ static void AVI_ChunkDumpDebug_level( vlc_object_t *p_obj, avi_chunk_t *p_child; char str[512]; - if( i_level * 5 + 1 >= sizeof(str) ) + if( i_level >= (sizeof(str) - 1)/5 ) return; memset( str, ' ', sizeof( str ) ); diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c index 9a92934d8d..c84b74efd9 100644 --- a/modules/demux/mp4/libmp4.c +++ b/modules/demux/mp4/libmp4.c @@ -2895,7 +2895,7 @@ static void __MP4_BoxDumpStructure( stream_t *s, unsigned int i; char str[512]; - if( i_level * 5 + 1 >= sizeof(str) ) + if( i_level >= (sizeof(str) - 1)/5 ) return; memset( str, ' ', sizeof(str) ); -- 2.39.2