From 926bbf142f297f9715e3cc5ad746b98a448c3451 Mon Sep 17 00:00:00 2001 From: Ilkka Ollakka Date: Fri, 18 Jun 2010 15:35:04 +0300 Subject: [PATCH] Qt4: don't do playlist_model recursive remove as core signals for those anyway --- modules/gui/qt4/components/playlist/playlist_model.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/modules/gui/qt4/components/playlist/playlist_model.cpp b/modules/gui/qt4/components/playlist/playlist_model.cpp index d1a7ac4187..c86a701086 100644 --- a/modules/gui/qt4/components/playlist/playlist_model.cpp +++ b/modules/gui/qt4/components/playlist/playlist_model.cpp @@ -779,10 +779,8 @@ void PLModel::updateTreeItem( PLItem *item ) /************************* Actions ******************************/ /** - * Deletion, here we have to do a ugly slow hack as we retrieve the full - * list of indexes to delete at once: when we delete a node and all of - * its children, we need to update the list. - * Todo: investigate whethere we can use ranges to be sure to delete all items? + * Lets not worry about nodes children, we do refersh anyway when + * core tells that playlist has changed, should give some more speed */ void PLModel::doDelete( QModelIndexList selected ) { @@ -796,8 +794,6 @@ void PLModel::doDelete( QModelIndexList selected ) if( index.column() != 0 ) continue; PLItem *item = getItem( index ); - if( item->children.size() ) - recurseDelete( item->children, &selected ); PL_LOCK; playlist_DeleteFromInput( p_playlist, item->p_input, pl_Locked ); -- 2.39.2