From f389b8c737a6a0f9450beb20328058fdce10093f Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Mardelle Date: Wed, 31 Aug 2011 22:30:30 +0000 Subject: [PATCH] cppcheck fixes, patch by Mikko Rapeli [1/27] svn path=/trunk/kdenlive/; revision=5848 --- src/abstractclipitem.cpp | 6 +++--- src/abstractclipitem.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/abstractclipitem.cpp b/src/abstractclipitem.cpp index 030ec846..1dd88629 100644 --- a/src/abstractclipitem.cpp +++ b/src/abstractclipitem.cpp @@ -29,7 +29,7 @@ #include #include -AbstractClipItem::AbstractClipItem(const ItemInfo info, const QRectF& rect, double fps) : +AbstractClipItem::AbstractClipItem(const ItemInfo &info, const QRectF& rect, double fps) : QObject(), QGraphicsRectItem(rect), m_info(info), @@ -395,7 +395,7 @@ double AbstractClipItem::selectedKeyFrameValue() const return m_keyframes.value(m_selectedKeyframe); } -void AbstractClipItem::updateKeyFramePos(const GenTime pos, const double value) +void AbstractClipItem::updateKeyFramePos(const GenTime &pos, const double value) { if (!m_keyframes.contains(m_editedKeyframe)) return; @@ -437,7 +437,7 @@ int AbstractClipItem::keyFrameNumber() const return m_keyframes.count(); } -int AbstractClipItem::addKeyFrame(const GenTime pos, const double value) +int AbstractClipItem::addKeyFrame(const GenTime &pos, const double value) { QRectF br = sceneBoundingRect(); double maxh = 100.0 / br.height() / m_keyframeFactor; diff --git a/src/abstractclipitem.h b/src/abstractclipitem.h index ff59dec8..c621c8cd 100644 --- a/src/abstractclipitem.h +++ b/src/abstractclipitem.h @@ -42,15 +42,15 @@ class AbstractClipItem : public QObject, public QGraphicsRectItem #endif public: - AbstractClipItem(const ItemInfo info, const QRectF& rect, double fps); + AbstractClipItem(const ItemInfo &info, const QRectF& rect, double fps); virtual ~ AbstractClipItem(); void updateSelectedKeyFrame(); /** @brief Move the selected keyframe (does not influence the effect, only the display in timeline). * @param pos new Position * @param value new Value */ - void updateKeyFramePos(const GenTime pos, const double value); - int addKeyFrame(const GenTime pos, const double value); + void updateKeyFramePos(const GenTime &pos, const double value); + int addKeyFrame(const GenTime &pos, const double value); bool hasKeyFrames() const; int editedKeyFramePos() const; int selectedKeyFramePos() const; -- 2.39.2