From ff2dda64a4bb0ee5057f429018a96dc5efbc283d Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Sun, 12 May 2013 08:36:50 +0200 Subject: [PATCH] Const'ify, use isEmpty() --- src/renderwidget.cpp | 11 +++++------ src/renderwidget.h | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp index ab8183e9..60ee904b 100644 --- a/src/renderwidget.cpp +++ b/src/renderwidget.cpp @@ -382,7 +382,7 @@ void RenderWidget::setGuides(QDomElement guidesxml, double duration) m_view.guide_start->clear(); m_view.guide_end->clear(); QDomNodeList nodes = guidesxml.elementsByTagName("guide"); - if (nodes.count() > 0) { + if (!nodes.isEmpty()) { m_view.guide_start->addItem(i18n("Beginning"), "0"); m_view.render_guide->setEnabled(true); m_view.create_chapter->setEnabled(true); @@ -400,7 +400,7 @@ void RenderWidget::setGuides(QDomElement guidesxml, double duration) m_view.guide_end->addItem(e.attribute("comment") + '/' + guidePos, e.attribute("time").toDouble()); } } - if (nodes.count() > 0) + if (!nodes.isEmpty()) m_view.guide_end->addItem(i18n("End"), QString::number(duration)); } @@ -408,7 +408,7 @@ void RenderWidget::setGuides(QDomElement guidesxml, double duration) * Will be called when the user selects an output file via the file dialog. * File extension will be added automatically. */ -void RenderWidget::slotUpdateButtons(KUrl url) +void RenderWidget::slotUpdateButtons(const KUrl &url) { if (m_view.out_file->url().isEmpty()) { m_view.buttonGenerateScript->setEnabled(false); @@ -423,9 +423,8 @@ void RenderWidget::slotUpdateButtons(KUrl url) m_view.buttonGenerateScript->setEnabled(false); return; } - QString extension = item->data(ExtensionRole).toString(); - url = filenameWithExtension(url, extension); - m_view.out_file->setUrl(url); + const QString extension = item->data(ExtensionRole).toString(); + m_view.out_file->setUrl(filenameWithExtension(url, extension)); } } diff --git a/src/renderwidget.h b/src/renderwidget.h index c604aa8a..f0dd03e6 100644 --- a/src/renderwidget.h +++ b/src/renderwidget.h @@ -145,7 +145,7 @@ public slots: void slotExport(bool scriptExport, int zoneIn, int zoneOut, const QMap metadata, const QString &playlistPath, const QString &scriptPath, bool exportAudio); private slots: - void slotUpdateButtons(KUrl url); + void slotUpdateButtons(const KUrl &url); void slotUpdateButtons(); void refreshView(const QString &profile = QString()); void refreshCategory(const QString &group = QString(), const QString &profile = QString()); -- 2.39.2