Add FIXME comment about empty last group.

[ccbs] / html / show-tournament.pl

diff --git a/html/show-tournament.pl b/html/show-tournament.pl
index fa95fb4d67a86d8443602c9e432c2d462ec93199..3a407f80e99dafa1848bcc03c697f261179c7940 100755 (executable)
--- a/html/show-tournament.pl
+++ b/html/show-tournament.pl
@@ -13,6 +13,17 @@ my $tournament = $dbh->selectrow_hashref('SELECT * FROM tournaments NATURAL JOIN
 my $rankings = ccbs::db_fetch_all($dbh, 'SELECT ranking,nick,COALESCE(points,-1) AS points FROM tournamentrankings NATURAL JOIN players WHERE tournament=? ORDER BY ranking', $id);
 my $songs = ccbs::db_fetch_all($dbh, 'SELECT song,title FROM machinesongs NATURAL JOIN songs WHERE machine=? ORDER BY LOWER(title)', $tournament->{'machine'});
 
+# Check if the last round is valid for closing (by checking if all scores
+# entered are valid)
+my $ref = $dbh->selectrow_hashref('SELECT COUNT(*) AS num_incomplete FROM scores WHERE tournament=? AND (song IS NULL OR playmode IS NULL OR difficulty IS NULL OR chosen IS NULL or score IS NULL)', undef, $tournament->{'tournament'});
+my ($closing_valid,$finishing_valid);
+$finishing_valid = 0;
+if ($ref->{'num_incomplete'} == 0) {
+       $closing_valid = 1;
+} else {
+       $closing_valid = 0;
+}
+
 # Swoop all the data in in a big join, then order it over to quasi-sane Perl objects.
 # (round -> parallel -> player -> songs -> title,chosen,score)
 my $scores = ccbs::db_fetch_all($dbh,
@@ -25,7 +36,7 @@ my ($round, $parallel, $player) = (-1,-1,'');
 for my $score (@$scores) {
        if ($score->{'round'} != $round) {
                $round = $score->{'round'};
-               push @rounds, { round => $round, parallels => [] };
+               push @rounds, { round => $round, parallels => [], locked => 0 };
                $parallel = -1;
        }
        my $p = $rounds[$#rounds]->{'parallels'};
@@ -50,21 +61,33 @@ for my $score (@$scores) {
        my $pl = $p->[$#$p]->{'players'};
        if ($score->{'nick'} ne $player) {
                $player = $score->{'nick'};
-               push @$pl, { player => $score->{'player'}, nick => $player, songs => [], total => 0, locked => 1 };
+               push @$pl, { player => $score->{'player'}, nick => $player, songs => [], total => 0 };
        }
        
        push @{$pl->[$#$pl]->{'songs'}}, $score;
 
        if (defined($score->{'score'})) {
                $pl->[$#$pl]->{'total'} += $score->{'score'};
-       } else {
-               $pl->[$#$pl]->{'locked'} = 0;
        }
 }
 
+# FIXME: In some odd cases, there _might_ be an empty group right at the end. Fix this when
+#        we are able to add/delete people in groups.
+
 my $num_rounds = scalar @rounds;
 my $num_rankings = scalar @$rankings;
 
+# Lock all rounds but the last (active?) one
+for my $r (0..$#rounds-1) {
+       $rounds[$r]->{'locked'} = 1;
+}
+
+# If there's only one group left and it's valid for closing, we can also finish
+# the entire tournament if we'd like
+if ($closing_valid && (scalar @{$rounds[$#rounds]->{'parallels'}}) == 1) {
+       $finishing_valid = 1;
+}
+
 # If there have been no rounds, check out the number of participants; if not, check the
 # number of qualified from the last round
 my $num_qualified;
@@ -84,6 +107,8 @@ ccbs::process_template('show-tournament.tmpl', $tournament->{'tournamentname'},
        rounds => \@rounds,
        num_rounds => $num_rounds,
        num_qualified => $num_qualified,
-       songs => $songs
+       songs => $songs,
+       closing_valid => $closing_valid,
+       finishing_valid => $finishing_valid
 });
 $dbh->disconnect;