Force input encoding for UDP streams to raw already at config parsing.

[cubemap] / config.cpp

diff --git a/config.cpp b/config.cpp
index 55968eed644763d7185be915eb5833cdf4eab03a..919f21256bd650655985fd9873ec61dcb65f5a8b 100644 (file)
--- a/config.cpp
+++ b/config.cpp
@@ -7,15 +7,16 @@
 #include <string.h>
 #include <net/if.h>
 #include <sys/socket.h>
-#include <map>
 #include <string>
 #include <utility>
+#include <unordered_map>
 #include <vector>
 
 #include "tlse.h"
 
 #include "acceptor.h"
 #include "config.h"
+#include "input.h"
 #include "log.h"
 #include "parse.h"
 
@@ -26,7 +27,7 @@ using namespace std;
 struct ConfigLine {
        string keyword;
        vector<string> arguments;
-       map<string, string> parameters;
+       unordered_map<string, string> parameters;
 };
 
 namespace {
@@ -211,7 +212,7 @@ bool load_file_to_string(const string &filename, size_t max_size, string *conten
        return true;
 }
 
-bool parse_tls_parameters(const map<string, string> &parameters, AcceptorConfig *acceptor)
+bool parse_tls_parameters(const unordered_map<string, string> &parameters, AcceptorConfig *acceptor)
 {
        bool has_cert = false, has_key = false;
 
@@ -326,12 +327,21 @@ bool parse_stream(const ConfigLine &line, Config *config)
        stream.url = line.arguments[0];
 
        const auto src_it = line.parameters.find("src");
+       bool input_is_udp = false;
        if (src_it == line.parameters.end()) {
                log(WARNING, "stream '%s' has no src= attribute, clients will not get any data.",
                        stream.url.c_str());
        } else {
                stream.src = src_it->second;
-               // TODO: Verify that the URL is parseable?
+
+               string protocol, user, host, port, path;
+               if (!parse_url(stream.src, &protocol, &user, &host, &port, &path)) {
+                       log(ERROR, "could not parse URL '%s'", stream.src.c_str());
+                       return false;
+               }
+               if (protocol == "udp") {
+                       input_is_udp = true;
+               }
        }
 
        const auto backlog_it = line.parameters.find("backlog_size");
@@ -362,13 +372,18 @@ bool parse_stream(const ConfigLine &line, Config *config)
 
        // Parse input encoding.
        const auto src_encoding_parm_it = line.parameters.find("src_encoding");
-       if (src_encoding_parm_it == line.parameters.end() ||
-           src_encoding_parm_it->second == "metacube") {
+       if (src_encoding_parm_it == line.parameters.end()) {
+               stream.src_encoding = input_is_udp ? StreamConfig::STREAM_ENCODING_RAW : StreamConfig::STREAM_ENCODING_METACUBE;
+       } else if (src_encoding_parm_it->second == "metacube") {
+               if (input_is_udp) {
+                       log(ERROR, "UDP streams cannot have Metacube input");
+                       return false;
+               }
                stream.src_encoding = StreamConfig::STREAM_ENCODING_METACUBE;
        } else if (src_encoding_parm_it->second == "raw") {
                stream.src_encoding = StreamConfig::STREAM_ENCODING_RAW;
        } else {
-               log(ERROR, "Parameter 'src_encoding' must be either 'raw' or 'metacube' (default)");
+               log(ERROR, "Parameter 'src_encoding' must be either 'raw' (default for UDP) or 'metacube' (default for HTTP)");
                return false;
        }
 
@@ -380,6 +395,54 @@ bool parse_stream(const ConfigLine &line, Config *config)
                stream.pacing_rate = atoi(pacing_rate_it->second.c_str()) * 1024 / 8;
        }
 
+       // Parse the HLS URL, if any.
+       const auto hls_url_it = line.parameters.find("hls_playlist");
+       if (hls_url_it != line.parameters.end()) {
+               stream.hls_url = hls_url_it->second;
+               if (stream.hls_url.empty()) {
+                       log(ERROR, "Parameter 'hls_playlist' was given but empty");
+                       return false;
+               }
+               if (stream.encoding == StreamConfig::STREAM_ENCODING_METACUBE) {
+                       log(ERROR, "HLS cannot be used with Metacube output");
+                       return false;
+               }
+       }
+
+       // Parse the HLS fragment duration, if any.
+       const auto hls_frag_duration_it = line.parameters.find("hls_frag_duration");
+       if (hls_frag_duration_it != line.parameters.end()) {
+               if (stream.hls_url.empty()) {
+                       log(ERROR, "Parameter 'hls_frag_duration' given, but no 'hls_playlist' given");
+                       return false;
+               }
+               stream.hls_frag_duration = stoi(hls_frag_duration_it->second);
+               if (stream.hls_frag_duration <= 0) {
+                       log(ERROR, "'hls_frag_duration' must be a strictly positive integer");
+                       return false;
+               }
+       }
+
+       // Parse the HLS backlog margin, if any.
+       const auto hls_backlog_margin_it = line.parameters.find("hls_backlog_margin");
+       if (hls_backlog_margin_it != line.parameters.end()) {
+               if (stream.hls_url.empty()) {
+                       log(ERROR, "Parameter 'hls_backlog_margin' given, but no 'hls_playlist' given");
+                       return false;
+               }
+               stream.hls_backlog_margin = stoi(hls_backlog_margin_it->second);
+               if (stream.hls_backlog_margin < 0 || stream.hls_backlog_margin >= stream.backlog_size) {
+                       log(ERROR, "'hls_backlog_margin' must be nonnegative, but less than the backlog size");
+                       return false;
+               }
+       }
+
+       // Parse the CORS origin, if it exists.
+       const auto allow_origin_it = line.parameters.find("allow_origin");
+       if (allow_origin_it != line.parameters.end()) {
+               stream.allow_origin = allow_origin_it->second;
+       }
+
        config->streams.push_back(stream);
        return true;
 }