]> git.sesse.net Git - cubemap/blobdiff - main.cpp
Add suppor for raw (non-Metacube) inputs over HTTP. Only really useful for TS.
[cubemap] / main.cpp
index 8430c207134ee026bb9fcb45713eea70ee0c746e..a7ad64c5748d07e8e7a2b6b66bacb01340d7b44d 100644 (file)
--- a/main.cpp
+++ b/main.cpp
@@ -9,7 +9,9 @@
 #include <string.h>
 #include <sys/time.h>
 #include <sys/wait.h>
+#include <systemd/sd-daemon.h>
 #include <unistd.h>
+#include <algorithm>
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "acceptor.h"
+#include "accesslog.h"
 #include "config.h"
 #include "input.h"
+#include "input_stats.h"
 #include "log.h"
-#include "markpool.h"
+#include "sa_compare.h"
 #include "serverpool.h"
 #include "state.pb.h"
 #include "stats.h"
+#include "stream.h"
 #include "util.h"
 #include "version.h"
 
 using namespace std;
 
+AccessLogThread *access_log = NULL;
 ServerPool *servers = NULL;
 volatile bool hupped = false;
 volatile bool stopped = false;
 
+typedef pair<string, Input::Encoding> InputKey;
+
+namespace {
+
+struct OrderByConnectionTime {
+       bool operator() (const ClientProto &a, const ClientProto &b) const {
+               if (a.connect_time_sec() != b.connect_time_sec())
+                       return a.connect_time_sec() < b.connect_time_sec();
+               return a.connect_time_nsec() < b.connect_time_nsec();
+       }
+};
+
+}  // namespace
+
+struct InputWithRefcount {
+       Input *input;
+       int refcount;
+};
+
 void hup(int signum)
 {
        hupped = true;
@@ -41,21 +66,27 @@ void hup(int signum)
        }
 }
 
-CubemapStateProto collect_state(const timeval &serialize_start,
+void do_nothing(int signum)
+{
+}
+
+CubemapStateProto collect_state(const timespec &serialize_start,
                                 const vector<Acceptor *> acceptors,
-                                const vector<Input *> inputs,
+                                const multimap<InputKey, InputWithRefcount> inputs,
                                 ServerPool *servers)
 {
        CubemapStateProto state = servers->serialize();  // Fills streams() and clients().
        state.set_serialize_start_sec(serialize_start.tv_sec);
-       state.set_serialize_start_usec(serialize_start.tv_usec);
+       state.set_serialize_start_usec(serialize_start.tv_nsec / 1000);
        
        for (size_t i = 0; i < acceptors.size(); ++i) {
                state.add_acceptors()->MergeFrom(acceptors[i]->serialize());
        }
 
-       for (size_t i = 0; i < inputs.size(); ++i) {
-               state.add_inputs()->MergeFrom(inputs[i]->serialize());
+       for (multimap<InputKey, InputWithRefcount>::const_iterator input_it = inputs.begin();
+            input_it != inputs.end();
+            ++input_it) {
+               state.add_inputs()->MergeFrom(input_it->second.input->serialize());
        }
 
        return state;
@@ -64,27 +95,28 @@ CubemapStateProto collect_state(const timeval &serialize_start,
 // Find all port statements in the configuration file, and create acceptors for htem.
 vector<Acceptor *> create_acceptors(
        const Config &config,
-       map<int, Acceptor *> *deserialized_acceptors)
+       map<sockaddr_in6, Acceptor *, Sockaddr6Compare> *deserialized_acceptors)
 {
        vector<Acceptor *> acceptors;
        for (unsigned i = 0; i < config.acceptors.size(); ++i) {
                const AcceptorConfig &acceptor_config = config.acceptors[i];
                Acceptor *acceptor = NULL;
-               map<int, Acceptor *>::iterator deserialized_acceptor_it =
-                       deserialized_acceptors->find(acceptor_config.port);
+               map<sockaddr_in6, Acceptor *, Sockaddr6Compare>::iterator deserialized_acceptor_it =
+                       deserialized_acceptors->find(acceptor_config.addr);
                if (deserialized_acceptor_it != deserialized_acceptors->end()) {
                        acceptor = deserialized_acceptor_it->second;
                        deserialized_acceptors->erase(deserialized_acceptor_it);
                } else {
-                       int server_sock = create_server_socket(acceptor_config.port, TCP_SOCKET);
-                       acceptor = new Acceptor(server_sock, acceptor_config.port);
+                       int server_sock = create_server_socket(acceptor_config.addr, TCP_SOCKET);
+                       acceptor = new Acceptor(server_sock, acceptor_config.addr);
                }
                acceptor->run();
                acceptors.push_back(acceptor);
        }
 
        // Close all acceptors that are no longer in the configuration file.
-       for (map<int, Acceptor *>::iterator acceptor_it = deserialized_acceptors->begin();
+       for (map<sockaddr_in6, Acceptor *, Sockaddr6Compare>::iterator
+                acceptor_it = deserialized_acceptors->begin();
             acceptor_it != deserialized_acceptors->end();
             ++acceptor_it) {
                acceptor_it->second->close_socket();
@@ -94,88 +126,125 @@ vector<Acceptor *> create_acceptors(
        return acceptors;
 }
 
+void create_config_input(const string &src, Input::Encoding encoding, multimap<InputKey, InputWithRefcount> *inputs)
+{
+       if (src.empty()) {
+               return;
+       }
+       InputKey key(src, encoding);
+       if (inputs->count(key) != 0) {
+               return;
+       }
+
+       InputWithRefcount iwr;
+       iwr.input = create_input(src, encoding);
+       if (iwr.input == NULL) {
+               log(ERROR, "did not understand URL '%s' or source encoding was invalid, clients will not get any data.",
+                       src.c_str());
+               return;
+       }
+       iwr.refcount = 0;
+       inputs->insert(make_pair(key, iwr));
+}
+
 // Find all streams in the configuration file, and create inputs for them.
-vector<Input *> create_inputs(const Config &config,
-                              map<string, Input *> *deserialized_inputs)
+void create_config_inputs(const Config &config, multimap<InputKey, InputWithRefcount> *inputs)
 {
-       vector<Input *> inputs;
        for (unsigned i = 0; i < config.streams.size(); ++i) {
                const StreamConfig &stream_config = config.streams[i];
-               if (stream_config.src.empty()) {
-                       continue;
+               if (stream_config.src != "delete") {
+                       create_config_input(stream_config.src, Input::Encoding(stream_config.src_encoding), inputs);
                }
-
-               string stream_id = stream_config.stream_id;
-               string src = stream_config.src;
-
-               Input *input = NULL;
-               map<string, Input *>::iterator deserialized_input_it =
-                       deserialized_inputs->find(stream_id);
-               if (deserialized_input_it != deserialized_inputs->end()) {
-                       input = deserialized_input_it->second;
-                       if (input->get_url() != src) {
-                               log(INFO, "Stream '%s' has changed URL from '%s' to '%s', restarting input.",
-                                       stream_id.c_str(), input->get_url().c_str(), src.c_str());
-                               input->close_socket();
-                               delete input;
-                               input = NULL;
-                       }
-                       deserialized_inputs->erase(deserialized_input_it);
-               }
-               if (input == NULL) {
-                       input = create_input(stream_id, src);
-                       if (input == NULL) {
-                               log(ERROR, "did not understand URL '%s', clients will not get any data.",
-                                       src.c_str());
-                               continue;
-                       }
-               }
-               input->run();
-               inputs.push_back(input);
        }
-       return inputs;
+       for (unsigned i = 0; i < config.udpstreams.size(); ++i) {
+               const UDPStreamConfig &udpstream_config = config.udpstreams[i];
+               create_config_input(udpstream_config.src, Input::Encoding(udpstream_config.src_encoding), inputs);
+       }
 }
 
 void create_streams(const Config &config,
-                    const set<string> &deserialized_stream_ids,
-                   map<string, Input *> *deserialized_inputs)
+                    const set<string> &deserialized_urls,
+                    multimap<InputKey, InputWithRefcount> *inputs)
 {
-       vector<MarkPool *> mark_pools;  // FIXME: leak
-       for (unsigned i = 0; i < config.mark_pools.size(); ++i) {
-               const MarkPoolConfig &mp_config = config.mark_pools[i];
-               mark_pools.push_back(new MarkPool(mp_config.from, mp_config.to));
-       }
-
-       set<string> expecting_stream_ids = deserialized_stream_ids;
+       // HTTP streams.
+       set<string> expecting_urls = deserialized_urls;
        for (unsigned i = 0; i < config.streams.size(); ++i) {
                const StreamConfig &stream_config = config.streams[i];
-               if (deserialized_stream_ids.count(stream_config.stream_id) == 0) {
-                       servers->add_stream(stream_config.stream_id, stream_config.backlog_size);
+               int stream_index;
+
+               expecting_urls.erase(stream_config.url);
+
+               // Special-case deleted streams; they were never deserialized in the first place,
+               // so just ignore them.
+               if (stream_config.src == "delete") {
+                       continue;
+               }
+
+               if (deserialized_urls.count(stream_config.url) == 0) {
+                       stream_index = servers->add_stream(stream_config.url,
+                                                          stream_config.backlog_size,
+                                                          stream_config.prebuffering_bytes,
+                                                          Stream::Encoding(stream_config.encoding),
+                                                          Stream::Encoding(stream_config.src_encoding));
                } else {
-                       servers->set_backlog_size(stream_config.stream_id, stream_config.backlog_size);
+                       stream_index = servers->lookup_stream_by_url(stream_config.url);
+                       assert(stream_index != -1);
+                       servers->set_backlog_size(stream_index, stream_config.backlog_size);
+                       servers->set_prebuffering_bytes(stream_index, stream_config.prebuffering_bytes);
+                       servers->set_encoding(stream_index,
+                                             Stream::Encoding(stream_config.encoding));
+                       servers->set_src_encoding(stream_index,
+                                                 Stream::Encoding(stream_config.src_encoding));
                }
-               expecting_stream_ids.erase(stream_config.stream_id);
 
-               if (stream_config.mark_pool != -1) {
-                       servers->set_mark_pool(stream_config.stream_id,
-                                              mark_pools[stream_config.mark_pool]);
+               servers->set_pacing_rate(stream_index, stream_config.pacing_rate);
+
+               string src = stream_config.src;
+               Input::Encoding src_encoding = Input::Encoding(stream_config.src_encoding);
+               if (!src.empty()) {
+                       multimap<InputKey, InputWithRefcount>::iterator input_it = inputs->find(make_pair(src, src_encoding));
+                       if (input_it != inputs->end()) {
+                               input_it->second.input->add_destination(stream_index);
+                               ++input_it->second.refcount;
+                       }
                }
        }
 
-       // Warn about any servers we've lost.
-       // TODO: Make an option (delete=yes?) to actually shut down streams.
-       for (set<string>::const_iterator stream_it = expecting_stream_ids.begin();
-            stream_it != expecting_stream_ids.end();
+       // Warn about any streams servers we've lost.
+       for (set<string>::const_iterator stream_it = expecting_urls.begin();
+            stream_it != expecting_urls.end();
             ++stream_it) {
-               string stream_id = *stream_it;
+               string url = *stream_it;
                log(WARNING, "stream '%s' disappeared from the configuration file. "
-                            "It will not be deleted, but clients will not get any new inputs.",
-                            stream_id.c_str());
-               if (deserialized_inputs->count(stream_id) != 0) {
-                       delete (*deserialized_inputs)[stream_id];
-                       deserialized_inputs->erase(stream_id);
+                            "It will not be deleted, but clients will not get any new inputs. "
+                            "If you really meant to delete it, set src=delete and reload.",
+                            url.c_str());
+       }
+
+       // UDP streams.
+       for (unsigned i = 0; i < config.udpstreams.size(); ++i) {
+               const UDPStreamConfig &udpstream_config = config.udpstreams[i];
+               int stream_index = servers->add_udpstream(
+                       udpstream_config.dst,
+                       udpstream_config.pacing_rate,
+                       udpstream_config.ttl,
+                       udpstream_config.multicast_iface_index);
+
+               string src = udpstream_config.src;
+               Input::Encoding src_encoding = Input::Encoding(udpstream_config.src_encoding);
+               if (!src.empty()) {
+                       multimap<InputKey, InputWithRefcount>::iterator input_it = inputs->find(make_pair(src, src_encoding));
+                       assert(input_it != inputs->end());
+                       input_it->second.input->add_destination(stream_index);
+                       ++input_it->second.refcount;
                }
        }
+
+       // HTTP gen204 endpoints.
+       for (unsigned i = 0; i < config.pings.size(); ++i) {
+               const Gen204Config &ping_config = config.pings[i];
+               servers->add_gen204(ping_config.url, ping_config.allow_origin);
+       }
 }
        
 void open_logs(const vector<LogConfig> &log_destinations)
@@ -194,7 +263,7 @@ void open_logs(const vector<LogConfig> &log_destinations)
        start_logging();
 }
        
-bool dry_run_config(const std::string &argv0, const std::string &config_filename)
+bool dry_run_config(const string &argv0, const string &config_filename)
 {
        char *argv0_copy = strdup(argv0.c_str());
        char *config_filename_copy = strdup(config_filename.c_str());
@@ -233,10 +302,22 @@ bool dry_run_config(const std::string &argv0, const std::string &config_filename
        return (WIFEXITED(status) && WEXITSTATUS(status) == 0);
 }
 
+void find_deleted_streams(const Config &config, set<string> *deleted_urls)
+{
+       for (unsigned i = 0; i < config.streams.size(); ++i) {
+               const StreamConfig &stream_config = config.streams[i];
+               if (stream_config.src == "delete") {
+                       log(INFO, "Deleting stream '%s'.", stream_config.url.c_str());
+                       deleted_urls->insert(stream_config.url);
+               }
+       }
+}
+
 int main(int argc, char **argv)
 {
        signal(SIGHUP, hup);
        signal(SIGINT, hup);
+       signal(SIGUSR1, do_nothing);  // Used in internal signalling.
        signal(SIGPIPE, SIG_IGN);
        
        // Parse options.
@@ -246,9 +327,10 @@ int main(int argc, char **argv)
                static const option long_options[] = {
                        { "state", required_argument, 0, 's' },
                        { "test-config", no_argument, 0, 't' },
+                       { 0, 0, 0, 0 }
                };
                int option_index = 0;
-               int c = getopt_long (argc, argv, "s:t", long_options, &option_index);
+               int c = getopt_long(argc, argv, "s:t", long_options, &option_index);
      
                if (c == -1) {
                        break;
@@ -261,7 +343,8 @@ int main(int argc, char **argv)
                        test_config = true;
                        break;
                default:
-                       assert(false);
+                       fprintf(stderr, "Unknown option '%s'\n", argv[option_index]);
+                       exit(1);
                }
        }
 
@@ -274,7 +357,7 @@ int main(int argc, char **argv)
        char argv0_canon[PATH_MAX];
        char config_filename_canon[PATH_MAX];
 
-       if (realpath(argv[0], argv0_canon) == NULL) {
+       if (realpath("/proc/self/exe", argv0_canon) == NULL) {
                log_perror(argv[0]);
                exit(1);
        }
@@ -307,17 +390,29 @@ start:
        open_logs(config.log_destinations);
 
        log(INFO, "Cubemap " SERVER_VERSION " starting.");
+       if (config.access_log_file.empty()) {
+               // Create a dummy logger.
+               access_log = new AccessLogThread();
+       } else {
+               access_log = new AccessLogThread(config.access_log_file);
+       }
+       access_log->run();
+
        servers = new ServerPool(config.num_servers);
 
+       // Find all the streams that are to be deleted.
+       set<string> deleted_urls;
+       find_deleted_streams(config, &deleted_urls);
+
        CubemapStateProto loaded_state;
-       struct timeval serialize_start;
-       set<string> deserialized_stream_ids;
-       map<string, Input *> deserialized_inputs;
-       map<int, Acceptor *> deserialized_acceptors;
+       timespec serialize_start;
+       set<string> deserialized_urls;
+       map<sockaddr_in6, Acceptor *, Sockaddr6Compare> deserialized_acceptors;
+       multimap<InputKey, InputWithRefcount> inputs;  // multimap due to older versions without deduplication.
        if (state_fd != -1) {
                log(INFO, "Deserializing state from previous process...");
                string serialized;
-               if (!read_tempfile(state_fd, &serialized)) {
+               if (!read_tempfile_and_close(state_fd, &serialized)) {
                        exit(1);
                }
                if (!loaded_state.ParseFromString(serialized)) {
@@ -326,49 +421,121 @@ start:
                }
 
                serialize_start.tv_sec = loaded_state.serialize_start_sec();
-               serialize_start.tv_usec = loaded_state.serialize_start_usec();
+               serialize_start.tv_nsec = loaded_state.serialize_start_usec() * 1000ull;
 
                // Deserialize the streams.
+               map<string, string> stream_headers_for_url;  // See below.
                for (int i = 0; i < loaded_state.streams_size(); ++i) {
-                       servers->add_stream_from_serialized(loaded_state.streams(i));
-                       deserialized_stream_ids.insert(loaded_state.streams(i).stream_id());
+                       const StreamProto &stream = loaded_state.streams(i);
+
+                       if (deleted_urls.count(stream.url()) != 0) {
+                               // Delete the stream backlogs.
+                               for (int j = 0; j < stream.data_fds_size(); ++j) {
+                                       safe_close(stream.data_fds(j));
+                               }
+                       } else {
+                               vector<int> data_fds;
+                               for (int j = 0; j < stream.data_fds_size(); ++j) {
+                                       data_fds.push_back(stream.data_fds(j));
+                               }
+
+                               servers->add_stream_from_serialized(stream, data_fds);
+                               deserialized_urls.insert(stream.url());
+
+                               stream_headers_for_url.insert(make_pair(stream.url(), stream.stream_header()));
+                       }
                }
 
-               // Deserialize the inputs. Note that we don't actually add them to any state yet.
+               // Deserialize the inputs. Note that we don't actually add them to any stream yet.
                for (int i = 0; i < loaded_state.inputs_size(); ++i) {
-                       deserialized_inputs.insert(make_pair(
-                               loaded_state.inputs(i).stream_id(),
-                               create_input(loaded_state.inputs(i))));
+                       InputProto serialized_input = loaded_state.inputs(i);
+
+                       InputWithRefcount iwr;
+                       iwr.input = create_input(serialized_input);
+                       iwr.refcount = 0;
+
+                       Input::Encoding src_encoding = serialized_input.is_metacube_encoded() ?
+                               Input::INPUT_ENCODING_METACUBE :
+                               Input::INPUT_ENCODING_RAW;
+                       InputKey key(serialized_input.url(), src_encoding);
+                       inputs.insert(make_pair(key, iwr));
                } 
 
                // Deserialize the acceptors.
                for (int i = 0; i < loaded_state.acceptors_size(); ++i) {
+                       sockaddr_in6 sin6 = extract_address_from_acceptor_proto(loaded_state.acceptors(i));
                        deserialized_acceptors.insert(make_pair(
-                               loaded_state.acceptors(i).port(),
+                               sin6,
                                new Acceptor(loaded_state.acceptors(i))));
                }
 
                log(INFO, "Deserialization done.");
        }
 
-       // Find all streams in the configuration file, and create them.
-       create_streams(config, deserialized_stream_ids, &deserialized_inputs);
-
-       vector<Acceptor *> acceptors = create_acceptors(config, &deserialized_acceptors);
-       vector<Input *> inputs = create_inputs(config, &deserialized_inputs);
+       // Add any new inputs coming from the config.
+       create_config_inputs(config, &inputs);
        
-       // All deserialized inputs should now have been taken care of, one way or the other.
-       assert(deserialized_inputs.empty());
+       // Find all streams in the configuration file, create them, and connect to the inputs.
+       create_streams(config, deserialized_urls, &inputs);
+       vector<Acceptor *> acceptors = create_acceptors(config, &deserialized_acceptors);
+
+       // Convert old-style timestamps to new-style timestamps for all clients;
+       // this simplifies the sort below.
+       {
+               timespec now_monotonic;
+               if (clock_gettime(CLOCK_MONOTONIC_COARSE, &now_monotonic) == -1) {
+                       log(ERROR, "clock_gettime(CLOCK_MONOTONIC_COARSE) failed.");
+                       exit(1);
+               }
+               long delta_sec = now_monotonic.tv_sec - time(NULL);
+
+               for (int i = 0; i < loaded_state.clients_size(); ++i) {
+                       ClientProto* client = loaded_state.mutable_clients(i);
+                       if (client->has_connect_time_old()) {
+                               client->set_connect_time_sec(client->connect_time_old() + delta_sec);
+                               client->set_connect_time_nsec(now_monotonic.tv_nsec);
+                               client->clear_connect_time_old();
+                       }
+               }
+       }
        
        // Put back the existing clients. It doesn't matter which server we
-       // allocate them to, so just do round-robin. However, we need to add
-       // them after the mark pools have been set up.
+       // allocate them to, so just do round-robin. However, we need to sort them
+       // by connection time first, since add_client_serialized() expects that.
+       sort(loaded_state.mutable_clients()->begin(),
+            loaded_state.mutable_clients()->end(),
+            OrderByConnectionTime());
        for (int i = 0; i < loaded_state.clients_size(); ++i) {
-               servers->add_client_from_serialized(loaded_state.clients(i));
+               if (deleted_urls.count(loaded_state.clients(i).url()) != 0) {
+                       safe_close(loaded_state.clients(i).sock());
+               } else {
+                       servers->add_client_from_serialized(loaded_state.clients(i));
+               }
        }
        
        servers->run();
 
+       // Now delete all inputs that are longer in use, and start the others.
+       for (multimap<InputKey, InputWithRefcount>::iterator input_it = inputs.begin();
+            input_it != inputs.end(); ) {
+               if (input_it->second.refcount == 0) {
+                       if (input_it->first.second == Input::INPUT_ENCODING_RAW) {
+                               log(WARNING, "Raw input '%s' no longer in use, closing.",
+                                   input_it->first.first.c_str());
+                       } else {
+                               assert(input_it->first.second == Input::INPUT_ENCODING_METACUBE);
+                               log(WARNING, "Metacube input '%s' no longer in use, closing.",
+                                   input_it->first.first.c_str());
+                       }
+                       input_it->second.input->close_socket();
+                       delete input_it->second.input;
+                       inputs.erase(input_it++);
+               } else {
+                       input_it->second.input->run();
+                       ++input_it;
+               }
+       }
+
        // Start writing statistics.
        StatsThread *stats_thread = NULL;
        if (!config.stats_file.empty()) {
@@ -376,32 +543,61 @@ start:
                stats_thread->run();
        }
 
-       struct timeval server_start;
-       gettimeofday(&server_start, NULL);
+       InputStatsThread *input_stats_thread = NULL;
+       if (!config.input_stats_file.empty()) {
+               vector<Input*> inputs_no_refcount;
+               for (multimap<InputKey, InputWithRefcount>::iterator input_it = inputs.begin();
+                    input_it != inputs.end(); ++input_it) {
+                       inputs_no_refcount.push_back(input_it->second.input);
+               }
+
+               input_stats_thread = new InputStatsThread(config.input_stats_file, config.input_stats_interval, inputs_no_refcount);
+               input_stats_thread->run();
+       }
+
+       timespec server_start;
+       int err = clock_gettime(CLOCK_MONOTONIC, &server_start);
+       assert(err != -1);
        if (state_fd != -1) {
                // Measure time from we started deserializing (below) to now, when basically everything
                // is up and running. This is, in other words, a conservative estimate of how long our
                // “glitch” period was, not counting of course reconnects if the configuration changed.
                double glitch_time = server_start.tv_sec - serialize_start.tv_sec +
-                       1e-6 * (server_start.tv_usec - serialize_start.tv_usec);
+                       1e-9 * (server_start.tv_nsec - serialize_start.tv_nsec);
                log(INFO, "Re-exec happened in approx. %.0f ms.", glitch_time * 1000.0);
        }
 
+       sd_notify(0, "READY=1");
+
        while (!hupped) {
                usleep(100000);
        }
 
+       if (stopped) {
+               sd_notify(0, "STOPPING=1");
+       } else {
+               sd_notify(0, "RELOADING=1");
+       }
+
        // OK, we've been HUPed. Time to shut down everything, serialize, and re-exec.
-       gettimeofday(&serialize_start, NULL);
+       err = clock_gettime(CLOCK_MONOTONIC, &serialize_start);
+       assert(err != -1);
 
+       if (input_stats_thread != NULL) {
+               input_stats_thread->stop();
+               delete input_stats_thread;
+       }
        if (stats_thread != NULL) {
                stats_thread->stop();
+               delete stats_thread;
        }
        for (size_t i = 0; i < acceptors.size(); ++i) {
                acceptors[i]->stop();
        }
-       for (size_t i = 0; i < inputs.size(); ++i) {
-               inputs[i]->stop();
+       for (multimap<InputKey, InputWithRefcount>::iterator input_it = inputs.begin();
+            input_it != inputs.end();
+            ++input_it) {
+               input_it->second.input->stop();
        }
        servers->stop();
 
@@ -420,6 +616,9 @@ start:
                }
        }
        delete servers;
+
+       access_log->stop();
+       delete access_log;
        shut_down_logging();
 
        if (stopped) {