X-Git-Url: https://git.sesse.net/?p=cubemap;a=blobdiff_plain;f=httpinput.cpp;h=2ad9746e7bf2f7cd4c84f8629c26092f22668561;hp=78e73a10eb9afeb5724ebbaa4efa6b0d9cb36f57;hb=b10d63c534fda113e65e24d252e509e616067ef9;hpb=c1bfe37ff48881cfd44d4bf2952e9f9a1cdabb12 diff --git a/httpinput.cpp b/httpinput.cpp index 78e73a1..2ad9746 100644 --- a/httpinput.cpp +++ b/httpinput.cpp @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -50,13 +51,20 @@ HTTPInput::HTTPInput(const string &url, Input::Encoding encoding) url(url), encoding(encoding), has_metacube_header(false), - sock(-1) + sock(-1), + num_connection_attempts(0), + suppress_logging(false) { pthread_mutex_init(&stats_mutex, NULL); stats.url = url; stats.bytes_received = 0; stats.data_bytes_received = 0; + stats.metadata_bytes_received = 0; stats.connect_time = -1; + stats.latency_sec = HUGE_VAL; + + last_verbose_connection.tv_sec = -3600; + last_verbose_connection.tv_nsec = 0; } HTTPInput::HTTPInput(const InputProto &serialized) @@ -71,7 +79,9 @@ HTTPInput::HTTPInput(const InputProto &serialized) http_header(serialized.http_header()), stream_header(serialized.stream_header()), has_metacube_header(serialized.has_metacube_header()), - sock(serialized.sock()) + sock(serialized.sock()), + num_connection_attempts(0), + suppress_logging(false) { pending_data.resize(serialized.pending_data().size()); memcpy(&pending_data[0], serialized.pending_data().data(), serialized.pending_data().size()); @@ -83,11 +93,20 @@ HTTPInput::HTTPInput(const InputProto &serialized) stats.url = url; stats.bytes_received = serialized.bytes_received(); stats.data_bytes_received = serialized.data_bytes_received(); + stats.metadata_bytes_received = serialized.metadata_bytes_received(); if (serialized.has_connect_time()) { stats.connect_time = serialized.connect_time(); } else { stats.connect_time = time(NULL); } + if (serialized.has_latency_sec()) { + stats.latency_sec = serialized.latency_sec(); + } else { + stats.latency_sec = HUGE_VAL; + } + + last_verbose_connection.tv_sec = -3600; + last_verbose_connection.tv_nsec = 0; } void HTTPInput::close_socket() @@ -116,6 +135,9 @@ InputProto HTTPInput::serialize() const serialized.set_sock(sock); serialized.set_bytes_received(stats.bytes_received); serialized.set_data_bytes_received(stats.data_bytes_received); + if (isfinite(stats.latency_sec)) { + serialized.set_latency_sec(stats.latency_sec); + } serialized.set_connect_time(stats.connect_time); if (encoding == Input::INPUT_ENCODING_METACUBE) { serialized.set_is_metacube_encoded(true); @@ -131,8 +153,10 @@ int HTTPInput::lookup_and_connect(const string &host, const string &port) addrinfo *ai; int err = getaddrinfo(host.c_str(), port.c_str(), NULL, &ai); if (err != 0) { - log(WARNING, "[%s] Lookup of '%s' failed (%s).", - url.c_str(), host.c_str(), gai_strerror(err)); + if (!suppress_logging) { + log(WARNING, "[%s] Lookup of '%s' failed (%s).", + url.c_str(), host.c_str(), gai_strerror(err)); + } return -1; } @@ -200,8 +224,10 @@ int HTTPInput::lookup_and_connect(const string &host, const string &port) } // Give the last one as error. - log(WARNING, "[%s] Connect to '%s' failed (%s)", - url.c_str(), host.c_str(), strerror(errno)); + if (!suppress_logging) { + log(WARNING, "[%s] Connect to '%s' failed (%s)", + url.c_str(), host.c_str(), strerror(errno)); + } freeaddrinfo(base_ai); return -1; } @@ -210,21 +236,27 @@ bool HTTPInput::parse_response(const string &request) { vector lines = split_lines(response); if (lines.empty()) { - log(WARNING, "[%s] Empty HTTP response from input.", url.c_str()); + if (!suppress_logging) { + log(WARNING, "[%s] Empty HTTP response from input.", url.c_str()); + } return false; } vector first_line_tokens = split_tokens(lines[0]); if (first_line_tokens.size() < 2) { - log(WARNING, "[%s] Malformed response line '%s' from input.", - url.c_str(), lines[0].c_str()); + if (!suppress_logging) { + log(WARNING, "[%s] Malformed response line '%s' from input.", + url.c_str(), lines[0].c_str()); + } return false; } int response = atoi(first_line_tokens[1].c_str()); if (response != 200) { - log(WARNING, "[%s] Non-200 response '%s' from input.", - url.c_str(), lines[0].c_str()); + if (!suppress_logging) { + log(WARNING, "[%s] Non-200 response '%s' from input.", + url.c_str(), lines[0].c_str()); + } return false; } @@ -296,7 +328,9 @@ void HTTPInput::do_work() timespec elapsed = clock_diff(last_activity, now); if (elapsed.tv_sec >= timeout_secs) { // Timeout! - log(ERROR, "[%s] Timeout after %d seconds, closing.", url.c_str(), elapsed.tv_sec); + if (!suppress_logging) { + log(ERROR, "[%s] Timeout after %d seconds, closing.", url.c_str(), elapsed.tv_sec); + } state = CLOSING_SOCKET; continue; } @@ -331,7 +365,9 @@ void HTTPInput::do_work() { string protocol, user; // Thrown away. if (!parse_url(url, &protocol, &user, &host, &port, &path)) { - log(WARNING, "[%s] Failed to parse URL '%s'", url.c_str(), url.c_str()); + if (!suppress_logging) { + log(WARNING, "[%s] Failed to parse URL '%s'", url.c_str(), url.c_str()); + } break; } @@ -343,6 +379,24 @@ void HTTPInput::do_work() } } + if (suppress_logging) { + // See if there's more than one minute since last time we made a connection + // with logging enabled. If so, turn it on again. + timespec now; + int err = clock_gettime(CLOCK_MONOTONIC_COARSE, &now); + assert(err != -1); + + double elapsed = now.tv_sec - last_verbose_connection.tv_sec + + 1e-9 * (now.tv_nsec - last_verbose_connection.tv_nsec); + if (elapsed > 60.0) { + suppress_logging = false; + } + } + if (!suppress_logging) { + int err = clock_gettime(CLOCK_MONOTONIC_COARSE, &last_verbose_connection); + assert(err != -1); + } + ++num_connection_attempts; sock = lookup_and_connect(host, port); if (sock != -1) { // Yay, successful connect. Try to set it as nonblocking. @@ -399,8 +453,10 @@ void HTTPInput::do_work() if (ret == 0) { // This really shouldn't happen... - log(ERROR, "[%s] Socket unexpectedly closed while reading header", - url.c_str()); + if (!suppress_logging) { + log(ERROR, "[%s] Socket unexpectedly closed while reading header", + url.c_str()); + } state = CLOSING_SOCKET; continue; } @@ -408,7 +464,9 @@ void HTTPInput::do_work() RequestParseStatus status = wait_for_double_newline(&response, buf, ret); if (status == RP_OUT_OF_SPACE) { - log(WARNING, "[%s] Server sent overlong HTTP response!", url.c_str()); + if (!suppress_logging) { + log(WARNING, "[%s] Server sent overlong HTTP response!", url.c_str()); + } state = CLOSING_SOCKET; continue; } else if (status == RP_NOT_FINISHED_YET) { @@ -435,13 +493,15 @@ void HTTPInput::do_work() process_data(&extra_data[0], extra_data.size()); } - if (encoding == Input::INPUT_ENCODING_RAW) { - log(INFO, "[%s] Connected to '%s', receiving raw data.", - url.c_str(), url.c_str()); - } else { - assert(encoding == Input::INPUT_ENCODING_METACUBE); - log(INFO, "[%s] Connected to '%s', receiving data.", - url.c_str(), url.c_str()); + if (!suppress_logging) { + if (encoding == Input::INPUT_ENCODING_RAW) { + log(INFO, "[%s] Connected to '%s', receiving raw data.", + url.c_str(), url.c_str()); + } else { + assert(encoding == Input::INPUT_ENCODING_METACUBE); + log(INFO, "[%s] Connected to '%s', receiving data.", + url.c_str(), url.c_str()); + } } state = RECEIVING_DATA; break; @@ -462,12 +522,28 @@ void HTTPInput::do_work() if (ret == 0) { // This really shouldn't happen... - log(ERROR, "[%s] Socket unexpectedly closed while reading data", - url.c_str()); + if (!suppress_logging) { + log(ERROR, "[%s] Socket unexpectedly closed while reading data", + url.c_str()); + } state = CLOSING_SOCKET; continue; } + num_connection_attempts = 0; // Reset, since we have a successful read. + if (suppress_logging) { + // This was suppressed earlier, so print it out now. + if (encoding == Input::INPUT_ENCODING_RAW) { + log(INFO, "[%s] Connected to '%s', receiving raw data.", + url.c_str(), url.c_str()); + } else { + assert(encoding == Input::INPUT_ENCODING_METACUBE); + log(INFO, "[%s] Connected to '%s', receiving data.", + url.c_str(), url.c_str()); + } + suppress_logging = false; + } + process_data(buf, ret); break; } @@ -484,7 +560,15 @@ void HTTPInput::do_work() // or the connection just got closed. // The earlier steps have already given the error message, if any. if (state == NOT_CONNECTED && !should_stop()) { - log(INFO, "[%s] Waiting 0.2 second and restarting...", url.c_str()); + if (!suppress_logging) { + log(INFO, "[%s] Waiting 0.2 seconds and restarting...", url.c_str()); + } + + if (num_connection_attempts >= 3 && !suppress_logging) { + log(INFO, "[%s] %d failed connection attempts, suppressing logging for one minute.", + url.c_str(), num_connection_attempts); + suppress_logging = true; + } timespec timeout_ts; timeout_ts.tv_sec = 0; timeout_ts.tv_nsec = 200000000; @@ -570,21 +654,32 @@ void HTTPInput::process_data(char *ptr, size_t bytes) return; } - // Send this block on to the servers. - { - MutexLock lock(&stats_mutex); - stats.data_bytes_received += size; - } - char *inner_data = pending_data.data() + sizeof(metacube2_block_header); - if (flags & METACUBE_FLAGS_HEADER) { - stream_header = string(inner_data, inner_data + size); + // See if this is a metadata block. If so, we don't want to send it on, + // but rather process it ourselves. + // TODO: Keep metadata when sending on to other Metacube users. + if (flags & METACUBE_FLAGS_METADATA) { + { + MutexLock lock(&stats_mutex); + stats.metadata_bytes_received += size; + } + process_metacube_metadata_block(hdr, pending_data.data() + sizeof(hdr), size); + } else { + // Send this block on to the servers. + { + MutexLock lock(&stats_mutex); + stats.data_bytes_received += size; + } + char *inner_data = pending_data.data() + sizeof(metacube2_block_header); + if (flags & METACUBE_FLAGS_HEADER) { + stream_header = string(inner_data, inner_data + size); + for (size_t i = 0; i < stream_indices.size(); ++i) { + servers->set_header(stream_indices[i], http_header, stream_header); + } + } for (size_t i = 0; i < stream_indices.size(); ++i) { - servers->set_header(stream_indices[i], http_header, stream_header); + servers->add_data(stream_indices[i], inner_data, size, flags); } } - for (size_t i = 0; i < stream_indices.size(); ++i) { - servers->add_data(stream_indices[i], inner_data, size, flags); - } // Consume the block. This isn't the most efficient way of dealing with things // should we have many blocks, but these routines don't need to be too efficient @@ -616,3 +711,35 @@ InputStats HTTPInput::get_stats() const MutexLock lock(&stats_mutex); return stats; } + +void HTTPInput::process_metacube_metadata_block(const metacube2_block_header &hdr, const char *payload, uint32_t payload_size) +{ + if (payload_size < sizeof(uint64_t)) { + log(WARNING, "[%s] Undersized Metacube metadata block (%d bytes); corrupted header?", + url.c_str(), payload_size); + return; + } + + uint64_t type = be64toh(*(const uint64_t *)payload); + if (type != METACUBE_METADATA_TYPE_ENCODER_TIMESTAMP) { + // Unknown metadata block, ignore. + return; + } + + timespec now; + clock_gettime(CLOCK_REALTIME, &now); + + const metacube2_timestamp_packet *pkt = (const metacube2_timestamp_packet *)payload; + if (payload_size != sizeof(*pkt)) { + log(WARNING, "[%s] Metacube timestamp block of wrong size (%d bytes); ignoring.", + url.c_str(), payload_size); + return; + } + + double elapsed = now.tv_sec - be64toh(pkt->tv_sec) + + 1e-9 * (now.tv_nsec - long(be64toh(pkt->tv_nsec))); + { + MutexLock lock(&stats_mutex); + stats.latency_sec = elapsed; + } +}