X-Git-Url: https://git.sesse.net/?p=cubemap;a=blobdiff_plain;f=util.cpp;h=5659bed0802bd1062644f79cc49b80234a9698da;hp=8159e3821ccb1071efa8801ae8a63b90b65d2db4;hb=8a2935dc58b00839acc493b4d146042d22a9793c;hpb=8cc780cf37063ce29f13380976a54dd8302fe3a9

diff --git a/util.cpp b/util.cpp
index 8159e38..5659bed 100644
--- a/util.cpp
+++ b/util.cpp
@@ -2,25 +2,37 @@
 #include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <fcntl.h>
+#include <sys/stat.h>
 #include <unistd.h>
 
 #include "log.h"
 #include "util.h"
 
+#ifndef O_TMPFILE
+#define __O_TMPFILE 020000000
+#define O_TMPFILE (__O_TMPFILE | O_DIRECTORY)
+#endif
+
 using namespace std;
 
 int make_tempfile(const std::string &contents)
 {
 	char filename[] = "/tmp/cubemap.XXXXXX";
-	int fd = mkstemp(filename);
+	int fd = open(filename, O_RDWR | O_TMPFILE, 0600);
 	if (fd == -1) {
-		log_perror("mkstemp");
-		return -1;
-	}
+		mode_t old_umask = umask(077);
+		fd = mkstemp(filename);
+		if (fd == -1) {
+			log_perror("mkstemp");
+			return -1;
+		}
+		umask(old_umask);
 
-	if (unlink(filename) == -1) {
-		log_perror("unlink");
-		// Can still continue;
+		if (unlink(filename) == -1) {
+			log_perror("unlink");
+			// Can still continue.
+		}
 	}
 
 	const char *ptr = contents.data();
@@ -29,7 +41,7 @@ int make_tempfile(const std::string &contents)
 		ssize_t ret = write(fd, ptr, to_write);
 		if (ret == -1) {
 			log_perror("write");
-			close(fd);
+			safe_close(fd);
 			return -1;
 		}
 
@@ -40,24 +52,28 @@ int make_tempfile(const std::string &contents)
 	return fd;
 }
 
+bool read_tempfile_and_close(int fd, std::string *contents)
+{
+	bool ok = read_tempfile(fd, contents);
+	safe_close(fd);  // Implicitly deletes the file.
+	return ok;
+}
+
 bool read_tempfile(int fd, std::string *contents)
 {
-	bool ok = true;
 	ssize_t ret, has_read;
 
 	off_t len = lseek(fd, 0, SEEK_END);
 	if (len == -1) {
 		log_perror("lseek");
-		ok = false;
-		goto done;
+		return false;
 	}
 
 	contents->resize(len);
 
 	if (lseek(fd, 0, SEEK_SET) == -1) {
 		log_perror("lseek");
-		ok = false;
-		goto done;
+		return false;
 	}
 
 	has_read = 0;
@@ -65,26 +81,28 @@ bool read_tempfile(int fd, std::string *contents)
 		ret = read(fd, &((*contents)[has_read]), len - has_read);
 		if (ret == -1) {
 			log_perror("read");
-			ok = false;
-			goto done;
+			return false;
 		}
 		if (ret == 0) {
 			log(ERROR, "Unexpected EOF!");
-			ok = false;
-			goto done;
+			return false;
 		}
 		has_read += ret;
 	}
 
-done:
+	return true;
+}
+
+int safe_close(int fd)
+{
+	int ret;
 	do {
-		ret = close(fd);  // Implicitly deletes the files.
+		ret = close(fd);
 	} while (ret == -1 && errno == EINTR);
-	
+
 	if (ret == -1) {
-		log_perror("close");
-		// Can still continue.
+		log_perror("close()");
 	}
 
-	return ok;
+	return ret;
 }