Check the return value of fclose() in config.cpp.

It's unclear to me exactly how this could fail for a read-only file,
but it's good practice nevertheless.

Found by Coverity Scan.

diff --git a/config.cpp b/config.cpp
index 4a3dfb3122a7061a65fb49d2ffbfcc36c3d9037d..f1b05c1821035819debc55d364c05189a774fed9 100644 (file)
--- a/config.cpp
+++ b/config.cpp
@@ -132,7 +132,10 @@ bool read_config(const string &filename, vector<ConfigLine> *lines)
                lines->push_back(line);
        }
 
                lines->push_back(line);
        }
 

-       fclose(fp);
+       if (fclose(fp) == EOF) {
+               log_perror(filename.c_str());
+               return false;
+       }

        return true;
 }
 
        return true;
 }