From: Steinar H. Gunderson <sgunderson@bigfoot.com>
Date: Sun, 7 Apr 2013 17:03:42 +0000 (+0200)
Subject: Handle streams coming and going from the configuration file across restarts.
X-Git-Tag: 1.0.0~185
X-Git-Url: https://git.sesse.net/?p=cubemap;a=commitdiff_plain;h=1db0474e2a914bfc31014c067d9af24f87037784

Handle streams coming and going from the configuration file across restarts.
---

diff --git a/cubemap.cpp b/cubemap.cpp
index b00ca64..d5cfa01 100644
--- a/cubemap.cpp
+++ b/cubemap.cpp
@@ -15,6 +15,7 @@
 #include <vector>
 #include <string>
 #include <map>
+#include <set>
 
 #include "metacube.h"
 #include "parse.h"
@@ -185,15 +186,16 @@ int main(int argc, char **argv)
 	servers = new ServerPool(num_servers);
 
 	int server_sock = -1, old_port = -1;
+	set<string> deserialized_stream_ids;
 	if (argc == 4 && strcmp(argv[2], "-state") == 0) {
 		fprintf(stderr, "Deserializing state from previous process... ");
 		int state_fd = atoi(argv[3]);
 		CubemapStateProto loaded_state = read_tempfile(state_fd);
 
 		// Deserialize the streams.
-		// TODO: Pick up new streams from the configuration file.
 		for (int i = 0; i < loaded_state.streams_size(); ++i) {
 			servers->add_stream_from_serialized(loaded_state.streams(i));
+			deserialized_stream_ids.insert(loaded_state.streams(i).stream_id());
 		}
 
 		// Put back the existing clients. It doesn't matter which server we
@@ -207,19 +209,33 @@ int main(int argc, char **argv)
 		old_port = loaded_state.port();
 
 		fprintf(stderr, "done.\n");
-	} else {
-		// Find all streams in the configuration file, and create them.
-		for (unsigned i = 0; i < config.size(); ++i) {
-			if (config[i].keyword != "stream") {
-				continue;
-			}
-			if (config[i].arguments.size() != 1) {
-				fprintf(stderr, "ERROR: 'stream' takes exactly one argument\n");
-				exit(1);
-			}
-			string stream_id = config[i].arguments[0];
+	}
+
+	// Find all streams in the configuration file, and create them.
+	set<string> expecting_stream_ids = deserialized_stream_ids;
+	for (unsigned i = 0; i < config.size(); ++i) {
+		if (config[i].keyword != "stream") {
+			continue;
+		}
+		if (config[i].arguments.size() != 1) {
+			fprintf(stderr, "ERROR: 'stream' takes exactly one argument\n");
+			exit(1);
+		}
+		string stream_id = config[i].arguments[0];
+		if (deserialized_stream_ids.count(stream_id) == 0) {
 			servers->add_stream(stream_id);
 		}
+		expecting_stream_ids.erase(stream_id);
+	}
+
+	// Warn about any servers we've lost.
+	// TODO: Make an option (delete=yes?) to actually shut down streams.
+	for (set<string>::const_iterator stream_it = expecting_stream_ids.begin();
+	     stream_it != expecting_stream_ids.end();
+	     ++stream_it) {
+		fprintf(stderr, "WARNING: stream '%s' disappeared from the configuration file.\n",
+			stream_it->c_str());
+		fprintf(stderr, "         It will not be deleted, but clients will not get any new inputs.\n");
 	}
 
 	// Open a new server socket if we do not already have one, or if we changed ports.