From 8a2935dc58b00839acc493b4d146042d22a9793c Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Fri, 25 Apr 2014 00:49:51 +0200 Subject: [PATCH] Set umask explicitly before calling mkstemp(). For the benefit of super-old glibc versions (pre-2.06). Found by Coverity Scan. --- util.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util.cpp b/util.cpp index dadeb37..5659bed 100644 --- a/util.cpp +++ b/util.cpp @@ -21,11 +21,13 @@ int make_tempfile(const std::string &contents) char filename[] = "/tmp/cubemap.XXXXXX"; int fd = open(filename, O_RDWR | O_TMPFILE, 0600); if (fd == -1) { + mode_t old_umask = umask(077); fd = mkstemp(filename); if (fd == -1) { log_perror("mkstemp"); return -1; } + umask(old_umask); if (unlink(filename) == -1) { log_perror("unlink"); -- 2.39.2