From 98b8cb22fe22f6a8b46a47cd5fa00dcf2bcd6fd5 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Fri, 25 Apr 2014 00:41:44 +0200 Subject: [PATCH] Check the return value of fclose() in config.cpp. It's unclear to me exactly how this could fail for a read-only file, but it's good practice nevertheless. Found by Coverity Scan. --- config.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/config.cpp b/config.cpp index 4a3dfb3..f1b05c1 100644 --- a/config.cpp +++ b/config.cpp @@ -132,7 +132,10 @@ bool read_config(const string &filename, vector *lines) lines->push_back(line); } - fclose(fp); + if (fclose(fp) == EOF) { + log_perror(filename.c_str()); + return false; + } return true; } -- 2.39.2