From c2be800fa43dff8a3916d6bafaae0e8507b97560 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Fri, 19 Apr 2013 19:25:59 +0200 Subject: [PATCH 1/1] Add a missing log_perror() on close() failure (cosmetic issue). Found by Coverity Scan. --- util.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util.cpp b/util.cpp index 45bf5b5..d6d39f2 100644 --- a/util.cpp +++ b/util.cpp @@ -33,7 +33,9 @@ int make_tempfile(const std::string &contents) ssize_t ret = write(fd, ptr, to_write); if (ret == -1) { log_perror("write"); - close(fd); + if (close(fd) == -1) { + log_perror("close"); + } return -1; } -- 2.39.2