From 5d4e8497fc4b3681f3024bf8fc8bf4e338fbbdc4 Mon Sep 17 00:00:00 2001 From: Vincent PINON Date: Sat, 21 Dec 2013 07:24:45 +0100 Subject: [PATCH] coverity fix --- src/mainwindow.cpp | 7 ++++--- src/markerdialog.cpp | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp index e0d461be..517e321e 100644 --- a/src/mainwindow.cpp +++ b/src/mainwindow.cpp @@ -3897,8 +3897,7 @@ int MainWindow::getNewStuff(const QString &configFile) KNS3::Entry::List entries; #if KDE_IS_VERSION(4,3,80) QPointer dialog = new KNS3::DownloadDialog(configFile); - dialog->exec(); - if (dialog) entries = dialog->changedEntries(); + if (dialog->exec()) entries = dialog->changedEntries(); foreach(const KNS3::Entry & entry, entries) { if (entry.status() == KNS3::Entry::Installed) kDebug() << "// Installed files: " << entry.installedFiles(); @@ -4610,7 +4609,9 @@ void MainWindow::slotArchiveProject() QList list = m_projectList->documentClipList(); QDomDocument doc = m_activeDocument->xmlSceneList(m_projectMonitor->sceneList(), m_projectList->expandedFolders()); ArchiveWidget *d = new ArchiveWidget(m_activeDocument->url().fileName(), doc, list, m_activeTimeline->projectView()->extractTransitionsLumas(), this); - d->exec(); + if (d->exec()) { + m_messageLabel->setMessage(i18n("Archiving project"), OperationCompletedMessage); + } } diff --git a/src/markerdialog.cpp b/src/markerdialog.cpp index f86de6a7..fd1abcef 100644 --- a/src/markerdialog.cpp +++ b/src/markerdialog.cpp @@ -77,6 +77,7 @@ MarkerDialog::MarkerDialog(DocClipBase *clip, const CommentedTime &t, const Time case SLIDESHOW: case PLAYLIST: connect(this, SIGNAL(updateThumb()), m_previewTimer, SLOT(start())); + break; case IMAGE: case TEXT: m_image = KThumb::getFrame(m_producer, m_in->getValue(), swidth, width, Kdenlive::DefaultThumbHeight); @@ -86,6 +87,7 @@ MarkerDialog::MarkerDialog(DocClipBase *clip, const CommentedTime &t, const Time colour = colour.replace(0, 2, "#"); p.fill(QColor(colour.left(7))); break; + //UNKNOWN, AUDIO, VIRTUAL: default: p.fill(Qt::black); } -- 2.39.2