From 9b507272f9fcd3f0cdc96badcef9ba66da2a34e4 Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Sun, 12 May 2013 11:46:40 +0200 Subject: [PATCH] Use const'ref --- plugins/sampleplugin/sampleplugin.cpp | 2 +- plugins/sampleplugin/sampleplugin.h | 2 +- renderer/renderjob.cpp | 4 ++-- src/beziercurve/beziersplineeditor.cpp | 5 ++--- src/beziercurve/beziersplineeditor.h | 2 +- src/beziercurve/beziersplinewidget.cpp | 2 +- src/beziercurve/beziersplinewidget.h | 2 +- src/commands/addclipcutcommand.cpp | 2 +- src/commands/addclipcutcommand.h | 2 +- src/commands/addeffectcommand.cpp | 2 +- src/commands/addeffectcommand.h | 2 +- src/commands/addfoldercommand.cpp | 2 +- src/commands/addfoldercommand.h | 2 +- src/commands/addtimelineclipcommand.cpp | 2 +- src/commands/addtimelineclipcommand.h | 2 +- src/commands/addtransitioncommand.cpp | 2 +- src/commands/addtransitioncommand.h | 2 +- src/commands/changeeffectstatecommand.cpp | 2 +- src/commands/changeeffectstatecommand.h | 2 +- src/commands/configtrackscommand.cpp | 2 +- src/commands/configtrackscommand.h | 2 +- src/commands/editclipcommand.cpp | 2 +- src/commands/editclipcommand.h | 2 +- src/commands/editclipcutcommand.cpp | 2 +- src/commands/editclipcutcommand.h | 2 +- src/commands/editeffectcommand.cpp | 2 +- src/commands/editeffectcommand.h | 2 +- src/commands/editfoldercommand.cpp | 2 +- src/commands/editfoldercommand.h | 2 +- src/commands/edittransitioncommand.cpp | 2 +- src/commands/edittransitioncommand.h | 2 +- src/commands/groupclipscommand.cpp | 2 +- src/commands/groupclipscommand.h | 2 +- src/commands/insertspacecommand.cpp | 2 +- src/commands/insertspacecommand.h | 2 +- src/commands/moveeffectcommand.cpp | 2 +- src/commands/moveeffectcommand.h | 2 +- src/commands/movegroupcommand.cpp | 2 +- src/commands/movegroupcommand.h | 2 +- src/commands/razorclipcommand.cpp | 2 +- src/commands/razorclipcommand.h | 2 +- src/interfaces.h | 2 +- 42 files changed, 44 insertions(+), 45 deletions(-) diff --git a/plugins/sampleplugin/sampleplugin.cpp b/plugins/sampleplugin/sampleplugin.cpp index d40395c0..de754d6c 100644 --- a/plugins/sampleplugin/sampleplugin.cpp +++ b/plugins/sampleplugin/sampleplugin.cpp @@ -32,7 +32,7 @@ #include #include -QStringList SamplePlugin::generators(const QStringList producers) const +QStringList SamplePlugin::generators(const QStringList &producers) const { QStringList result; if (producers.contains("pango")) result << i18n("Countdown"); diff --git a/plugins/sampleplugin/sampleplugin.h b/plugins/sampleplugin/sampleplugin.h index 6c1667b1..9f01f5e7 100644 --- a/plugins/sampleplugin/sampleplugin.h +++ b/plugins/sampleplugin/sampleplugin.h @@ -34,7 +34,7 @@ class SamplePlugin : public QObject, public ClipGenerator Q_INTERFACES(ClipGenerator) public: - QStringList generators(const QStringList producers = QStringList()) const; + QStringList generators(const QStringList &producers = QStringList()) const; KUrl generatedClip(const QString &renderer, const QString &generator, const KUrl &projectFolder, const QStringList &lumaNames, const QStringList &lumaFiles, const double fps, const int width, const int height); }; diff --git a/renderer/renderjob.cpp b/renderer/renderjob.cpp index b8b0704b..60ba1df6 100644 --- a/renderer/renderjob.cpp +++ b/renderer/renderjob.cpp @@ -32,7 +32,7 @@ class SleepThread : QThread { public: - virtual void run() {}; + virtual void run() {} static void msleep(unsigned long msecs) { QThread::msleep(msecs); } @@ -118,7 +118,7 @@ RenderJob::RenderJob(bool erase, bool usekuiserver, int pid, const QString& rend RenderJob::~RenderJob() { - if (m_renderProcess) delete m_renderProcess; + delete m_renderProcess; if (m_enablelog) { m_logfile.close(); } diff --git a/src/beziercurve/beziersplineeditor.cpp b/src/beziercurve/beziersplineeditor.cpp index eef766a8..89bcdd1e 100644 --- a/src/beziercurve/beziersplineeditor.cpp +++ b/src/beziercurve/beziersplineeditor.cpp @@ -45,11 +45,10 @@ BezierSplineEditor::BezierSplineEditor(QWidget* parent) : BezierSplineEditor::~BezierSplineEditor() { - if (m_pixmapCache) - delete m_pixmapCache; + delete m_pixmapCache; } -CubicBezierSpline BezierSplineEditor::spline() +CubicBezierSpline BezierSplineEditor::spline() const { return m_spline; } diff --git a/src/beziercurve/beziersplineeditor.h b/src/beziercurve/beziersplineeditor.h index 19b09127..e601e8ed 100644 --- a/src/beziercurve/beziersplineeditor.h +++ b/src/beziercurve/beziersplineeditor.h @@ -32,7 +32,7 @@ public: BezierSplineEditor(QWidget* parent = 0); virtual ~BezierSplineEditor(); - CubicBezierSpline spline(); + CubicBezierSpline spline() const; void setSpline(const CubicBezierSpline &spline); /** @brief Returns the selected point or else BPoint. */ diff --git a/src/beziercurve/beziersplinewidget.cpp b/src/beziercurve/beziersplinewidget.cpp index 3fd59643..e4d5a322 100644 --- a/src/beziercurve/beziersplinewidget.cpp +++ b/src/beziercurve/beziersplinewidget.cpp @@ -97,7 +97,7 @@ BezierSplineWidget::BezierSplineWidget(const QString& spline, QWidget* parent) : m_ui.buttonShowAllHandles->setChecked(KdenliveSettings::bezier_showallhandles()); } -QString BezierSplineWidget::spline() +QString BezierSplineWidget::spline() const { return m_edit.spline().toString(); } diff --git a/src/beziercurve/beziersplinewidget.h b/src/beziercurve/beziersplinewidget.h index cddefef0..6a224c3e 100644 --- a/src/beziercurve/beziersplinewidget.h +++ b/src/beziercurve/beziersplinewidget.h @@ -37,7 +37,7 @@ public: explicit BezierSplineWidget(const QString &spline, QWidget* parent = 0); /** @brief Returns the current spline. */ - QString spline(); + QString spline() const; /** The curvemodes refer to the usage of the spline. * As this widget is currently only used for frei0r.curves the modes are the channels this filter accepts. */ diff --git a/src/commands/addclipcutcommand.cpp b/src/commands/addclipcutcommand.cpp index d5bf0829..09920054 100644 --- a/src/commands/addclipcutcommand.cpp +++ b/src/commands/addclipcutcommand.cpp @@ -22,7 +22,7 @@ #include -AddClipCutCommand::AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString desc, bool newItem, bool remove, QUndoCommand * parent) : +AddClipCutCommand::AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString& desc, bool newItem, bool remove, QUndoCommand * parent) : QUndoCommand(parent), m_list(list), m_id(id), diff --git a/src/commands/addclipcutcommand.h b/src/commands/addclipcutcommand.h index 96f3239e..3fc21264 100644 --- a/src/commands/addclipcutcommand.h +++ b/src/commands/addclipcutcommand.h @@ -29,7 +29,7 @@ class ProjectList; class AddClipCutCommand : public QUndoCommand { public: - AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString desc, bool newItem, bool remove, QUndoCommand * parent = 0); + AddClipCutCommand(ProjectList *list, const QString &id, int in, int out, const QString &desc, bool newItem, bool remove, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/addeffectcommand.cpp b/src/commands/addeffectcommand.cpp index 5e09957c..e720caa1 100644 --- a/src/commands/addeffectcommand.cpp +++ b/src/commands/addeffectcommand.cpp @@ -23,7 +23,7 @@ #include -AddEffectCommand::AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement effect, bool doIt, QUndoCommand * parent) : +AddEffectCommand::AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &effect, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_track(track), diff --git a/src/commands/addeffectcommand.h b/src/commands/addeffectcommand.h index f929dc57..5856a05a 100644 --- a/src/commands/addeffectcommand.h +++ b/src/commands/addeffectcommand.h @@ -31,7 +31,7 @@ class CustomTrackView; class AddEffectCommand : public QUndoCommand { public: - AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement effect, bool doIt, QUndoCommand * parent = 0); + AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &effect, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/addfoldercommand.cpp b/src/commands/addfoldercommand.cpp index b5146d96..392a666d 100644 --- a/src/commands/addfoldercommand.cpp +++ b/src/commands/addfoldercommand.cpp @@ -23,7 +23,7 @@ #include -AddFolderCommand::AddFolderCommand(ProjectList *view, const QString folderName, const QString &clipId, bool doIt, QUndoCommand *parent) : +AddFolderCommand::AddFolderCommand(ProjectList *view, const QString &folderName, const QString &clipId, bool doIt, QUndoCommand *parent) : QUndoCommand(parent), m_view(view), m_name(folderName), diff --git a/src/commands/addfoldercommand.h b/src/commands/addfoldercommand.h index 3028a181..c9e52c51 100644 --- a/src/commands/addfoldercommand.h +++ b/src/commands/addfoldercommand.h @@ -28,7 +28,7 @@ class ProjectList; class AddFolderCommand : public QUndoCommand { public: - AddFolderCommand(ProjectList *view, const QString folderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0); + AddFolderCommand(ProjectList *view, const QString &folderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/addtimelineclipcommand.cpp b/src/commands/addtimelineclipcommand.cpp index 2f309efc..f6befebf 100644 --- a/src/commands/addtimelineclipcommand.cpp +++ b/src/commands/addtimelineclipcommand.cpp @@ -23,7 +23,7 @@ #include -AddTimelineClipCommand::AddTimelineClipCommand(CustomTrackView *view, QDomElement xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent) : +AddTimelineClipCommand::AddTimelineClipCommand(CustomTrackView *view, const QDomElement &xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_clipInfo(info), diff --git a/src/commands/addtimelineclipcommand.h b/src/commands/addtimelineclipcommand.h index 7058473b..7d508c39 100644 --- a/src/commands/addtimelineclipcommand.h +++ b/src/commands/addtimelineclipcommand.h @@ -34,7 +34,7 @@ class CustomTrackView; class AddTimelineClipCommand : public QUndoCommand { public: - AddTimelineClipCommand(CustomTrackView *view, QDomElement xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent = 0); + AddTimelineClipCommand(CustomTrackView *view, const QDomElement &xml, const QString &clipId, ItemInfo info, EffectsList effects, bool overwrite, bool push, bool doIt, bool doRemove, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/addtransitioncommand.cpp b/src/commands/addtransitioncommand.cpp index c8acc6dc..22912c32 100644 --- a/src/commands/addtransitioncommand.cpp +++ b/src/commands/addtransitioncommand.cpp @@ -21,7 +21,7 @@ #include -AddTransitionCommand::AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, QDomElement params, bool remove, bool doIt, QUndoCommand * parent) : +AddTransitionCommand::AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, const QDomElement ¶ms, bool remove, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_info(info), diff --git a/src/commands/addtransitioncommand.h b/src/commands/addtransitioncommand.h index be6f6a19..5a5a6f54 100644 --- a/src/commands/addtransitioncommand.h +++ b/src/commands/addtransitioncommand.h @@ -32,7 +32,7 @@ class CustomTrackView; class AddTransitionCommand : public QUndoCommand { public: - AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, QDomElement params, bool remove, bool doIt, QUndoCommand * parent = 0); + AddTransitionCommand(CustomTrackView *view, ItemInfo info, int transitiontrack, const QDomElement ¶ms, bool remove, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/changeeffectstatecommand.cpp b/src/commands/changeeffectstatecommand.cpp index ecc455ca..d62d02be 100644 --- a/src/commands/changeeffectstatecommand.cpp +++ b/src/commands/changeeffectstatecommand.cpp @@ -23,7 +23,7 @@ #include -ChangeEffectStateCommand::ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, QList effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent) : +ChangeEffectStateCommand::ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, const QList & effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent) : QUndoCommand(parent), m_view(view), m_track(track), diff --git a/src/commands/changeeffectstatecommand.h b/src/commands/changeeffectstatecommand.h index 563ef523..ee2c7d0b 100644 --- a/src/commands/changeeffectstatecommand.h +++ b/src/commands/changeeffectstatecommand.h @@ -31,7 +31,7 @@ class CustomTrackView; class ChangeEffectStateCommand : public QUndoCommand { public: - ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, QList effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0); + ChangeEffectStateCommand(CustomTrackView *view, const int track, GenTime pos, const QList & effectIndexes, bool disable, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/configtrackscommand.cpp b/src/commands/configtrackscommand.cpp index f034edde..bfa8b696 100644 --- a/src/commands/configtrackscommand.cpp +++ b/src/commands/configtrackscommand.cpp @@ -22,7 +22,7 @@ #include "customtrackview.h" -ConfigTracksCommand::ConfigTracksCommand(CustomTrackView* view, QList< TrackInfo > oldInfos, QList< TrackInfo > newInfos, QUndoCommand* parent) : +ConfigTracksCommand::ConfigTracksCommand(CustomTrackView* view, const QList &oldInfos, const QList &newInfos, QUndoCommand* parent) : QUndoCommand(parent), m_view(view), m_oldInfos(oldInfos), diff --git a/src/commands/configtrackscommand.h b/src/commands/configtrackscommand.h index 9c13c3e0..6dd0a2ed 100644 --- a/src/commands/configtrackscommand.h +++ b/src/commands/configtrackscommand.h @@ -31,7 +31,7 @@ class CustomTrackView; class ConfigTracksCommand : public QUndoCommand { public: - ConfigTracksCommand(CustomTrackView *view, QList oldInfos, QList newInfos, QUndoCommand * parent = 0); + ConfigTracksCommand(CustomTrackView *view, const QList &oldInfos, const QList &newInfos, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/editclipcommand.cpp b/src/commands/editclipcommand.cpp index d65acfc5..153cac3f 100644 --- a/src/commands/editclipcommand.cpp +++ b/src/commands/editclipcommand.cpp @@ -22,7 +22,7 @@ #include -EditClipCommand::EditClipCommand(ProjectList *list, const QString &id, QMap oldparams, QMap newparams, bool doIt, QUndoCommand * parent) : +EditClipCommand::EditClipCommand(ProjectList *list, const QString &id, const QMap &oldparams, const QMap &newparams, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_list(list), m_oldparams(oldparams), diff --git a/src/commands/editclipcommand.h b/src/commands/editclipcommand.h index 1f3afed3..423f6298 100644 --- a/src/commands/editclipcommand.h +++ b/src/commands/editclipcommand.h @@ -30,7 +30,7 @@ class ProjectList; class EditClipCommand : public QUndoCommand { public: - EditClipCommand(ProjectList *list, const QString &id, QMap oldparams, QMap newparams, bool doIt, QUndoCommand * parent = 0); + EditClipCommand(ProjectList *list, const QString &id, const QMap &oldparams, const QMap &newparams, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/editclipcutcommand.cpp b/src/commands/editclipcutcommand.cpp index b6708f81..2d0f92f1 100644 --- a/src/commands/editclipcutcommand.cpp +++ b/src/commands/editclipcutcommand.cpp @@ -22,7 +22,7 @@ #include -EditClipCutCommand::EditClipCutCommand(ProjectList *list, const QString &id, const QPoint oldZone, const QPoint newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent) : +EditClipCutCommand::EditClipCutCommand(ProjectList *list, const QString &id, const QPoint &oldZone, const QPoint &newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_list(list), m_id(id), diff --git a/src/commands/editclipcutcommand.h b/src/commands/editclipcutcommand.h index b8090aac..dbd2af98 100644 --- a/src/commands/editclipcutcommand.h +++ b/src/commands/editclipcutcommand.h @@ -31,7 +31,7 @@ class ProjectList; class EditClipCutCommand : public QUndoCommand { public: - EditClipCutCommand(ProjectList *list, const QString &id, const QPoint oldZone, const QPoint newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent = 0); + EditClipCutCommand(ProjectList *list, const QString &id, const QPoint &oldZone, const QPoint &newZone, const QString &oldComment, const QString &newComment, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/editeffectcommand.cpp b/src/commands/editeffectcommand.cpp index 10654c18..841e129f 100644 --- a/src/commands/editeffectcommand.cpp +++ b/src/commands/editeffectcommand.cpp @@ -23,7 +23,7 @@ #include -EditEffectCommand::EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent) : +EditEffectCommand::EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent) : QUndoCommand(parent), m_view(view), m_track(track), diff --git a/src/commands/editeffectcommand.h b/src/commands/editeffectcommand.h index 6129420e..2c7719ea 100644 --- a/src/commands/editeffectcommand.h +++ b/src/commands/editeffectcommand.h @@ -31,7 +31,7 @@ class CustomTrackView; class EditEffectCommand : public QUndoCommand { public: - EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0); + EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, int stackPos, bool refreshEffectStack, bool doIt, QUndoCommand *parent = 0); virtual int id() const; virtual bool mergeWith(const QUndoCommand * command); diff --git a/src/commands/editfoldercommand.cpp b/src/commands/editfoldercommand.cpp index 6dbcd7fc..1b569f16 100644 --- a/src/commands/editfoldercommand.cpp +++ b/src/commands/editfoldercommand.cpp @@ -23,7 +23,7 @@ #include -EditFolderCommand::EditFolderCommand(ProjectList *view, const QString newfolderName, const QString oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent) : +EditFolderCommand::EditFolderCommand(ProjectList *view, const QString &newfolderName, const QString &oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent) : QUndoCommand(parent), m_view(view), m_name(newfolderName), diff --git a/src/commands/editfoldercommand.h b/src/commands/editfoldercommand.h index 96e9a3f1..64429292 100644 --- a/src/commands/editfoldercommand.h +++ b/src/commands/editfoldercommand.h @@ -28,7 +28,7 @@ class ProjectList; class EditFolderCommand : public QUndoCommand { public: - EditFolderCommand(ProjectList *view, const QString newfolderName, const QString oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0); + EditFolderCommand(ProjectList *view, const QString &newfolderName, const QString &oldfolderName, const QString &clipId, bool doIt, QUndoCommand *parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/edittransitioncommand.cpp b/src/commands/edittransitioncommand.cpp index dd3afe7d..56ca9aec 100644 --- a/src/commands/edittransitioncommand.cpp +++ b/src/commands/edittransitioncommand.cpp @@ -20,7 +20,7 @@ #include -EditTransitionCommand::EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, bool doIt, QUndoCommand * parent) : +EditTransitionCommand::EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_track(track), diff --git a/src/commands/edittransitioncommand.h b/src/commands/edittransitioncommand.h index eb3e96bb..e331cd96 100644 --- a/src/commands/edittransitioncommand.h +++ b/src/commands/edittransitioncommand.h @@ -28,7 +28,7 @@ class CustomTrackView; class EditTransitionCommand : public QUndoCommand { public: - EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, bool doIt, QUndoCommand * parent = NULL); + EditTransitionCommand(CustomTrackView *view, const int track, GenTime pos, const QDomElement &oldeffect, const QDomElement &effect, bool doIt, QUndoCommand * parent = NULL); virtual int id() const; virtual bool mergeWith(const QUndoCommand * command); diff --git a/src/commands/groupclipscommand.cpp b/src/commands/groupclipscommand.cpp index 77010c16..fa77295d 100644 --- a/src/commands/groupclipscommand.cpp +++ b/src/commands/groupclipscommand.cpp @@ -23,7 +23,7 @@ #include -GroupClipsCommand::GroupClipsCommand(CustomTrackView *view, const QList clipInfos, const QList transitionInfos, bool group, QUndoCommand * parent) : +GroupClipsCommand::GroupClipsCommand(CustomTrackView *view, const QList &clipInfos, const QList & transitionInfos, bool group, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_clips(clipInfos), diff --git a/src/commands/groupclipscommand.h b/src/commands/groupclipscommand.h index 5634e62e..d1dd427b 100644 --- a/src/commands/groupclipscommand.h +++ b/src/commands/groupclipscommand.h @@ -33,7 +33,7 @@ class CustomTrackView; class GroupClipsCommand : public QUndoCommand { public: - GroupClipsCommand(CustomTrackView *view, const QList clipInfos, const QList transitionInfos, bool group, QUndoCommand * parent = 0); + GroupClipsCommand(CustomTrackView *view, const QList &clipInfos, const QList &transitionInfos, bool group, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/insertspacecommand.cpp b/src/commands/insertspacecommand.cpp index 7802a82b..3e5a784a 100644 --- a/src/commands/insertspacecommand.cpp +++ b/src/commands/insertspacecommand.cpp @@ -23,7 +23,7 @@ #include -InsertSpaceCommand::InsertSpaceCommand(CustomTrackView *view, QList clipsToMove, QList transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent) : +InsertSpaceCommand::InsertSpaceCommand(CustomTrackView *view, const QList &clipsToMove, const QList &transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_clipsToMove(clipsToMove), diff --git a/src/commands/insertspacecommand.h b/src/commands/insertspacecommand.h index 39b8d4c0..ab8d97dc 100644 --- a/src/commands/insertspacecommand.h +++ b/src/commands/insertspacecommand.h @@ -32,7 +32,7 @@ class CustomTrackView; class InsertSpaceCommand : public QUndoCommand { public: - InsertSpaceCommand(CustomTrackView *view, QList clipsToMove, QList transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent = 0); + InsertSpaceCommand(CustomTrackView *view, const QList &clipsToMove, const QList &transToMove, int track, const GenTime &duration, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/moveeffectcommand.cpp b/src/commands/moveeffectcommand.cpp index 43d502d7..c0771288 100644 --- a/src/commands/moveeffectcommand.cpp +++ b/src/commands/moveeffectcommand.cpp @@ -23,7 +23,7 @@ #include -MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, QList oldPos, int newPos, QUndoCommand * parent) : +MoveEffectCommand::MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QList &oldPos, int newPos, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_track(track), diff --git a/src/commands/moveeffectcommand.h b/src/commands/moveeffectcommand.h index bc1fd30f..e4aa6d70 100644 --- a/src/commands/moveeffectcommand.h +++ b/src/commands/moveeffectcommand.h @@ -31,7 +31,7 @@ class CustomTrackView; class MoveEffectCommand : public QUndoCommand { public: - MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, QList oldPos, int newPos, QUndoCommand * parent = 0); + MoveEffectCommand(CustomTrackView *view, const int track, GenTime pos, const QList &oldPos, int newPos, QUndoCommand * parent = 0); virtual int id() const; virtual bool mergeWith(const QUndoCommand * command); diff --git a/src/commands/movegroupcommand.cpp b/src/commands/movegroupcommand.cpp index f22bdc95..ecfe2519 100644 --- a/src/commands/movegroupcommand.cpp +++ b/src/commands/movegroupcommand.cpp @@ -23,7 +23,7 @@ #include -MoveGroupCommand::MoveGroupCommand(CustomTrackView *view, const QList startClip, const QList startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent) : +MoveGroupCommand::MoveGroupCommand(CustomTrackView *view, const QList &startClip, const QList &startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_startClip(startClip), diff --git a/src/commands/movegroupcommand.h b/src/commands/movegroupcommand.h index c9550ea5..66f8d26e 100644 --- a/src/commands/movegroupcommand.h +++ b/src/commands/movegroupcommand.h @@ -30,7 +30,7 @@ class CustomTrackView; class MoveGroupCommand : public QUndoCommand { public: - MoveGroupCommand(CustomTrackView *view, const QList startClip, const QList startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent = 0); + MoveGroupCommand(CustomTrackView *view, const QList &startClip, const QList &startTransition, const GenTime offset, const int trackOffset, bool doIt, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/commands/razorclipcommand.cpp b/src/commands/razorclipcommand.cpp index 4c6b5cbc..53257ebb 100644 --- a/src/commands/razorclipcommand.cpp +++ b/src/commands/razorclipcommand.cpp @@ -23,7 +23,7 @@ #include -RazorClipCommand::RazorClipCommand(CustomTrackView *view, const ItemInfo info, EffectsList stack, const GenTime cutTime, bool doIt, QUndoCommand * parent) : +RazorClipCommand::RazorClipCommand(CustomTrackView *view, const ItemInfo &info, EffectsList stack, const GenTime cutTime, bool doIt, QUndoCommand * parent) : QUndoCommand(parent), m_view(view), m_info(info), diff --git a/src/commands/razorclipcommand.h b/src/commands/razorclipcommand.h index b014318e..0da865ac 100644 --- a/src/commands/razorclipcommand.h +++ b/src/commands/razorclipcommand.h @@ -33,7 +33,7 @@ class CustomTrackView; class RazorClipCommand : public QUndoCommand { public: - RazorClipCommand(CustomTrackView *view, const ItemInfo info, EffectsList stack, const GenTime cutTime, bool doIt = true, QUndoCommand * parent = 0); + RazorClipCommand(CustomTrackView *view, const ItemInfo &info, EffectsList stack, const GenTime cutTime, bool doIt = true, QUndoCommand * parent = 0); virtual void undo(); virtual void redo(); diff --git a/src/interfaces.h b/src/interfaces.h index 974ed3b6..a1e279fe 100644 --- a/src/interfaces.h +++ b/src/interfaces.h @@ -29,7 +29,7 @@ class ClipGenerator public: virtual ~ClipGenerator() {} - virtual QStringList generators(const QStringList producers = QStringList()) const = 0; + virtual QStringList generators(const QStringList& producers = QStringList()) const = 0; virtual KUrl generatedClip(const QString &renderer, const QString &generator, const KUrl &projectFolder, const QStringList &lumaNames, const QStringList &lumaFiles, const double fps, const int width, const int height) = 0; }; -- 2.39.2