Remove some unneeded conversions from ResampleEffect. Speeds up texture generation...

[movit] / blur_effect.h

diff --git a/blur_effect.h b/blur_effect.h
index ad269f558e57c7112ab1ec07732d227705783048..8ad3da92dc27bb0f164184b04c042de569714038 100644 (file)
--- a/blur_effect.h
+++ b/blur_effect.h
@@ -8,6 +8,11 @@
 // Works in two passes; first horizontal, then vertical (BlurEffect,
 // which is what the user is intended to use, instantiates two copies of
 // SingleBlurPassEffect behind the scenes).
+//
+// The recommended number of taps is the default (16). Fewer will be faster
+// but uglier; a tradeoff that might be worth it as part of more complicated
+// effects. This can be set only before finalization, and must be an
+// even number.
 
 #include <epoxy/gl.h>
 #include <assert.h>
@@ -45,10 +50,12 @@ public:
 
        virtual void rewrite_graph(EffectChain *graph, Node *self);
        virtual bool set_float(const std::string &key, float value);
+       virtual bool set_int(const std::string &key, int value);
        
 private:
        void update_radius();
-       
+
+       int num_taps;
        float radius;
        SingleBlurPassEffect *hpass, *vpass;
        unsigned input_width, input_height;
@@ -59,6 +66,7 @@ public:
        // If parent is non-NULL, calls to inform_input_size will be forwarded
        // so that it can make reasonable decisions for both blur passes.
        SingleBlurPassEffect(BlurEffect *parent);
+       virtual ~SingleBlurPassEffect();
        virtual std::string effect_type_id() const { return "SingleBlurPassEffect"; }
 
        std::string output_fragment_shader();
@@ -74,6 +82,8 @@ public:
                }
        }
        virtual bool changes_output_size() const { return true; }
+       virtual bool sets_virtual_output_size() const { return true; }
+       virtual bool one_to_one_sampling() const { return false; }  // Can sample outside the border.
 
        virtual void get_output_size(unsigned *width, unsigned *height, unsigned *virtual_width, unsigned *virtual_height) const {
                *width = this->width;
@@ -89,9 +99,11 @@ public:
 
 private:
        BlurEffect *parent;
+       int num_taps;
        float radius;
        Direction direction;
        int width, height, virtual_width, virtual_height;
+       float *uniform_samples;
 };
 
 }  // namespace movit