Loosen up a boundary in DitherEffectTest by 10%.

[movit] / colorspace_conversion_effect.h

diff --git a/colorspace_conversion_effect.h b/colorspace_conversion_effect.h
index 3b21804cac103f56b2d71eaecc7ae93139266b3f..15ad0addbc04394d2f70650c211495e2b0c2cacb 100644 (file)
--- a/colorspace_conversion_effect.h
+++ b/colorspace_conversion_effect.h
@@ -1,18 +1,31 @@
 #ifndef _COLORSPACE_CONVERSION_EFFECT_H
 #define _COLORSPACE_CONVERSION_EFFECT_H 1
 
+// An effect to convert between different color spaces.
+// Can convert freely between sRGB/Rec. 709 and the two different Rec. 601
+// color spaces (which thankfully have the same white point).
+//
+// We don't do any fancy gamut mapping or similar; colors that are out-of-gamut
+// will simply stay out-of-gamut, and probably clip in the output stage.
+
 #include "effect.h"
 #include "effect_chain.h"
 
-class ColorSpaceConversionEffect : public Effect {
+class ColorspaceConversionEffect : public Effect {
+private:
+       // Should not be instantiated by end users.
+       ColorspaceConversionEffect();
+       friend class EffectChain;
+
 public:
-       ColorSpaceConversionEffect();
+       virtual std::string effect_type_id() const { return "ColorspaceConversionEffect"; }
        std::string output_fragment_shader();
 
-       virtual bool needs_srgb_primaries() { return false; }
+       virtual bool needs_srgb_primaries() const { return false; }
+       virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
 
 private:
-       ColorSpace source_space, destination_space;
+       Colorspace source_space, destination_space;
 };
 
 #endif // !defined(_COLORSPACE_CONVERSION_EFFECT_H)