Fix a bug where DeconvolutionSharpenEffect would forget one line of the kernel.

[movit] / deconvolution_sharpen_effect_test.cpp

diff --git a/deconvolution_sharpen_effect_test.cpp b/deconvolution_sharpen_effect_test.cpp
index 6980b3d16b34bac262789ec2bf9632c690e9d3cb..8daeb675969397bb3be460911e5b8491d0b3e78b 100644 (file)
--- a/deconvolution_sharpen_effect_test.cpp
+++ b/deconvolution_sharpen_effect_test.cpp
@@ -199,3 +199,35 @@ TEST(DeconvolutionSharpenEffectTest, NoiseAndCorrelationControlsReduceNoiseBoost
        // Check that we didn't boost total energy (which in this case means the noise) more than 10%.
        EXPECT_LT(sumsq_out, sumsq_in * 1.1f);
 }
+
+TEST(DeconvolutionSharpenEffectTest, CircularDeconvolutionKeepsAlpha) {
+       // Somewhat bigger, to make sure we are much bigger than the matrix size.
+       const int size = 32;
+
+       float data[size * size * 4];
+       float out_data[size * size];
+       float expected_alpha[size * size];
+
+       // Checkerbox pattern.
+       for (int y = 0; y < size; ++y) {
+               for (int x = 0; x < size; ++x) {
+                       int c = (y ^ x) & 1;
+                       data[(y * size + x) * 4 + 0] = c;
+                       data[(y * size + x) * 4 + 1] = c;
+                       data[(y * size + x) * 4 + 2] = c;
+                       data[(y * size + x) * 4 + 3] = 1.0;
+                       expected_alpha[y * size + x] = 1.0;
+               }
+       }
+
+       EffectChainTester tester(data, size, size, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR);
+       Effect *deconvolution_effect = tester.get_chain()->add_effect(new DeconvolutionSharpenEffect());
+       ASSERT_TRUE(deconvolution_effect->set_int("matrix_size", 5));
+       ASSERT_TRUE(deconvolution_effect->set_float("circle_radius", 2.0f));
+       ASSERT_TRUE(deconvolution_effect->set_float("gaussian_radius", 0.0f));
+       ASSERT_TRUE(deconvolution_effect->set_float("correlation", 0.0001f));
+       ASSERT_TRUE(deconvolution_effect->set_float("noise", 0.0f));
+       tester.run(out_data, GL_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR);
+
+       expect_equal(expected_alpha, out_data, size, size);
+}