Remove sandbox_effect from coverage.

[movit] / gamma_compression_effect.h

diff --git a/gamma_compression_effect.h b/gamma_compression_effect.h
index 3f32f5ccb8f7fa02a9d9a4d409369980b6dcec1b..9577e020954461ff5fb6e1ee2c1145d115a5f1a9 100644 (file)
--- a/gamma_compression_effect.h
+++ b/gamma_compression_effect.h
@@ -1,18 +1,39 @@
-#ifndef _GAMMA_COMPRESSION_EFFECT_H 
-#define _GAMMA_COMPRESSION_EFFECT_H 1
+#ifndef _MOVIT_GAMMA_COMPRESSION_EFFECT_H 
+#define _MOVIT_GAMMA_COMPRESSION_EFFECT_H 1
+
+// An effect to convert linear light to the given gamma curve,
+// typically inserted by the framework automatically at the end
+// of the processing chain.
+//
+// Currently supports sRGB, Rec. 601/709 and Rec. 2020 (10- and 12-bit).
+// Note that Movit's internal formats generally do not have enough accuracy
+// for 12-bit input or output.
+
+#include <GL/glew.h>
+#include <string>

 
 #include "effect.h"
 
 #include "effect.h"

-#include "effect_chain.h"
+#include "image_format.h"

 
 class GammaCompressionEffect : public Effect {
 
 class GammaCompressionEffect : public Effect {

-public:
+private:
+       // Should not be instantiated by end users.

        GammaCompressionEffect();
        GammaCompressionEffect();

+       friend class EffectChain;
+
+public:
+       virtual std::string effect_type_id() const { return "GammaCompressionEffect"; }

        std::string output_fragment_shader();
        std::string output_fragment_shader();

+       virtual void set_gl_state(GLuint glsl_program_num, const std::string &prefix, unsigned *sampler_num);
+
+       virtual bool needs_srgb_primaries() const { return false; }

 
 

-       virtual bool needs_srgb_primaries() { return false; }
+       // Actually needs postmultiplied input as well as outputting it.
+       // EffectChain will take care of that.
+       virtual AlphaHandling alpha_handling() const { return OUTPUT_POSTMULTIPLIED_ALPHA; }

 
 private:
        GammaCurve destination_curve;
 };
 
 
 private:
        GammaCurve destination_curve;
 };
 

-#endif // !defined(_GAMMA_COMPRESSION_EFFECT_H)
+#endif // !defined(_MOVIT_GAMMA_COMPRESSION_EFFECT_H)