]> git.sesse.net Git - movit/blobdiff - init.cpp
Don't use GL_RGBA32F/GL_RGBA16F with GL_UNSIGNED_BYTE.
[movit] / init.cpp
index 5717dda8d43ad1a3416a3be618c0866fe3d886e0..37e9d70f974ec160c7bd7b2f169767cdcf17b263 100644 (file)
--- a/init.cpp
+++ b/init.cpp
@@ -5,6 +5,7 @@
 #include <string>
 
 #include "init.h"
+#include "resource_pool.h"
 #include "util.h"
 
 using namespace std;
@@ -27,6 +28,7 @@ namespace {
 
 void measure_texel_subpixel_precision()
 {
+       ResourcePool resource_pool;
        static const unsigned width = 4096;
 
        // Generate a destination texture to render to, and an FBO.
@@ -36,7 +38,7 @@ void measure_texel_subpixel_precision()
        check_error();
        glBindTexture(GL_TEXTURE_2D, dst_texnum);
        check_error();
-       glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16F_ARB, width, 1, 0, GL_RGBA, GL_UNSIGNED_BYTE, NULL);
+       glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16F, width, 1, 0, GL_RGBA, GL_FLOAT, NULL);
        check_error();
 
        glGenFramebuffers(1, &fbo);
@@ -56,15 +58,13 @@ void measure_texel_subpixel_precision()
        float texdata[] = { 0, 1 };
        glGenTextures(1, &src_texnum);
        check_error();
-       glBindTexture(GL_TEXTURE_1D, src_texnum);
+       glBindTexture(GL_TEXTURE_2D, src_texnum);
        check_error();
-       glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
        check_error();
-       glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
        check_error();
-       glTexImage1D(GL_TEXTURE_1D, 0, GL_LUMINANCE16F_ARB, 2, 0, GL_LUMINANCE, GL_FLOAT, texdata);
-       check_error();
-       glEnable(GL_TEXTURE_1D);
+       glTexImage2D(GL_TEXTURE_2D, 0, GL_R16F, 2, 1, 0, GL_RED, GL_FLOAT, texdata);
        check_error();
 
        // Basic state.
@@ -77,36 +77,46 @@ void measure_texel_subpixel_precision()
 
        glViewport(0, 0, width, 1);
 
-       glMatrixMode(GL_PROJECTION);
-       glLoadIdentity();
-       glOrtho(0.0, 1.0, 0.0, 1.0, 0.0, 1.0);
-
-       glMatrixMode(GL_MODELVIEW);
-       glLoadIdentity();
+       GLuint glsl_program_num = resource_pool.compile_glsl_program(
+               read_file("vs.vert"), read_file("texture1d.frag"));
+       glUseProgram(glsl_program_num);
+       check_error();
+       glUniform1i(glGetUniformLocation(glsl_program_num, "tex"), 0);  // Bind the 2D sampler.
        check_error();
 
        // Draw the texture stretched over a long quad, interpolating it out.
        // Note that since the texel center is in (0.5), we need to adjust the
        // texture coordinates in order not to get long stretches of (1,1,1,...)
        // at the start and (...,0,0,0) at the end.
-       glBegin(GL_QUADS);
-
-       glTexCoord1f(0.25f);
-       glVertex2f(0.0f, 0.0f);
-
-       glTexCoord1f(0.75f);
-       glVertex2f(1.0f, 0.0f);
+       float vertices[] = {
+               0.0f, 1.0f,
+               0.0f, 0.0f,
+               1.0f, 1.0f,
+               1.0f, 0.0f
+       };
+       float texcoords[] = {
+               0.25f, 0.0f,
+               0.25f, 0.0f,
+               0.75f, 0.0f,
+               0.75f, 0.0f
+       };
 
-       glTexCoord1f(0.75f);
-       glVertex2f(1.0f, 1.0f);
+       GLuint vao;
+       glGenVertexArrays(1, &vao);
+       check_error();
+       glBindVertexArray(vao);
+       check_error();
 
-       glTexCoord1f(0.25f);
-       glVertex2f(0.0f, 1.0f);
+       GLuint position_vbo = fill_vertex_attribute(glsl_program_num, "position", 2, GL_FLOAT, sizeof(vertices), vertices);
+       GLuint texcoord_vbo = fill_vertex_attribute(glsl_program_num, "texcoord", 2, GL_FLOAT, sizeof(texcoords), texcoords);
 
-       glEnd();
+       glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
        check_error();
 
-       glDisable(GL_TEXTURE_1D);
+       cleanup_vertex_attribute(glsl_program_num, "position", position_vbo);
+       cleanup_vertex_attribute(glsl_program_num, "texcoord", texcoord_vbo);
+
+       glUseProgram(0);
        check_error();
 
        // Now read the data back and see what the card did.
@@ -122,10 +132,11 @@ void measure_texel_subpixel_precision()
                biggest_jump = max(biggest_jump, out_data[i] - out_data[i - 1]);
        }
 
+       assert(biggest_jump > 0.0);
        movit_texel_subpixel_precision = biggest_jump;
 
        // Clean up.
-       glBindTexture(GL_TEXTURE_1D, 0);
+       glBindTexture(GL_TEXTURE_2D, 0);
        check_error();
        glBindFramebuffer(GL_FRAMEBUFFER, 0);
        check_error();
@@ -135,10 +146,16 @@ void measure_texel_subpixel_precision()
        check_error();
        glDeleteTextures(1, &src_texnum);
        check_error();
+
+       resource_pool.release_glsl_program(glsl_program_num);
+       glDeleteVertexArrays(1, &vao);
+       check_error();
 }
 
 void measure_roundoff_problems()
 {
+       ResourcePool resource_pool;
+
        // Generate a destination texture to render to, and an FBO.
        GLuint dst_texnum, fbo;
 
@@ -172,15 +189,13 @@ void measure_roundoff_problems()
        }
        glGenTextures(1, &src_texnum);
        check_error();
-       glBindTexture(GL_TEXTURE_1D, src_texnum);
-       check_error();
-       glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+       glBindTexture(GL_TEXTURE_2D, src_texnum);
        check_error();
-       glTexParameteri(GL_TEXTURE_1D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
+       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
        check_error();
-       glTexImage1D(GL_TEXTURE_1D, 0, GL_LUMINANCE32F_ARB, 512, 0, GL_LUMINANCE, GL_FLOAT, texdata);
+       glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
        check_error();
-       glEnable(GL_TEXTURE_1D);
+       glTexImage2D(GL_TEXTURE_2D, 0, GL_R32F, 512, 1, 0, GL_RED, GL_FLOAT, texdata);
        check_error();
 
        // Basic state.
@@ -193,33 +208,36 @@ void measure_roundoff_problems()
 
        glViewport(0, 0, 512, 1);
 
-       glMatrixMode(GL_PROJECTION);
-       glLoadIdentity();
-       glOrtho(0.0, 1.0, 0.0, 1.0, 0.0, 1.0);
-
-       glMatrixMode(GL_MODELVIEW);
-       glLoadIdentity();
+       GLuint glsl_program_num = resource_pool.compile_glsl_program(
+               read_file("vs.vert"), read_file("texture1d.frag"));
+       glUseProgram(glsl_program_num);
        check_error();
+       glUniform1i(glGetUniformLocation(glsl_program_num, "tex"), 0);  // Bind the 2D sampler.
 
        // Draw the texture stretched over a long quad, interpolating it out.
-       glBegin(GL_QUADS);
-
-       glTexCoord1f(0.0f);
-       glVertex2f(0.0f, 0.0f);
-
-       glTexCoord1f(1.0f);
-       glVertex2f(1.0f, 0.0f);
+       float vertices[] = {
+               0.0f, 1.0f,
+               0.0f, 0.0f,
+               1.0f, 1.0f,
+               1.0f, 0.0f
+       };
 
-       glTexCoord1f(1.0f);
-       glVertex2f(1.0f, 1.0f);
+       GLuint vao;
+       glGenVertexArrays(1, &vao);
+       check_error();
+       glBindVertexArray(vao);
+       check_error();
 
-       glTexCoord1f(0.0f);
-       glVertex2f(0.0f, 1.0f);
+       GLuint position_vbo = fill_vertex_attribute(glsl_program_num, "position", 2, GL_FLOAT, sizeof(vertices), vertices);
+       GLuint texcoord_vbo = fill_vertex_attribute(glsl_program_num, "texcoord", 2, GL_FLOAT, sizeof(vertices), vertices);  // Same data.
 
-       glEnd();
+       glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
        check_error();
 
-       glDisable(GL_TEXTURE_1D);
+       cleanup_vertex_attribute(glsl_program_num, "position", position_vbo);
+       cleanup_vertex_attribute(glsl_program_num, "texcoord", texcoord_vbo);
+
+       glUseProgram(0);
        check_error();
 
        // Now read the data back and see what the card did. (Ignore the last value.)
@@ -241,7 +259,7 @@ void measure_roundoff_problems()
        movit_num_wrongly_rounded = wrongly_rounded;
 
        // Clean up.
-       glBindTexture(GL_TEXTURE_1D, 0);
+       glBindTexture(GL_TEXTURE_2D, 0);
        check_error();
        glBindFramebuffer(GL_FRAMEBUFFER, 0);
        check_error();
@@ -251,6 +269,10 @@ void measure_roundoff_problems()
        check_error();
        glDeleteTextures(1, &src_texnum);
        check_error();
+
+       resource_pool.release_glsl_program(glsl_program_num);
+       glDeleteVertexArrays(1, &vao);
+       check_error();
 }
 
 bool check_extensions()