X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=blur_effect.cpp;h=77238533e308054ccdd60475313d86b2e573bbd8;hp=b48dc956e59dade84e49ac507de998dc4241f45d;hb=d7730c1a3f55337a5eda502862b624181bfc97d2;hpb=322c03693ae23e5a5843dee9dcb74dfb3b7d43d8

diff --git a/blur_effect.cpp b/blur_effect.cpp
index b48dc95..7723853 100644
--- a/blur_effect.cpp
+++ b/blur_effect.cpp
@@ -1,10 +1,10 @@
 #include <math.h>
 #include <assert.h>
+#include <GL/glew.h>
 
 #include "blur_effect.h"
 #include "effect_chain.h"
 #include "util.h"
-#include "opengl.h"
 
 // Must match blur_effect.frag.
 #define NUM_TAPS 16
@@ -16,9 +16,9 @@ BlurEffect::BlurEffect()
 {
 	// The first blur pass will forward resolution information to us.
 	hpass = new SingleBlurPassEffect(this);
-	hpass->set_int("direction", SingleBlurPassEffect::HORIZONTAL);
+	CHECK(hpass->set_int("direction", SingleBlurPassEffect::HORIZONTAL));
 	vpass = new SingleBlurPassEffect(NULL);
-	vpass->set_int("direction", SingleBlurPassEffect::VERTICAL);
+	CHECK(vpass->set_int("direction", SingleBlurPassEffect::VERTICAL));
 
 	update_radius();
 }
@@ -114,12 +114,16 @@ void SingleBlurPassEffect::set_gl_state(GLuint glsl_program_num, const std::stri
 	} else {
 		float sum = 0.0f;
 		for (unsigned i = 0; i < NUM_TAPS + 1; ++i) {
-			float z = i / radius;
-
 			// Gaussian blur is a common, but maybe not the prettiest choice;
 			// it can feel a bit too blurry in the fine detail and too little
 			// long-tail. This is a simple logistic distribution, which has
 			// a narrower peak but longer tails.
+			//
+			// We interpret the radius as sigma, similar to Gaussian blur.
+			// Wikipedia says that sigma² = pi² s² / 3, which yields:
+			const float s = (sqrt(3.0) / M_PI) * radius;
+			float z = i / (2.0 * s);
+
 			weight[i] = 1.0f / (cosh(z) * cosh(z));
 
 			if (i == 0) {
@@ -158,13 +162,8 @@ void SingleBlurPassEffect::set_gl_state(GLuint glsl_program_num, const std::stri
 		float w2 = weight[base_pos + 1];
 
 		float offset, total_weight;
-		if (w1 + w2 < 1e-6) {
-			offset = 0.5f;
-			total_weight = 0.0f;
-		} else {
-			offset = w2 / (w1 + w2);
-			total_weight = w1 + w2;
-		}
+		combine_two_samples(w1, w2, &offset, &total_weight, NULL);
+
 		float x = 0.0f, y = 0.0f;
 
 		if (direction == HORIZONTAL) {