X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=colorspace_conversion_effect.h;h=15ad0addbc04394d2f70650c211495e2b0c2cacb;hp=6efc2a2c8e11b5cd4b0b46cf51d6e3202325fb37;hb=e22b57d30085d193da7829e0bc082ad1a310963e;hpb=a94fbb7ebe6bd57c0c0a7f4174d97b95e3147519;ds=sidebyside

diff --git a/colorspace_conversion_effect.h b/colorspace_conversion_effect.h
index 6efc2a2..15ad0ad 100644
--- a/colorspace_conversion_effect.h
+++ b/colorspace_conversion_effect.h
@@ -1,18 +1,31 @@
 #ifndef _COLORSPACE_CONVERSION_EFFECT_H
 #define _COLORSPACE_CONVERSION_EFFECT_H 1
 
+// An effect to convert between different color spaces.
+// Can convert freely between sRGB/Rec. 709 and the two different Rec. 601
+// color spaces (which thankfully have the same white point).
+//
+// We don't do any fancy gamut mapping or similar; colors that are out-of-gamut
+// will simply stay out-of-gamut, and probably clip in the output stage.
+
 #include "effect.h"
 #include "effect_chain.h"
 
-class ColorSpaceConversionEffect : public Effect {
+class ColorspaceConversionEffect : public Effect {
+private:
+	// Should not be instantiated by end users.
+	ColorspaceConversionEffect();
+	friend class EffectChain;
+
 public:
-	ColorSpaceConversionEffect();
-	std::string output_glsl();
+	virtual std::string effect_type_id() const { return "ColorspaceConversionEffect"; }
+	std::string output_fragment_shader();
 
-	virtual bool needs_srgb_primaries() { return false; }
+	virtual bool needs_srgb_primaries() const { return false; }
+	virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
 
 private:
-	ColorSpace source_space, destination_space;
+	Colorspace source_space, destination_space;
 };
 
 #endif // !defined(_COLORSPACE_CONVERSION_EFFECT_H)