X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=colorspace_conversion_effect.h;h=92bad1f7d7eb1ec5f7c65633d8eda34856d2e212;hp=3b21804cac103f56b2d71eaecc7ae93139266b3f;hb=f216b7bef5a968c89f6fc78e83cc26a91e504a8a;hpb=17c083aad45a10df14c38cfe879a87220dfd4fb9

diff --git a/colorspace_conversion_effect.h b/colorspace_conversion_effect.h
index 3b21804..92bad1f 100644
--- a/colorspace_conversion_effect.h
+++ b/colorspace_conversion_effect.h
@@ -1,18 +1,42 @@
-#ifndef _COLORSPACE_CONVERSION_EFFECT_H
-#define _COLORSPACE_CONVERSION_EFFECT_H 1
+#ifndef _MOVIT_COLORSPACE_CONVERSION_EFFECT_H
+#define _MOVIT_COLORSPACE_CONVERSION_EFFECT_H 1
+
+// An effect to convert between different color spaces.
+// Can convert freely between sRGB/Rec. 709 and the two different Rec. 601
+// color spaces (which thankfully have the same white point).
+//
+// We don't do any fancy gamut mapping or similar; colors that are out-of-gamut
+// will simply stay out-of-gamut, and probably clip in the output stage.
+
+#include <Eigen/Core>
+#include <string>
 
 #include "effect.h"
-#include "effect_chain.h"
+#include "image_format.h"
+
+namespace movit {
+
+class ColorspaceConversionEffect : public Effect {
+private:
+	// Should not be instantiated by end users.
+	ColorspaceConversionEffect();
+	friend class EffectChain;
 
-class ColorSpaceConversionEffect : public Effect {
 public:
-	ColorSpaceConversionEffect();
+	virtual std::string effect_type_id() const { return "ColorspaceConversionEffect"; }
 	std::string output_fragment_shader();
 
-	virtual bool needs_srgb_primaries() { return false; }
+	virtual bool needs_srgb_primaries() const { return false; }
+	virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
+	virtual bool one_to_one_sampling() const { return true; }
+
+	// Get a conversion matrix from the given color space to XYZ.
+	static Eigen::Matrix3d get_xyz_matrix(Colorspace space);
 
 private:
-	ColorSpace source_space, destination_space;
+	Colorspace source_space, destination_space;
 };
 
-#endif // !defined(_COLORSPACE_CONVERSION_EFFECT_H)
+}  // namespace movit
+
+#endif // !defined(_MOVIT_COLORSPACE_CONVERSION_EFFECT_H)