X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=colorspace_conversion_effect.h;h=a59d4766a8ba3699b23723d6b87fd64cab4dc6c4;hp=1e7bd5b18dabdfa5881a89d7b52d1fa0181785f9;hb=c79d94d05d560fa59b23d542bca6d7a94b907b6f;hpb=f99ad333a7acbb6c8c995dbb036484ae8940c490

diff --git a/colorspace_conversion_effect.h b/colorspace_conversion_effect.h
index 1e7bd5b..a59d476 100644
--- a/colorspace_conversion_effect.h
+++ b/colorspace_conversion_effect.h
@@ -1,5 +1,5 @@
-#ifndef _COLORSPACE_CONVERSION_EFFECT_H
-#define _COLORSPACE_CONVERSION_EFFECT_H 1
+#ifndef _MOVIT_COLORSPACE_CONVERSION_EFFECT_H
+#define _MOVIT_COLORSPACE_CONVERSION_EFFECT_H 1
 
 // An effect to convert between different color spaces.
 // Can convert freely between sRGB/Rec. 709 and the two different Rec. 601
@@ -8,19 +8,35 @@
 // We don't do any fancy gamut mapping or similar; colors that are out-of-gamut
 // will simply stay out-of-gamut, and probably clip in the output stage.
 
+#include <Eigen/Core>
+#include <string>
+
 #include "effect.h"
-#include "effect_chain.h"
+#include "image_format.h"
+
+namespace movit {
+
+class ColorspaceConversionEffect : public Effect {
+private:
+	// Should not be instantiated by end users.
+	ColorspaceConversionEffect();
+	friend class EffectChain;
 
-class ColorSpaceConversionEffect : public Effect {
 public:
-	ColorSpaceConversionEffect();
-	virtual std::string effect_type_id() const { return "ColorSpaceConversionEffect"; }
-	std::string output_fragment_shader();
+	std::string effect_type_id() const override { return "ColorspaceConversionEffect"; }
+	std::string output_fragment_shader() override;
+
+	bool needs_srgb_primaries() const override { return false; }
+	AlphaHandling alpha_handling() const override { return DONT_CARE_ALPHA_TYPE; }
+	bool strong_one_to_one_sampling() const override { return true; }
 
-	virtual bool needs_srgb_primaries() const { return false; }
+	// Get a conversion matrix from the given color space to XYZ.
+	static Eigen::Matrix3d get_xyz_matrix(Colorspace space);
 
 private:
-	ColorSpace source_space, destination_space;
+	Colorspace source_space, destination_space;
 };
 
-#endif // !defined(_COLORSPACE_CONVERSION_EFFECT_H)
+}  // namespace movit
+
+#endif // !defined(_MOVIT_COLORSPACE_CONVERSION_EFFECT_H)