X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect.h;h=d14176b2b1f4dc5f74f56388766cdfb2d5d14362;hp=fcb752638115dd6297bccb918cd606dd3b535645;hb=0dc1dfe6444a700ebd2c9f006cba000b90c3a7b0;hpb=5058b68995b5d39042df42df06d55559ee535d38

diff --git a/effect.h b/effect.h
index fcb7526..d14176b 100644
--- a/effect.h
+++ b/effect.h
@@ -60,7 +60,9 @@ public:
 	// set of RGB primaries; you would currently not get YCbCr
 	// or something similar).
 	//
-	// Again, most effects will want this.
+	// Again, most effects will want this, but you can set it to false
+	// if you process each channel independently, equally _and_
+	// in a linear fashion.
 	virtual bool needs_srgb_primaries() const { return true; }
 
 	// Whether this effect expects its input to come directly from
@@ -113,17 +115,19 @@ public:
 	// Returns the GLSL fragment shader string for this effect.
 	virtual std::string output_fragment_shader() = 0;
 
-	// Set all uniforms the shader needs in the current GL context.
-	// The default implementation sets one uniform per registered parameter.
+	// Set all OpenGL state that this effect needs before rendering.
+	// The default implementation sets one uniform per registered parameter,
+	// but no other state.
 	//
 	// <sampler_num> is the first free texture sampler. If you want to use
 	// textures, you can bind a texture to GL_TEXTURE0 + <sampler_num>,
 	// and then increment the number (so that the next effect in the chain
 	// will use a different sampler).
-	//
-	// NOTE: Currently this is also abused a bit to set other GL state
-	// the effect might need.
-	virtual void set_uniforms(GLuint glsl_program_num, const std::string& prefix, unsigned *sampler_num);
+	virtual void set_gl_state(GLuint glsl_program_num, const std::string& prefix, unsigned *sampler_num);
+
+	// If you set any special OpenGL state in set_gl_state(), you can clear it
+	// after rendering here. The default implementation does nothing.
+	virtual void clear_gl_state();
 
 	// Set a parameter; intended to be called from user code.
 	// Neither of these take ownership of the pointer.