X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect_chain.cpp;h=091bda89ddf7d5f7c70fa1109861566cb3a626f4;hp=34a396aa607ab65db3e64f4f9f57a1273e45f021;hb=c6ee050546b6940ae19a74f92bdcc8d2b1f56d22;hpb=b89deb99c8e5d5e96d502a7c90b2bbc7daaac822 diff --git a/effect_chain.cpp b/effect_chain.cpp index 34a396a..091bda8 100644 --- a/effect_chain.cpp +++ b/effect_chain.cpp @@ -1725,6 +1725,7 @@ void EffectChain::add_dummy_effect_if_needed() if (output->effect->is_compute_shader()) { Node *dummy = add_node(new IdentityEffect()); connect_nodes(output, dummy); + has_dummy_effect = true; } } @@ -1820,18 +1821,6 @@ void EffectChain::finalize() void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height) { - assert(finalized); - - // This needs to be set anew, in case we are coming from a different context - // from when we initialized. - check_error(); - glDisable(GL_DITHER); - check_error(); - - const bool final_srgb = glIsEnabled(GL_FRAMEBUFFER_SRGB); - check_error(); - bool current_srgb = final_srgb; - // Save original viewport. GLuint x = 0, y = 0; @@ -1844,6 +1833,44 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height height = viewport[3]; } + render(dest_fbo, {}, x, y, width, height); +} + +void EffectChain::render_to_texture(const vector &destinations, unsigned width, unsigned height) +{ + assert(finalized); + assert(!destinations.empty()); + + if (!has_dummy_effect) { + // We don't end in a compute shader, so there's nothing specific for us to do. + // Create an FBO for this set of textures, and just render to that. + GLuint texnums[4] = { 0, 0, 0, 0 }; + for (unsigned i = 0; i < destinations.size() && i < 4; ++i) { + texnums[i] = destinations[i].texnum; + } + GLuint dest_fbo = resource_pool->create_fbo(texnums[0], texnums[1], texnums[2], texnums[3]); + render(dest_fbo, {}, 0, 0, width, height); + resource_pool->release_fbo(dest_fbo); + } else { + render((GLuint)-1, destinations, 0, 0, width, height); + } +} + +void EffectChain::render(GLuint dest_fbo, const vector &destinations, unsigned x, unsigned y, unsigned width, unsigned height) +{ + assert(finalized); + assert(destinations.size() <= 1); + + // This needs to be set anew, in case we are coming from a different context + // from when we initialized. + check_error(); + glDisable(GL_DITHER); + check_error(); + + const bool final_srgb = glIsEnabled(GL_FRAMEBUFFER_SRGB); + check_error(); + bool current_srgb = final_srgb; + // Basic state. check_error(); glDisable(GL_BLEND); @@ -1859,7 +1886,24 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height // since otherwise this turns into an (albeit simple) register allocation problem. map output_textures; - for (unsigned phase_num = 0; phase_num < phases.size(); ++phase_num) { + size_t num_phases = phases.size(); + if (destinations.empty()) { + assert(dest_fbo != (GLuint)-1); + } else { + assert(has_dummy_effect); + assert(x == 0); + assert(y == 0); + assert(num_phases >= 2); + assert(!phases.back()->is_compute_shader); + assert(phases.back()->effects.size() == 1); + assert(phases.back()->effects[0]->effect->effect_type_id() == "IdentityEffect"); + + // We are rendering to a set of textures, so we can run the compute shader + // directly and skip the dummy phase. + --num_phases; + } + + for (unsigned phase_num = 0; phase_num < num_phases; ++phase_num) { Phase *phase = phases[phase_num]; if (do_phase_timing) { @@ -1873,22 +1917,25 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height glBeginQuery(GL_TIME_ELAPSED, timer_query_object); phase->timer_query_objects_running.push_back(timer_query_object); } - if (phase_num == phases.size() - 1) { + bool last_phase = (phase_num == num_phases - 1); + if (phase_num == num_phases - 1) { // Last phase goes to the output the user specified. - glBindFramebuffer(GL_FRAMEBUFFER, dest_fbo); - check_error(); - GLenum status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT); - assert(status == GL_FRAMEBUFFER_COMPLETE); - glViewport(x, y, width, height); + if (!phase->is_compute_shader) { + glBindFramebuffer(GL_FRAMEBUFFER, dest_fbo); + check_error(); + GLenum status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT); + assert(status == GL_FRAMEBUFFER_COMPLETE); + glViewport(x, y, width, height); + } if (dither_effect != nullptr) { CHECK(dither_effect->set_int("output_width", width)); CHECK(dither_effect->set_int("output_height", height)); } } - bool last_phase = (phase_num == phases.size() - 1); // Enable sRGB rendering for intermediates in case we are // rendering to an sRGB format. + // TODO: Support this for compute shaders. bool needs_srgb = last_phase ? final_srgb : true; if (needs_srgb && !current_srgb) { glEnable(GL_FRAMEBUFFER_SRGB); @@ -1900,16 +1947,38 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height current_srgb = true; } - execute_phase(phase, last_phase, &output_textures, &generated_mipmaps); + // Find a texture for this phase. + inform_input_sizes(phase); + find_output_size(phase); + GLuint tex_num = 0; + if (!last_phase) { + tex_num = resource_pool->create_2d_texture(intermediate_format, phase->output_width, phase->output_height); + assert(tex_num != 0); + output_textures.insert(make_pair(phase, tex_num)); + + // The output texture needs to have valid state to be written to by a compute shader. + glActiveTexture(GL_TEXTURE0); + check_error(); + glBindTexture(GL_TEXTURE_2D, tex_num); + check_error(); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); + check_error(); + } else if (phase->is_compute_shader) { + // TODO: Support more than one destination. + assert(!destinations.empty()); + tex_num = destinations[0].texnum; + assert(destinations[0].format == GL_RGBA16F); + assert(destinations[0].texnum != 0); + } + + execute_phase(phase, output_textures, tex_num, &generated_mipmaps); if (do_phase_timing) { glEndQuery(GL_TIME_ELAPSED); } } - for (map::const_iterator texture_it = output_textures.begin(); - texture_it != output_textures.end(); - ++texture_it) { - resource_pool->release_2d_texture(texture_it->second); + for (const auto &phase_and_texnum : output_textures) { + resource_pool->release_2d_texture(phase_and_texnum.second); } glBindFramebuffer(GL_FRAMEBUFFER, 0); @@ -1926,8 +1995,8 @@ void EffectChain::render_to_fbo(GLuint dest_fbo, unsigned width, unsigned height // Get back the timer queries. for (unsigned phase_num = 0; phase_num < phases.size(); ++phase_num) { Phase *phase = phases[phase_num]; - for (std::list::iterator timer_it = phase->timer_query_objects_running.begin(); - timer_it != phase->timer_query_objects_running.end(); ) { + for (auto timer_it = phase->timer_query_objects_running.cbegin(); + timer_it != phase->timer_query_objects_running.cend(); ) { GLint timer_query_object = *timer_it; GLint available; glGetQueryObjectiv(timer_query_object, GL_QUERY_RESULT_AVAILABLE, &available); @@ -1982,27 +2051,19 @@ void EffectChain::print_phase_timing() printf("Total: %5.1f ms\n", total_time_ms); } -void EffectChain::execute_phase(Phase *phase, bool last_phase, - map *output_textures, +void EffectChain::execute_phase(Phase *phase, + const map &output_textures, + GLuint dest_texture, set *generated_mipmaps) { - GLuint fbo = 0; - - // Find a texture for this phase. - inform_input_sizes(phase); - if (!last_phase) { - find_output_size(phase); - - GLuint tex_num = resource_pool->create_2d_texture(intermediate_format, phase->output_width, phase->output_height); - output_textures->insert(make_pair(phase, tex_num)); - } - // Set up RTT inputs for this phase. for (unsigned sampler = 0; sampler < phase->inputs.size(); ++sampler) { glActiveTexture(GL_TEXTURE0 + sampler); Phase *input = phase->inputs[sampler]; input->output_node->bound_sampler_num = sampler; - glBindTexture(GL_TEXTURE_2D, (*output_textures)[input]); + const auto it = output_textures.find(input); + assert(it != output_textures.end()); + glBindTexture(GL_TEXTURE_2D, it->second); check_error(); if (phase->input_needs_mipmaps && generated_mipmaps->count(input) == 0) { glGenerateMipmap(GL_TEXTURE_2D); @@ -2017,23 +2078,23 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, check_error(); // And now the output. + GLuint fbo = 0; if (phase->is_compute_shader) { + assert(dest_texture != 0); + // This is currently the only place where we use image units, // so we can always use 0. phase->outbuf_image_unit = 0; - glBindImageTexture(phase->outbuf_image_unit, (*output_textures)[phase], 0, GL_FALSE, 0, GL_WRITE_ONLY, GL_RGBA16F); + glBindImageTexture(phase->outbuf_image_unit, dest_texture, 0, GL_FALSE, 0, GL_WRITE_ONLY, GL_RGBA16F); check_error(); phase->inv_output_size.x = 1.0f / phase->output_width; phase->inv_output_size.y = 1.0f / phase->output_height; phase->output_texcoord_adjust.x = 0.5f / phase->output_width; phase->output_texcoord_adjust.y = 0.5f / phase->output_height; - } else { - // (Already set up for us if it is the last phase.) - if (!last_phase) { - fbo = resource_pool->create_fbo((*output_textures)[phase]); - glBindFramebuffer(GL_FRAMEBUFFER, fbo); - glViewport(0, 0, phase->output_width, phase->output_height); - } + } else if (dest_texture != 0) { + fbo = resource_pool->create_fbo(dest_texture); + glBindFramebuffer(GL_FRAMEBUFFER, fbo); + glViewport(0, 0, phase->output_width, phase->output_height); } // Give the required parameters to all the effects. @@ -2052,7 +2113,6 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, } } - if (phase->is_compute_shader) { unsigned x, y, z; phase->output_node->effect->get_compute_dimensions(phase->output_width, phase->output_height, &x, &y, &z); @@ -2061,6 +2121,9 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, // since they can be updated from there. setup_uniforms(phase); glDispatchCompute(x, y, z); + check_error(); + glMemoryBarrier(GL_TEXTURE_FETCH_BARRIER_BIT | GL_TEXTURE_UPDATE_BARRIER_BIT); + check_error(); } else { // Uniforms need to come after set_gl_state(), since they can be updated // from there. @@ -2083,7 +2146,7 @@ void EffectChain::execute_phase(Phase *phase, bool last_phase, resource_pool->unuse_glsl_program(instance_program_num); - if (!last_phase && !phase->is_compute_shader) { + if (fbo != 0) { resource_pool->release_fbo(fbo); } }