X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect_chain.cpp;h=c55ee26849617374010b879785b6fcfd5cd55b52;hp=270eae6c4ce9bd7933c46f3f3ffae1ce4e4ac27b;hb=a22465673fce8a9db2cf88bccbee72db0e5b4c5e;hpb=b65675827bcaaa8cd913e46a7210575183d0056f diff --git a/effect_chain.cpp b/effect_chain.cpp index 270eae6..c55ee26 100644 --- a/effect_chain.cpp +++ b/effect_chain.cpp @@ -13,6 +13,7 @@ #include "gamma_compression_effect.h" #include "lift_gamma_gain_effect.h" #include "colorspace_conversion_effect.h" +#include "sandbox_effect.h" #include "saturation_effect.h" #include "mirror_effect.h" #include "vignette_effect.h" @@ -42,6 +43,8 @@ Effect *instantiate_effect(EffectId effect) return new GammaCompressionEffect(); case EFFECT_COLOR_SPACE_CONVERSION: return new ColorSpaceConversionEffect(); + case EFFECT_SANDBOX: + return new SandboxEffect(); case EFFECT_LIFT_GAMMA_GAIN: return new LiftGammaGainEffect(); case EFFECT_SATURATION: @@ -303,6 +306,11 @@ void EffectChain::render_to_screen(unsigned char *src) check_error(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); check_error(); + + // Intel/Mesa seems to have a broken glGenerateMipmap() for non-FBO textures, so do it here. + glTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, phases[0].input_needs_mipmaps ? GL_TRUE : GL_FALSE); + check_error(); + glBindBuffer(GL_PIXEL_UNPACK_BUFFER_ARB, 0); check_error(); @@ -336,8 +344,11 @@ void EffectChain::render_to_screen(unsigned char *src) check_error(); } if (phases[phase].input_needs_mipmaps) { - glGenerateMipmap(GL_TEXTURE_2D); - check_error(); + if (phase != 0) { + // For phase 0, it's done further up. + glGenerateMipmap(GL_TEXTURE_2D); + check_error(); + } glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_NEAREST); check_error(); } else {