X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect_chain.h;h=6d9d062d747f4901c39e6b7681a6b4365c7d3939;hp=b753ad4de697c493fb7a4a7fa1338caf4393d8ab;hb=f85e35e129f2395cb03867feb804e5a4badc594e;hpb=f44c81569a268efea44f1f6df03a000711b18ffc

diff --git a/effect_chain.h b/effect_chain.h
index b753ad4..6d9d062 100644
--- a/effect_chain.h
+++ b/effect_chain.h
@@ -294,6 +294,11 @@ public:
 
 	// Set number of output bits, to scale the dither.
 	// 8 is the right value for most outputs.
+	//
+	// Special note for 10- and 12-bit Y'CbCr packed into GL_UNSIGNED_SHORT:
+	// This is relative to the actual output, not the logical one, so you should
+	// specify 16 here, not 10 or 12.
+	//
 	// The default, 0, is a special value that means no dither.
 	void set_dither_bits(unsigned num_bits)
 	{
@@ -359,6 +364,9 @@ public:
 	void reset_phase_timing();
 	void print_phase_timing();
 
+	// Note: If you already know the width and height of the viewport,
+	// calling render_to_fbo() directly will be slightly more efficient,
+	// as it saves it from getting it from OpenGL.
 	void render_to_screen()
 	{
 		render_to_fbo(0, 0, 0);
@@ -438,7 +446,6 @@ private:
 
 	// Execute one phase, ie. set up all inputs, effects and outputs, and render the quad.
 	void execute_phase(Phase *phase, bool last_phase,
-	                   std::set<GLint> *bound__attribute_indices,
 	                   std::map<Phase *, GLuint> *output_textures,
 	                   std::set<Phase *> *generated_mipmaps);