X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect_chain_test.cpp;h=356d628e7e0fbd7dd2c293a9efafd34ed36cfed1;hp=28197f9152c3bdcedc0dfe40fedc5178e5de93da;hb=7f7069a0392bf5a5815e2a7452f5879b25959155;hpb=ac5f7aa64ab690120a71fe45ee4b9bbc56610191

diff --git a/effect_chain_test.cpp b/effect_chain_test.cpp
index 28197f9..356d628 100644
--- a/effect_chain_test.cpp
+++ b/effect_chain_test.cpp
@@ -2,12 +2,13 @@
 //
 // Note that this also contains the tests for some of the simpler effects.
 
+#include <GL/glew.h>
+
 #include "effect_chain.h"
 #include "flat_input.h"
 #include "gtest/gtest.h"
 #include "mirror_effect.h"
 #include "resize_effect.h"
-#include "opengl.h"
 #include "test_util.h"
 
 TEST(EffectChainTest, EmptyChain) {
@@ -88,6 +89,10 @@ public:
 	InvertEffect() {}
 	virtual std::string effect_type_id() const { return "InvertEffect"; }
 	std::string output_fragment_shader() { return read_file("invert_effect.frag"); }
+
+	// A real invert would actually care about its alpha,
+	// but in this unit test, it only complicates things.
+	virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
 };
 
 // Like IdentityEffect, but rewrites itself out of the loop,
@@ -135,8 +140,112 @@ TEST(EffectChainTest, RewritingWorksAndGammaConversionsAreInserted) {
 	expect_equal(expected_data, out_data, 3, 2);
 }
 
+TEST(EffectChainTest, RewritingWorksAndTexturesAreAskedForsRGB) {
+	unsigned char data[] = {
+		0, 64,
+		128, 255,
+	};
+	float expected_data[4] = {
+		1.0f, 0.9771f,
+		0.8983f, 0.0f,
+	};
+	float out_data[2];
+	EffectChainTester tester(NULL, 2, 2);
+	tester.add_input(data, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_sRGB);
+	RewritingToInvertEffect *effect = new RewritingToInvertEffect();
+	tester.get_chain()->add_effect(effect);
+	tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	Node *node = effect->invert_node;
+	ASSERT_EQ(1, node->incoming_links.size());
+	ASSERT_EQ(1, node->outgoing_links.size());
+	EXPECT_EQ("FlatInput", node->incoming_links[0]->effect->effect_type_id());
+	EXPECT_EQ("GammaCompressionEffect", node->outgoing_links[0]->effect->effect_type_id());
+
+	expect_equal(expected_data, out_data, 2, 2);
+}
+
+TEST(EffectChainTest, RewritingWorksAndColorspaceConversionsAreInserted) {
+	float data[] = {
+		0.0f, 0.25f, 0.3f,
+		0.75f, 1.0f, 1.0f,
+	};
+	float expected_data[6] = {
+		1.0f, 0.75f, 0.7f,
+		0.25f, 0.0f, 0.0f,
+	};
+	float out_data[6];
+	EffectChainTester tester(data, 3, 2, FORMAT_GRAYSCALE, COLORSPACE_REC_601_525, GAMMA_LINEAR);
+	RewritingToInvertEffect *effect = new RewritingToInvertEffect();
+	tester.get_chain()->add_effect(effect);
+	tester.run(out_data, GL_RED, COLORSPACE_REC_601_525, GAMMA_LINEAR);
+
+	Node *node = effect->invert_node;
+	ASSERT_EQ(1, node->incoming_links.size());
+	ASSERT_EQ(1, node->outgoing_links.size());
+	EXPECT_EQ("ColorspaceConversionEffect", node->incoming_links[0]->effect->effect_type_id());
+	EXPECT_EQ("ColorspaceConversionEffect", node->outgoing_links[0]->effect->effect_type_id());
+
+	expect_equal(expected_data, out_data, 3, 2);
+}
+
+// A fake input that can change its output colorspace and gamma between instantiation
+// and finalize.
+class UnknownColorspaceInput : public FlatInput {
+public:
+	UnknownColorspaceInput(ImageFormat format, MovitPixelFormat pixel_format, GLenum type, unsigned width, unsigned height)
+	    : FlatInput(format, pixel_format, type, width, height),
+	      overridden_color_space(format.color_space),
+	      overridden_gamma_curve(format.gamma_curve) {}
+	virtual std::string effect_type_id() const { return "UnknownColorspaceInput"; }
+
+	void set_color_space(Colorspace colorspace) {
+		overridden_color_space = colorspace;
+	}
+	void set_gamma_curve(GammaCurve gamma_curve) {
+		overridden_gamma_curve = gamma_curve;
+	}
+	Colorspace get_color_space() const { return overridden_color_space; }
+	GammaCurve get_gamma_curve() const { return overridden_gamma_curve; }
+
+private:
+	Colorspace overridden_color_space;
+	GammaCurve overridden_gamma_curve;
+};
+
+TEST(EffectChainTester, HandlesInputChangingColorspace) {
+	const int size = 4;
+
+	float data[size] = {
+		0.0,
+		0.5,
+		0.7,
+		1.0,
+	};
+	float out_data[size];
+
+	EffectChainTester tester(NULL, 4, 1, FORMAT_GRAYSCALE);
+
+	// First say that we have sRGB, linear input.
+	ImageFormat format;
+	format.color_space = COLORSPACE_sRGB;
+	format.gamma_curve = GAMMA_LINEAR;
+
+	UnknownColorspaceInput *input = new UnknownColorspaceInput(format, FORMAT_GRAYSCALE, GL_FLOAT, 4, 1);
+	input->set_pixel_data(data);
+	tester.get_chain()->add_input(input);
+
+	// Now we change to Rec. 601 input.
+	input->set_color_space(COLORSPACE_REC_601_625);
+	input->set_gamma_curve(GAMMA_REC_601);
+
+	// Now ask for Rec. 601 output. Thus, our chain should now be a no-op.
+	tester.run(out_data, GL_RED, COLORSPACE_REC_601_625, GAMMA_REC_601);
+	expect_equal(data, out_data, 4, 1);
+}
+
 // Like RewritingToInvertEffect, but splicing in a MirrorEffect instead,
-// which does not need linear light.
+// which does not need linear light or sRGB primaries.
 class RewritingToMirrorEffect : public Effect {
 public:
 	RewritingToMirrorEffect() {}
@@ -177,6 +286,29 @@ TEST(EffectChainTest, NoGammaConversionsWhenLinearLightNotNeeded) {
 	expect_equal(expected_data, out_data, 3, 2);
 }
 
+TEST(EffectChainTest, NoColorspaceConversionsWhensRGBPrimariesNotNeeded) {
+	float data[] = {
+		0.0f, 0.25f, 0.3f,
+		0.75f, 1.0f, 1.0f,
+	};
+	float expected_data[6] = {
+		0.3f, 0.25f, 0.0f,
+		1.0f, 1.0f, 0.75f,
+	};
+	float out_data[6];
+	EffectChainTester tester(data, 3, 2, FORMAT_GRAYSCALE, COLORSPACE_REC_601_525, GAMMA_LINEAR);
+	RewritingToMirrorEffect *effect = new RewritingToMirrorEffect();
+	tester.get_chain()->add_effect(effect);
+	tester.run(out_data, GL_RED, COLORSPACE_REC_601_525, GAMMA_LINEAR);
+
+	Node *node = effect->mirror_node;
+	ASSERT_EQ(1, node->incoming_links.size());
+	EXPECT_EQ(0, node->outgoing_links.size());
+	EXPECT_EQ("FlatInput", node->incoming_links[0]->effect->effect_type_id());
+
+	expect_equal(expected_data, out_data, 3, 2);
+}
+
 // The identity effect needs linear light, and thus will get conversions on both sides.
 // Verify that sRGB data is properly converted to and from linear light for the entire ramp.
 TEST(EffectChainTest, IdentityThroughsRGBConversions) {
@@ -192,6 +324,23 @@ TEST(EffectChainTest, IdentityThroughsRGBConversions) {
 	expect_equal(data, out_data, 256, 1);
 }
 
+// Same, but uses the forward sRGB table from the GPU.
+TEST(EffectChainTest, IdentityThroughGPUsRGBConversions) {
+	unsigned char data[256];
+	float expected_data[256];
+	for (unsigned i = 0; i < 256; ++i) {
+		data[i] = i;
+		expected_data[i] = i / 255.0;
+	};
+	float out_data[256];
+	EffectChainTester tester(NULL, 256, 1);
+	tester.add_input(data, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_sRGB);
+	tester.get_chain()->add_effect(new IdentityEffect());
+	tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_sRGB);
+
+	expect_equal(expected_data, out_data, 256, 1);
+}
+
 // Same, for the Rec. 601/709 gamma curve.
 TEST(EffectChainTest, IdentityThroughRec709) {
 	float data[256];
@@ -206,6 +355,118 @@ TEST(EffectChainTest, IdentityThroughRec709) {
 	expect_equal(data, out_data, 256, 1);
 }
 
+// The identity effect needs premultiplied alpha, and thus will get conversions on both sides.
+TEST(EffectChainTest, IdentityThroughAlphaConversions) {
+	const int size = 3;
+	float data[4 * size] = {
+		0.8f, 0.0f, 0.0f, 0.5f,
+		0.0f, 0.2f, 0.2f, 0.3f,
+		0.1f, 0.0f, 1.0f, 1.0f,
+	};
+	float out_data[6];
+	EffectChainTester tester(data, size, 1, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR);
+	tester.get_chain()->add_effect(new IdentityEffect());
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR);
+
+	expect_equal(data, out_data, 4, size);
+}
+
+TEST(EffectChainTest, NoAlphaConversionsWhenPremultipliedAlphaNotNeeded) {
+	const int size = 3;
+	float data[4 * size] = {
+		0.8f, 0.0f, 0.0f, 0.5f,
+		0.0f, 0.2f, 0.2f, 0.3f,
+		0.1f, 0.0f, 1.0f, 1.0f,
+	};
+	float expected_data[4 * size] = {
+		0.1f, 0.0f, 1.0f, 1.0f,
+		0.0f, 0.2f, 0.2f, 0.3f,
+		0.8f, 0.0f, 0.0f, 0.5f,
+	};
+	float out_data[4 * size];
+	EffectChainTester tester(data, size, 1, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR);
+	RewritingToMirrorEffect *effect = new RewritingToMirrorEffect();
+	tester.get_chain()->add_effect(effect);
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR);
+
+	Node *node = effect->mirror_node;
+	ASSERT_EQ(1, node->incoming_links.size());
+	EXPECT_EQ(0, node->outgoing_links.size());
+	EXPECT_EQ("FlatInput", node->incoming_links[0]->effect->effect_type_id());
+
+	expect_equal(expected_data, out_data, 4, size);
+}
+
+// An input that outputs only blue, which has blank alpha.
+class BlueInput : public Input {
+public:
+	BlueInput() { register_int("needs_mipmaps", &needs_mipmaps); }
+	virtual std::string effect_type_id() const { return "IdentityEffect"; }
+	std::string output_fragment_shader() { return read_file("blue.frag"); }
+	virtual AlphaHandling alpha_handling() const { return OUTPUT_BLANK_ALPHA; }
+	virtual void finalize() {}
+	virtual bool can_output_linear_gamma() const { return true; }
+	virtual unsigned get_width() const { return 1; }
+	virtual unsigned get_height() const { return 1; }
+	virtual Colorspace get_color_space() const { return COLORSPACE_sRGB; }
+	virtual GammaCurve get_gamma_curve() const { return GAMMA_LINEAR; }
+
+private:
+	int needs_mipmaps;
+};
+
+// Like RewritingToInvertEffect, but splicing in a BlueInput instead,
+// which outputs blank alpha.
+class RewritingToBlueInput : public Input {
+public:
+	RewritingToBlueInput() { register_int("needs_mipmaps", &needs_mipmaps); }
+	virtual std::string effect_type_id() const { return "RewritingToBlueInput"; }
+	std::string output_fragment_shader() { EXPECT_TRUE(false); return read_file("identity.frag"); }
+	virtual void rewrite_graph(EffectChain *graph, Node *self) {
+		Node *blue_node = graph->add_node(new BlueInput());
+		graph->replace_receiver(self, blue_node);
+		graph->replace_sender(self, blue_node);
+
+		self->disabled = true;
+		this->blue_node = blue_node;
+	}
+
+	// Dummy values that we need to implement because we inherit from Input.
+	// Same as BlueInput.
+	virtual AlphaHandling alpha_handling() const { return OUTPUT_BLANK_ALPHA; }
+	virtual void finalize() {}
+	virtual bool can_output_linear_gamma() const { return true; }
+	virtual unsigned get_width() const { return 1; }
+	virtual unsigned get_height() const { return 1; }
+	virtual Colorspace get_color_space() const { return COLORSPACE_sRGB; }
+	virtual GammaCurve get_gamma_curve() const { return GAMMA_LINEAR; }
+
+	Node *blue_node;
+
+private:
+	int needs_mipmaps;
+};
+
+TEST(EffectChainTest, NoAlphaConversionsWithBlankAlpha) {
+	const int size = 3;
+	float data[4 * size] = {
+		0.0f, 0.0f, 1.0f, 1.0f,
+		0.0f, 0.0f, 1.0f, 1.0f,
+		0.0f, 0.0f, 1.0f, 1.0f,
+	};
+	float out_data[4 * size];
+	EffectChainTester tester(NULL, size, 1);
+	RewritingToBlueInput *input = new RewritingToBlueInput();
+	tester.get_chain()->add_input(input);
+	tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR, OUTPUT_ALPHA_PREMULTIPLIED);
+
+	Node *node = input->blue_node;
+	EXPECT_EQ(0, node->incoming_links.size());
+	EXPECT_EQ(0, node->outgoing_links.size());
+
+	expect_equal(data, out_data, 4, size);
+}
+
 // Effectively scales down its input linearly by 4x (and repeating it),
 // which is not attainable without mipmaps.
 class MipmapNeedingEffect : public Effect {