X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=effect_chain_test.cpp;h=adf832ac61e4ad445f115a72b83f324352f78812;hp=ab71b4b5026ebfd1b5649849f5754700ed85ee4f;hb=009c7510df1ac1b70662b0085ebaf1a619dd761a;hpb=9651a4eaae012cdc49c1aa38197861e04f62e91e diff --git a/effect_chain_test.cpp b/effect_chain_test.cpp index ab71b4b..adf832a 100644 --- a/effect_chain_test.cpp +++ b/effect_chain_test.cpp @@ -2,7 +2,11 @@ // // Note that this also contains the tests for some of the simpler effects. -#include +#include +#include +#include + +#include #include #include "effect.h" @@ -19,6 +23,8 @@ using namespace std; +namespace movit { + TEST(EffectChainTest, EmptyChain) { float data[] = { 0.0f, 0.25f, 0.3f, @@ -92,6 +98,25 @@ TEST(MirrorTest, BasicTest) { expect_equal(expected_data, out_data, 3, 2); } +TEST(EffectChainTest, TopLeftOrigin) { + float data[] = { + 0.0f, 0.25f, 0.3f, + 0.75f, 1.0f, 1.0f, + }; + // Note that EffectChainTester assumes bottom-left origin, so by setting + // top-left, we will get flipped data back. + float expected_data[6] = { + 0.75f, 1.0f, 1.0f, + 0.0f, 0.25f, 0.3f, + }; + float out_data[6]; + EffectChainTester tester(data, 3, 2, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR); + tester.get_chain()->set_output_origin(OUTPUT_ORIGIN_TOP_LEFT); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(expected_data, out_data, 3, 2); +} + // A dummy effect that inverts its input. class InvertEffect : public Effect { public: @@ -150,19 +175,23 @@ TEST(EffectChainTest, RewritingWorksAndGammaConversionsAreInserted) { TEST(EffectChainTest, RewritingWorksAndTexturesAreAskedForsRGB) { unsigned char data[] = { - 0, 64, - 128, 255, + 0, 0, 0, 255, + 64, 64, 64, 255, + 128, 128, 128, 255, + 255, 255, 255, 255, }; - float expected_data[4] = { - 1.0f, 0.9771f, - 0.8983f, 0.0f, + float expected_data[] = { + 1.0000f, 1.0000f, 1.0000f, 1.0000f, + 0.9771f, 0.9771f, 0.9771f, 1.0000f, + 0.8983f, 0.8983f, 0.8983f, 1.0000f, + 0.0000f, 0.0000f, 0.0000f, 1.0000f }; - float out_data[4]; - EffectChainTester tester(NULL, 2, 2); - tester.add_input(data, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_sRGB); + float out_data[4 * 4]; + EffectChainTester tester(NULL, 1, 4); + tester.add_input(data, FORMAT_RGBA_POSTMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_sRGB); RewritingEffect *effect = new RewritingEffect(); tester.get_chain()->add_effect(effect); - tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_sRGB); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB); Node *node = effect->replaced_node; ASSERT_EQ(1, node->incoming_links.size()); @@ -170,7 +199,7 @@ TEST(EffectChainTest, RewritingWorksAndTexturesAreAskedForsRGB) { EXPECT_EQ("FlatInput", node->incoming_links[0]->effect->effect_type_id()); EXPECT_EQ("GammaCompressionEffect", node->outgoing_links[0]->effect->effect_type_id()); - expect_equal(expected_data, out_data, 2, 2); + expect_equal(expected_data, out_data, 4, 4); } TEST(EffectChainTest, RewritingWorksAndColorspaceConversionsAreInserted) { @@ -221,7 +250,7 @@ private: GammaCurve overridden_gamma_curve; }; -TEST(EffectChainTester, HandlesInputChangingColorspace) { +TEST(EffectChainTest, HandlesInputChangingColorspace) { const int size = 4; float data[size] = { @@ -520,17 +549,27 @@ class MipmapNeedingEffect : public Effect { public: MipmapNeedingEffect() {} virtual bool needs_mipmaps() const { return true; } + + // To be allowed to mess with the sampler state. + virtual bool needs_texture_bounce() const { return true; } + virtual string effect_type_id() const { return "MipmapNeedingEffect"; } string output_fragment_shader() { return read_file("mipmap_needing_effect.frag"); } + virtual void inform_added(EffectChain *chain) { this->chain = chain; } + void set_gl_state(GLuint glsl_program_num, const string& prefix, unsigned *sampler_num) { - glActiveTexture(GL_TEXTURE0); + Node *self = chain->find_node_for_effect(this); + glActiveTexture(chain->get_input_sampler(self, 0)); check_error(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_REPEAT); check_error(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_REPEAT); check_error(); } + +private: + EffectChain *chain; }; TEST(EffectChainTest, MipmapGenerationWorks) { @@ -584,6 +623,81 @@ TEST(EffectChainTest, MipmapGenerationWorks) { expect_equal(expected_data, out_data, 4, 16); } +class NonMipmapCapableInput : public FlatInput { +public: + NonMipmapCapableInput(ImageFormat format, MovitPixelFormat pixel_format, GLenum type, unsigned width, unsigned height) + : FlatInput(format, pixel_format, type, width, height) {} + + virtual bool can_supply_mipmaps() const { return false; } + bool set_int(const std::string& key, int value) { + if (key == "needs_mipmaps") { + assert(value == 0); + } + return FlatInput::set_int(key, value); + } +}; + +// The same test as MipmapGenerationWorks, but with an input that refuses +// to supply mipmaps. +TEST(EffectChainTest, MipmapsWithNonMipmapCapableInput) { + float data[] = { // In 4x4 blocks. + 1.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 1.0f, + + 0.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 0.5f, 0.0f, 0.0f, + 0.0f, 0.0f, 1.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 0.0f, + + 1.0f, 1.0f, 1.0f, 1.0f, + 1.0f, 1.0f, 1.0f, 1.0f, + 1.0f, 1.0f, 1.0f, 1.0f, + 1.0f, 1.0f, 1.0f, 1.0f, + + 0.0f, 0.0f, 0.0f, 0.0f, + 0.0f, 1.0f, 1.0f, 0.0f, + 0.0f, 1.0f, 1.0f, 0.0f, + 0.0f, 0.0f, 0.0f, 0.0f, + }; + float expected_data[] = { // Repeated four times each way. + 0.125f, 0.125f, 0.125f, 0.125f, + 0.09375f, 0.09375f, 0.09375f, 0.09375f, + 1.0f, 1.0f, 1.0f, 1.0f, + 0.25f, 0.25f, 0.25f, 0.25f, + + 0.125f, 0.125f, 0.125f, 0.125f, + 0.09375f, 0.09375f, 0.09375f, 0.09375f, + 1.0f, 1.0f, 1.0f, 1.0f, + 0.25f, 0.25f, 0.25f, 0.25f, + + 0.125f, 0.125f, 0.125f, 0.125f, + 0.09375f, 0.09375f, 0.09375f, 0.09375f, + 1.0f, 1.0f, 1.0f, 1.0f, + 0.25f, 0.25f, 0.25f, 0.25f, + + 0.125f, 0.125f, 0.125f, 0.125f, + 0.09375f, 0.09375f, 0.09375f, 0.09375f, + 1.0f, 1.0f, 1.0f, 1.0f, + 0.25f, 0.25f, 0.25f, 0.25f, + }; + float out_data[4 * 16]; + EffectChainTester tester(NULL, 4, 16, FORMAT_GRAYSCALE); + + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_LINEAR; + + NonMipmapCapableInput *input = new NonMipmapCapableInput(format, FORMAT_GRAYSCALE, GL_FLOAT, 4, 16); + input->set_pixel_data(data); + tester.get_chain()->add_input(input); + tester.get_chain()->add_effect(new MipmapNeedingEffect()); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(expected_data, out_data, 4, 16); +} + TEST(EffectChainTest, ResizeDownByFourThenUpByFour) { float data[] = { // In 4x4 blocks. 1.0f, 0.0f, 0.0f, 0.0f, @@ -837,7 +951,7 @@ TEST(EffectChainTest, SameInputsGiveSameOutputs) { 0.0f, 0.0f, 0.0f, 0.0f, }; - float out_data[2 * 2]; + float out_data[4 * 3]; EffectChainTester tester(NULL, 4, 3); // Note non-square aspect. @@ -908,6 +1022,38 @@ TEST(EffectChainTest, AspectRatioConversion) { EXPECT_EQ(7, input_store->input_height); } +// Tests that putting a BlueInput (constant color) into its own pass, +// which creates a phase that doesn't need texture coordinates, +// doesn't mess up a second phase that actually does. +TEST(EffectChainTest, FirstPhaseWithNoTextureCoordinates) { + const int size = 2; + float data[] = { + 1.0f, + 0.0f, + }; + float expected_data[] = { + 1.0f, 1.0f, 2.0f, 2.0f, + 0.0f, 0.0f, 1.0f, 2.0f, + }; + float out_data[size * 4]; + // First say that we have sRGB, linear input. + ImageFormat format; + format.color_space = COLORSPACE_sRGB; + format.gamma_curve = GAMMA_LINEAR; + FlatInput *input = new FlatInput(format, FORMAT_GRAYSCALE, GL_FLOAT, 1, size); + + input->set_pixel_data(data); + EffectChainTester tester(NULL, 1, size); + tester.get_chain()->add_input(new BlueInput()); + Effect *phase1_end = tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.get_chain()->add_input(input); + tester.get_chain()->add_effect(new AddEffect(), phase1_end, input); + + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR, OUTPUT_ALPHA_FORMAT_POSTMULTIPLIED); + + expect_equal(expected_data, out_data, 4, size); +} + // An effect that does nothing except changing its output sizes. class VirtualResizeEffect : public Effect { public: @@ -958,7 +1104,92 @@ TEST(EffectChainTest, VirtualSizeIsSentOnToInputs) { expect_equal(data, out_data, size, size); } -extern bool movit_initialized; +// An effect that is like VirtualResizeEffect, but always has virtual and real +// sizes the same (and promises this). +class NonVirtualResizeEffect : public VirtualResizeEffect { +public: + NonVirtualResizeEffect(int width, int height) + : VirtualResizeEffect(width, height, width, height) {} + virtual string effect_type_id() const { return "NonVirtualResizeEffect"; } + virtual bool sets_virtual_output_size() const { return false; } +}; + +// An effect that promises one-to-one sampling (unlike IdentityEffect). +class OneToOneEffect : public Effect { +public: + OneToOneEffect() {} + virtual string effect_type_id() const { return "OneToOneEffect"; } + string output_fragment_shader() { return read_file("identity.frag"); } + virtual bool one_to_one_sampling() const { return true; } +}; + +TEST(EffectChainTest, NoBounceWithOneToOneSampling) { + const int size = 2; + float data[size * size] = { + 1.0f, 0.0f, + 0.0f, 1.0f, + }; + float out_data[size * size]; + + EffectChainTester tester(data, size, size, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR); + + RewritingEffect *effect1 = new RewritingEffect(); + RewritingEffect *effect2 = new RewritingEffect(); + + tester.get_chain()->add_effect(new NonVirtualResizeEffect(size, size)); + tester.get_chain()->add_effect(effect1); + tester.get_chain()->add_effect(effect2); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(data, out_data, size, size); + + // The first OneToOneEffect should be in the same phase as its input. + ASSERT_EQ(1, effect1->replaced_node->incoming_links.size()); + EXPECT_EQ(effect1->replaced_node->incoming_links[0]->containing_phase, + effect1->replaced_node->containing_phase); + + // The second OneToOneEffect, too. + EXPECT_EQ(effect1->replaced_node->containing_phase, + effect2->replaced_node->containing_phase); +} + +TEST(EffectChainTest, BounceWhenOneToOneIsBroken) { + const int size = 2; + float data[size * size] = { + 1.0f, 0.0f, + 0.0f, 1.0f, + }; + float out_data[size * size]; + + EffectChainTester tester(data, size, size, FORMAT_GRAYSCALE, COLORSPACE_sRGB, GAMMA_LINEAR); + + RewritingEffect *effect1 = new RewritingEffect(); + RewritingEffect *effect2 = new RewritingEffect(); + RewritingEffect *effect3 = new RewritingEffect(); + RewritingEffect *effect4 = new RewritingEffect(); + + tester.get_chain()->add_effect(new NonVirtualResizeEffect(size, size)); + tester.get_chain()->add_effect(effect1); + tester.get_chain()->add_effect(effect2); + tester.get_chain()->add_effect(effect3); + tester.get_chain()->add_effect(effect4); + tester.run(out_data, GL_RED, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(data, out_data, size, size); + + // The NonVirtualResizeEffect should be in a different phase from + // the IdentityEffect (since the latter is not one-to-one), + // ie., the chain should be broken somewhere between them, but exactly + // where doesn't matter. + ASSERT_EQ(1, effect1->replaced_node->incoming_links.size()); + EXPECT_NE(effect1->replaced_node->incoming_links[0]->containing_phase, + effect3->replaced_node->containing_phase); + + // The last OneToOneEffect should also be in the same phase as the + // IdentityEffect (the phase was already broken). + EXPECT_EQ(effect3->replaced_node->containing_phase, + effect4->replaced_node->containing_phase); +} // Does not use EffectChainTest, so that it can construct an EffectChain without // a shared ResourcePool (which is also properly destroyed afterwards). @@ -973,11 +1204,10 @@ TEST(EffectChainTest, IdentityWithOwnPool) { 0.75f, 1.0f, 1.0f, 0.0f, 0.25f, 0.3f, }; - float out_data[6]; + float out_data[6], temp[6 * 4]; EffectChain chain(width, height); - movit_initialized = false; - init_movit(".", MOVIT_DEBUG_ON); + movit_debug_level = MOVIT_DEBUG_ON; ImageFormat format; format.color_space = COLORSPACE_sRGB; @@ -993,7 +1223,7 @@ TEST(EffectChainTest, IdentityWithOwnPool) { check_error(); glBindTexture(GL_TEXTURE_2D, texnum); check_error(); - glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA32F, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, NULL); + glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA32F, width, height, 0, GL_RGBA, GL_FLOAT, NULL); check_error(); glGenFramebuffers(1, &fbo); @@ -1015,11 +1245,78 @@ TEST(EffectChainTest, IdentityWithOwnPool) { chain.render_to_fbo(fbo, width, height); glBindFramebuffer(GL_FRAMEBUFFER, fbo); - glReadPixels(0, 0, width, height, GL_RED, GL_FLOAT, out_data); + check_error(); + glReadPixels(0, 0, width, height, GL_RGBA, GL_FLOAT, temp); + check_error(); + for (unsigned i = 0; i < 6; ++i) { + out_data[i] = temp[i * 4]; + } expect_equal(expected_data, out_data, width, height); // Reset the debug status again. - movit_initialized = false; - init_movit(".", MOVIT_DEBUG_OFF); + movit_debug_level = MOVIT_DEBUG_OFF; } + +// A dummy effect whose only purpose is to test sprintf decimal behavior. +class PrintfingBlueEffect : public Effect { +public: + PrintfingBlueEffect() {} + virtual string effect_type_id() const { return "PrintfingBlueEffect"; } + string output_fragment_shader() { + stringstream ss; + ss.imbue(locale("C")); + ss.precision(8); + ss << "vec4 FUNCNAME(vec2 tc) { return vec4(" + << 0.0f << ", " << 0.0f << ", " + << 0.5f << ", " << 1.0f << "); }\n"; + return ss.str(); + } +}; + +TEST(EffectChainTest, StringStreamLocalesWork) { + // An example of a locale with comma instead of period as decimal separator. + // Obviously, if you run on a machine without this locale available, + // the test will always succeed. Note that the OpenGL driver might call + // setlocale() behind-the-scenes, and that might corrupt the returned + // pointer, so we need to take our own copy of it here. + char *saved_locale = setlocale(LC_ALL, "nb_NO.UTF_8"); + if (saved_locale == NULL) { + // The locale wasn't available. + return; + } + saved_locale = strdup(saved_locale); + float data[] = { + 0.0f, 0.0f, 0.0f, 0.0f, + }; + float expected_data[] = { + 0.0f, 0.0f, 0.5f, 1.0f, + }; + float out_data[4]; + EffectChainTester tester(data, 1, 1, FORMAT_RGBA_PREMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR); + tester.get_chain()->add_effect(new PrintfingBlueEffect()); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR); + + expect_equal(expected_data, out_data, 4, 1); + + setlocale(LC_ALL, saved_locale); + free(saved_locale); +} + +TEST(EffectChainTest, sRGBIntermediate) { + float data[] = { + 0.0f, 0.5f, 0.0f, 1.0f, + }; + float out_data[4]; + EffectChainTester tester(data, 1, 1, FORMAT_RGBA_PREMULTIPLIED_ALPHA, COLORSPACE_sRGB, GAMMA_LINEAR, GL_RGBA16F_ARB, GL_SRGB8); + tester.get_chain()->add_effect(new IdentityEffect()); + tester.get_chain()->add_effect(new BouncingIdentityEffect()); + tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_LINEAR); + + EXPECT_GE(fabs(out_data[1] - data[1]), 1e-3) + << "Expected sRGB not to be able to represent 0.5 exactly (got " << out_data[1] << ")"; + EXPECT_LT(fabs(out_data[1] - data[1]), 0.1f) + << "Expected sRGB to be able to represent 0.5 approximately (got " << out_data[1] << ")"; +} + +} // namespace movit