X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=flat_input.cpp;h=5323dac19ead8663060eaa023f51ea000da2a995;hp=28380f4ad19a94a763292ae85f79ab6578e1b216;hb=ecab6f3b08bc0a995dd96542758031f1ba2c6a27;hpb=9cf78e3b5a801b7841133011f74fc7962861705d diff --git a/flat_input.cpp b/flat_input.cpp index 28380f4..5323dac 100644 --- a/flat_input.cpp +++ b/flat_input.cpp @@ -4,6 +4,7 @@ #include "effect_util.h" #include "flat_input.h" +#include "resource_pool.h" #include "util.h" FlatInput::FlatInput(ImageFormat image_format, MovitPixelFormat pixel_format, GLenum type, unsigned width, unsigned height) @@ -29,8 +30,7 @@ FlatInput::FlatInput(ImageFormat image_format, MovitPixelFormat pixel_format, GL FlatInput::~FlatInput() { if (texture_num != 0) { - glDeleteTextures(1, &texture_num); - check_error(); + resource_pool->release_2d_texture(texture_num); } } @@ -39,7 +39,7 @@ void FlatInput::finalize() // Translate the input format to OpenGL's enums. GLenum internal_format; if (type == GL_FLOAT) { - internal_format = GL_RGBA16F_ARB; + internal_format = GL_RGBA32F_ARB; } else if (output_linear_gamma) { assert(type == GL_UNSIGNED_BYTE); internal_format = GL_SRGB8_ALPHA8; @@ -64,20 +64,11 @@ void FlatInput::finalize() } // Create the texture itself. - glGenTextures(1, &texture_num); - check_error(); + texture_num = resource_pool->create_2d_texture(internal_format, width, height); glBindTexture(GL_TEXTURE_2D, texture_num); check_error(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, needs_mipmaps ? GL_LINEAR_MIPMAP_NEAREST : GL_LINEAR); check_error(); - // Intel/Mesa seems to have a broken glGenerateMipmap() for non-FBO textures, so do it here - // instead of calling glGenerateMipmap(). - glTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, needs_mipmaps ? GL_TRUE : GL_FALSE); - check_error(); - glTexImage2D(GL_TEXTURE_2D, 0, internal_format, width, height, 0, format, type, NULL); - check_error(); - glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); - check_error(); glBindTexture(GL_TEXTURE_2D, 0); check_error(); @@ -91,6 +82,8 @@ void FlatInput::set_gl_state(GLuint glsl_program_num, const std::string& prefix, check_error(); glBindTexture(GL_TEXTURE_2D, texture_num); check_error(); + glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); + check_error(); if (needs_update) { // Re-upload the texture. @@ -102,6 +95,10 @@ void FlatInput::set_gl_state(GLuint glsl_program_num, const std::string& prefix, check_error(); glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, width, height, format, type, pixel_data); check_error(); + if (needs_mipmaps) { + glGenerateMipmap(GL_TEXTURE_2D); + check_error(); + } glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); check_error(); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);